rpcdaemon: Fix on eth_estimateGas with stateOverrides #17914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lupin012
requested review from
AskAlexSharov,
Giulio2002,
canepat and
yperbasis
as code owners
AskAlexSharov
approved these changes
Nov 17, 2025
canepat
added a commit
that referenced
this pull request
Nov 17, 2025
…sent (#17935) Fixes regression on Hive test `ethSimulate-self-destructive-contract-produces-logs` introduced by #17914 For being conservative, `CommitBlock` has been inserted/enabled only for APIs where tests utilising `stateOverrides` exist. In all other cases, `Overrides` is called without a subsequent `CommitBlock`. Tests will subsequently be conducted for these cases, and `CommitBlock` will be inserted if necessary. --------- Co-authored-by: canepat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #17869
The PR contains fixes:
The rpc-tests are updated wiith same call data request as issue for the following rpc-api on latest:
the response are verificated with Geth