Remove PoW mining #17813
Merged
Remove PoW mining #17813
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yperbasis
requested review from
AskAlexSharov,
Giulio2002 and
mh0lt
as code owners
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes Proof-of-Work (PoW) mining functionality from the codebase, eliminating deprecated mining configuration options and related infrastructure.
- Removed
StartMiningmethod and associated PoW mining loop from the backend - Removed mining-related configuration parameters (
GasPrice,Recommit,Enabled,Noverify,Notify,SigKey) - Simplified ethash engine initialization by removing remote miner notification support
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| polygon/tests/helper/miner.go | Removed PoW-specific miner configuration fields |
| node/rulesconfig/config.go | Removed notify parameter from rules engine creation |
| node/ethconfig/config.go | Removed default miner configuration settings |
| node/eth/backend.go | Removed StartMining method, mining loop, and related fields |
| node/cli/default_flags.go | Removed PoW mining CLI flags |
| execution/tests/mock/mock_sentry.go | Removed PoW-specific mocking configuration |
| execution/protocol/rules/ethash/sealer_test.go | Removed remote notification tests |
| execution/protocol/rules/ethash/sealer.go | Removed remote sealer notification logic |
| execution/protocol/rules/ethash/ethashcfg/ethashcfg.go | Removed NotifyFull configuration option |
| execution/protocol/rules/ethash/ethash_test.go | Updated test calls to remove notify parameter |
| execution/protocol/rules/ethash/ethash.go | Removed notify parameter from constructor functions |
| execution/builder/buildercfg/mining.go | Removed PoW-related fields from MiningConfig |
| cmd/utils/flags.go | Removed PoW mining flag definitions and validation logic |
| cmd/integration/commands/state_stages.go | Removed mining stage initialization and execution |
| cmd/integration/commands/stages.go | Simplified newSync function signature |
| cmd/integration/commands/flags.go | Removed PoW mining flag definitions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mh0lt
approved these changes
Nov 11, 2025
mh0lt
pushed a commit
that referenced
this pull request
Nov 11, 2025
This was referenced Nov 11, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.