Skip to content

Conversation

@domiwei
Copy link
Member

@domiwei domiwei commented Oct 16, 2025

issue: #17452

@awskii
Copy link
Member

awskii commented Oct 16, 2025

@domiwei there is another issue related to it. Specifically when L2 client queries beacon chain

l2-nitro  | WARN [10-15|10:50:02.734] error reading inbox                      err="failed to get blobs: error fetching blobs for slot 8732630: beacon client in getBlobs got error fetching non-expired blobs in slot: 8732630, err: Get \"http://l1-erigon:9093/eth/v1/beacon/blobs/8732630?versioned_hashes=0x01c76ef2a0929ef23d2f2082fffeae1296196b2958eb8f68b908f594007c7c8e&versioned_hashes=0x01edc7a36ef4bb1424293f834a208397d93ba695be52008a521eadb00c3d89f3&versioned_hashes=0x012fffcbff674efe662a51507b745e141ccd156f01b72719765fd58177a31f9b&versioned_hashes=0x0114650ca6e6cf87b8d9ef03657489c16d96cee687cd50dce9f310b16872db61&versioned_hashes=0x01b42233f8d92485818e373b397d7cc24150d20ce4c9599ed271df2ebfc9a876\": EOF"

Which is not happening when IF in your commit is commented/removed.

To me it looks very strange since handler of v1/beacon/blobs and v1/beacon/blob_sidecars does not interact and should not affect each other.

This query is about Sepolia testnet. I have a node for testing if needed.

When i yesterday did curl with this request, i got EOF as well (against the main) If i did it against (your/mine patch) i got correct response.
Slot is known to be after fusaka.

@awskii
Copy link
Member

awskii commented Oct 16, 2025

#17458 my patch fyi

@awskii
Copy link
Member

awskii commented Oct 16, 2025

So this is a deeper question: which handler should be marked as DEPRECATED, which not, down to the spec.

@Giulio2002
Copy link
Contributor

If we can agreebthis fixes it, then lets merge it and cherry pick it

@Giulio2002 Giulio2002 merged commit 5c005c3 into main Oct 16, 2025
17 checks passed
@Giulio2002 Giulio2002 deleted the kewei/allow_blobs_after_fusaka branch October 16, 2025 09:15
@yperbasis
Copy link
Member

@domiwei @Giulio2002 should it be cherry picked to release/3.2?

@Giulio2002
Copy link
Contributor

Yes

@Giulio2002
Copy link
Contributor

We probably need to make a release

@yperbasis
Copy link
Member

OK. Please raise a cherry pick PR. I'm going to kick off release process today or tomorrow.

domiwei added a commit that referenced this pull request Oct 16, 2025
@domiwei
Copy link
Member Author

domiwei commented Oct 16, 2025

@domiwei there is another issue related to it. Specifically when L2 client queries beacon chain

l2-nitro  | WARN [10-15|10:50:02.734] error reading inbox                      err="failed to get blobs: error fetching blobs for slot 8732630: beacon client in getBlobs got error fetching non-expired blobs in slot: 8732630, err: Get \"http://l1-erigon:9093/eth/v1/beacon/blobs/8732630?versioned_hashes=0x01c76ef2a0929ef23d2f2082fffeae1296196b2958eb8f68b908f594007c7c8e&versioned_hashes=0x01edc7a36ef4bb1424293f834a208397d93ba695be52008a521eadb00c3d89f3&versioned_hashes=0x012fffcbff674efe662a51507b745e141ccd156f01b72719765fd58177a31f9b&versioned_hashes=0x0114650ca6e6cf87b8d9ef03657489c16d96cee687cd50dce9f310b16872db61&versioned_hashes=0x01b42233f8d92485818e373b397d7cc24150d20ce4c9599ed271df2ebfc9a876\": EOF"

Which is not happening when IF in your commit is commented/removed.

To me it looks very strange since handler of v1/beacon/blobs and v1/beacon/blob_sidecars does not interact and should not affect each other.

This query is about Sepolia testnet. I have a node for testing if needed.

When i yesterday did curl with this request, i got EOF as well (against the main) If i did it against (your/mine patch) i got correct response. Slot is known to be after fusaka.

Let me think about this potential issue. Thanks

domiwei added a commit that referenced this pull request Oct 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants