Remove eth/67 code #17318
Merged
Remove eth/67 code #17318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes all references to ETH/67 protocol code after it was disabled, cleaning up the codebase by removing deprecated protocol version support.
Key changes:
- Replace all ETH/67 references with ETH/68 in tests and client configurations
- Remove ETH/67 protocol mappings and message handling logic
- Simplify transaction pool announcement logic by removing ETH/67-specific code paths
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| txnprovider/txpool/tests/helper/p2p_client.go | Update node database path from eth67 to eth68 |
| txnprovider/txpool/send.go | Remove ETH/67 transaction announcement logic and simplify to ETH/68+ only |
| txnprovider/txpool/fetch_test.go | Update test to use ETH/68 protocol and message IDs |
| turbo/privateapi/ethbackend.go | Change protocol version response from ETH/67 to ETH/68 |
| rpc/jsonrpc/receipts/handler_test.go | Update test message ID mapping from ETH/67 to ETH/68 |
| p2p/sentry/sentrymultiplexer_test.go | Update mock handshake response to use ETH/68 protocol |
| p2p/sentry/sentry_multi_client/sentry_multi_client.go | Replace ETH/67 message ID mappings with ETH/68 |
| p2p/sentry/sentry_grpc_server_test.go | Rename test function from ETH/67 to ETH/68 |
| p2p/sentry/libsentry/util_test.go | Update protocol tests from ETH/67 to ETH/68 |
| p2p/sentry/libsentry/protocol.go | Remove ETH/67 protocol mapping from ProtoIds |
| p2p/sentry/eth_handshake_test.go | Update handshake tests to use ETH/68 instead of ETH/67 |
| p2p/protocols/eth/protocol.go | Remove ETH/67 from protocol mappings and message ID tables |
| node/direct/sentry_client.go | Remove ETH/67 constant and protocol mappings |
| cmd/utils/flags.go | Replace ETH/67 node database path with ETH/69 |
| README.md | Update documentation to reflect ETH/69 instead of ETH/67 peering |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
taratorio
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove eth/67 code after it was disabled