-
Notifications
You must be signed in to change notification settings - Fork 1.5k
API get blobs #17076
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API get blobs #17076
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR implements the API for getting blobs as specified in the Fulu beacon API spec, along with updates to the peer DAS (Data Availability Sampling) state management. The changes introduce supernode functionality and modify how blob recovery is scheduled.
- Adds a new beacon API endpoint
/beacon/blobs/{block_id}for retrieving blob data - Introduces supernode detection logic in the peer DAS state
- Removes archived mode restriction for blob recovery scheduling
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| cl/beacon/handler/handler.go | Adds the new blob API route and fixes field name typo |
| cl/beacon/handler/blobs.go | Implements the GetEthV1BeaconBlobs endpoint with validation and blob retrieval logic |
| cl/das/state/state.go | Adds IsSupernode method to determine if node custody covers all columns |
| cl/das/state/interface.go | Adds IsSupernode method to PeerDasStateReader interface |
| cl/das/state/mock_services/peer_das_state_reader_mock.go | Updates mock with new interface method and type changes |
| cl/das/peer_das.go | Modifies TryScheduleRecover to allow supernode blob recovery |
| cl/phase1/network/services/data_column_sidecar_service.go | Removes archived mode check for scheduling blob recovery |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
new in fulu
https://ethereum.github.io/beacon-APIs/?urls.primaryName=dev#/Beacon/getBlobs