Skip to content

Conversation

@domiwei
Copy link
Member

@domiwei domiwei commented Sep 10, 2025

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR implements the API for getting blobs as specified in the Fulu beacon API spec, along with updates to the peer DAS (Data Availability Sampling) state management. The changes introduce supernode functionality and modify how blob recovery is scheduled.

  • Adds a new beacon API endpoint /beacon/blobs/{block_id} for retrieving blob data
  • Introduces supernode detection logic in the peer DAS state
  • Removes archived mode restriction for blob recovery scheduling

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
cl/beacon/handler/handler.go Adds the new blob API route and fixes field name typo
cl/beacon/handler/blobs.go Implements the GetEthV1BeaconBlobs endpoint with validation and blob retrieval logic
cl/das/state/state.go Adds IsSupernode method to determine if node custody covers all columns
cl/das/state/interface.go Adds IsSupernode method to PeerDasStateReader interface
cl/das/state/mock_services/peer_das_state_reader_mock.go Updates mock with new interface method and type changes
cl/das/peer_das.go Modifies TryScheduleRecover to allow supernode blob recovery
cl/phase1/network/services/data_column_sidecar_service.go Removes archived mode check for scheduling blob recovery

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Giulio2002 Giulio2002 enabled auto-merge (squash) September 11, 2025 09:54
@Giulio2002 Giulio2002 disabled auto-merge September 11, 2025 09:56
@Giulio2002 Giulio2002 enabled auto-merge (squash) September 11, 2025 09:56
@Giulio2002 Giulio2002 merged commit 25eb4ce into main Sep 11, 2025
18 checks passed
@Giulio2002 Giulio2002 deleted the kewei/api_get_blobs branch September 11, 2025 09:56
domiwei added a commit that referenced this pull request Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants