proposer_lookahead api and column data events #16457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domiwei
changed the title
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements initial beacon API support for the Fulu fork with data column sidecars functionality. The changes add support for handling data column storage and related API endpoints as part of the Ethereum beacon chain's Data Availability Sampling (DAS) feature.
Key changes include:
- Added data column storage integration with event emitters
- Implemented new API endpoints for data column sidecars retrieval
- Added proposer lookahead functionality to fork choice store
- Enhanced beacon response handling with custom headers
Reviewed Changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| cmd/caplin/caplin1/run.go | Integrate emitters parameter into data column storage and service constructors |
| cl/spectest/consensus_tests/fork_choice.go | Update test to include emitters parameter for data column storage |
| cl/sentinel/handlers/heartbeats.go | Add earliest available slot logging to status handler |
| cl/phase1/network/services/data_column_sidecar_service.go | Add event emitter support to data column sidecar service |
| cl/phase1/forkchoice/on_block.go | Add pending state data and proposer lookahead tracking |
| cl/phase1/forkchoice/mock_services/forkchoice_mock.go | Add mock method for proposer lookahead retrieval |
| cl/phase1/forkchoice/interface.go | Add proposer lookahead interface method |
| cl/phase1/forkchoice/forkchoice.go | Implement proposer lookahead caching functionality |
| cl/persistence/blob_storage/mock_services/data_column_storage_mock.go | Generated mock for data column storage interface |
| cl/persistence/blob_storage/data_column_db.go | Add event emission and improved error handling for data column operations |
| cl/beacon/handler/validator_test.go | Update test constructor with additional nil parameter |
| cl/beacon/handler/utils_test.go | Add mock data column storage to test setup |
| cl/beacon/handler/states.go | Implement proposer lookahead API endpoint |
| cl/beacon/handler/handler.go | Add data column storage field and debug API endpoint routing |
| cl/beacon/handler/events.go | Add data column sidecar event topic support |
| cl/beacon/handler/blobs.go | Implement data column sidecars retrieval API endpoint |
| cl/beacon/builder/client.go | Add support for Fulu fork in builder client |
| cl/beacon/beaconhttp/beacon_response.go | Add custom header support to beacon responses |
| cl/beacon/beaconhttp/api.go | Enable custom header handling in API responses |
| cl/beacon/beaconevents/operation_feed.go | Add data column sidecar event emission method |
| cl/beacon/beaconevents/model.go | Define data column sidecar event type and data structure |
Comments suppressed due to low confidence (1)
cl/persistence/blob_storage/data_column_db.go:52
- The emitters field is being set in the struct but the constructor parameter is not being assigned. The emitters parameter should be assigned:
emitters: emitters,
beaconChainConfig: beaconChainConfig,
Giulio2002
approved these changes
Aug 14, 2025
Contributor
|
pls resolve conflicts. LGTM for the rest |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
domiwei
force-pushed
the
kewei/fulu_api
branch
from
6ca813f to
451f4b4
Compare
NazariiDenha
pushed a commit
that referenced
this pull request
Oct 24, 2025
#16212 #14374 --------- Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#16212
#14374