rpcdaemon: Estimate gas align to geth #16397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AskAlexSharov
approved these changes
Aug 1, 2025
- seems `stream.IntercectKV` was exactly same as `UnionKV`. (while `stream.Intersect` is correct). Removed it. - added more docs to `HistoryRange` method - don't rename methods much now - to not disturb cherry-picks between `3.1` and `main`. will do after `3.1.1` release - in both places.
These test cases for modexp are taken from the perfnet.
Geth has more field on receipt blockTimestamp add to erigon only on eth_getBlockReceipt. Later we can decide to add the same field to other api changing last parameter of MarshalReceipt() --------- Co-authored-by: Michelangelo Riccobene <[email protected]>
An “error” level log causes end-to-end tests to fail. As discussed on Discord, this log should be set to Warn and not Error.
lupin012
force-pushed
the
estimateGas_align_to_geth
branch
from
8e69b98 to
3e95af8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the current SW (using rpc-test) the gas estimation Erigon and Geth are similar but not equal:
Geth: 5783, 5779, 548e, 54ca, bdac
Erigon: 5640, 56,22 53e8, 5424, bd2a
The Geth binary search makes less simulation to reach the goal (because select a better hi range value)
After the alignment to Geth: We have same result and some number of call simulation