Repository navigation
Conversation
Signed-off-by: Evan Rauner <[email protected]>
erauner12
force-pushed
the
fix/ask-user-question-validation
branch
from
August 18, 2026 03:05
c528822 to
61b3a37
Compare
5 of 6 tasks
Owner
Author
|
Superseded for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validate built-in ask_user inputs in both Go and Python ADK runtimes before confirmation handling.
Problem
Both implementations accepted:
Those invalid tool calls could request confirmation and pause the task without presenting a usable question. An invalid model tool call should return an error that the model can correct; it should not create an unanswerable input-required interaction for the user.
Change
Both runtimes now:
The tool descriptions also tell the model to provide at least one question. Runtime validation remains authoritative and does not depend on a model provider enforcing generated schemas.
Scope
This PR changes built-in ask_user validation only. It does not change A2A identity propagation, task persistence or exact task reads, confirmation transport formats, or client-side parsing and presentation.
Tests
Go:
Python:
Regression coverage verifies empty-list rejection, blank-text rejection, no confirmation call for invalid input, and unchanged valid pending/confirmed behavior in both runtimes.
Sanitized integration validation
Using an independent pure-A2A client against a private compatible v0.10 test deployment, the valid Python-runtime path produced one nonblank structured question with bounded choices. A later client process answered the retained interaction, and the same task reached terminal completion without resending the original request.
Invalid input rejection is established by the focused Go and Python unit tests; the live exercise verifies that the valid interaction path remains intact.
Intended upstream issue: kagent-dev/kagent#2468.