-
Notifications
You must be signed in to change notification settings - Fork 483
Phpcs (RFC) #1639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phpcs (RFC) #1639
Conversation
|
This pull request has some conflicts. Can you please fix this? |
|
Sure. I but merging it would probably be a bit premature unless you feel like making the gui/conf part of the plugin :) |
|
If you are having having problems creating the GUI parts, I can create the skeleton configuration dialog and you can take it from there (I am using |
|
@eranif that would be much appreciated. All I really need is a couple of input boxes for giving the path to php, the linter (phpcs/phpmd) and in phpmd's case a rules.xml. I just did the XML parsing for the phpmd plugin so now the GUI is all that I need for this to be ready :) |
|
So, you need a simple settings dialog box that can select 3 files, right? |
|
I haven't figure out how i'm supose to open wxcrafter in CodeLite, so instead I have installed the standalone version. At first it failed to launch (missing libpng12, im on Ubuntu 17.04), but after downloading the missing lib file it seams to work. I'll se if i can figure out how to get this working. I just saw a commit for the vim plugin that looks like it could be helpful in figuring out how to do this. I'll let you know how it goes :) |
|
Better working from within CodeLite. A wizard will come up...
click Finish and you are done. You can now edit the UI. |
|
I only get an option for wxFormBuilder :/ I'm also missing the wxCrafter tab from the tutorial |
Is it listed in Plugins? You seem to use Ubuntu, did you install wxCrafter also? It works flawlessly in my Ubuntu following the guide on the website and then install with: |
|
Which OS are you using? it should be bundled with CodeLite (wxCrafter plugin) |
|
Ubuntu 16.04 and also on Ubuntu 17.04, currently I'm using a self compiled version (the one in this pull request) but I can try the official on and the distribution later. |
|
The plugins is listed and enabled |
I have never tried that myself, so cannot help. But installing official will save you pain on this. |
This resolves the issue of clearing markeres in the right order, and just feels right :)
|
Ok I have re-factored the linters in to a single plugin and the code for that part is pretty much what I would consider ready, unless you have some comments. As for the options dialog I managed to create something in wxCrafter that looks right, but when I try to open the dialog from the menu it just crashes CodeLite instantly (no error in the logs) and I for one can not figure out how to get it to work. Any help at this point would be greatly appreciated. |
|
This sounds like missing symbols issues. |
|
Yep that fixed it :( |
|
@eranif I'm happy to say that I now think the plugin is ready for merge. Hope you feel the same :) |
|
Great, I will merge it later today and will test it on Windows (I am not sure if you tried it on Windows) |
|
Thanks that would probably be a good idea, though I have strived to keep it compatible. I have yet to figure out how to compile CodeLite on Windows. The README.md skips setting up wxWidget and the download link is doesn't work (looks like the right package is DwxMSW-3.0.3_gcc510TDM_x64_Dev.7z), but i still end up with a non informative fail about halfway threw the compile (current master branch on your repo mind you). |
|
FYI: CodeLite is built with wxWidgets 3.1 on Windows and it uses some custom build steps which are explained here in details: |
|
Are the tooltips in the dialog correct? (e.g. the field that says: |
|
Few comments:
clDEBUG() << "The filename is:" << m_fileName << clEndl;
other than that, I added some more debug messages to the log and ensured that the plugin is built properly on Windows (and installs) |
|
Thanks for the help :) Would it be helpful if I cleaned up other usages of CL_DEBUG, CL_WARNING & frinds? I'll keep the Windows install in mined if I do another plug-in. The only major feature I have plans for is PHP refactoring, but I'm not sure weather i should use an external phar tool or work with the build in lexer (might be above my skill set, but if you feel like helping I could probably learn). |
|
P.s. i think PHPLint and the VIM mode plugins are missing from the list in the initial setup wizard. I looked threw the code but came to the conclusion that it's generated dynamically, but didn't really debug the issue. |
|
This means that you did not build wxWidgets properly. The I will run my guide on a clean setup, step by step to make sure I did not miss anything there. About the plugins missing in the wizard: I do see them... Just run "Help->Run the setup wizard" - and I can see them there |

Hi, I started working on some extensions for CodeLite, I have gotten it to a POC level, but I'm unsure of what direction to take from here, so hope a pull request is an okay way to request for comment an possibly a little help.
TODO: