Add option to use dark tab theme by default #1510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
I applied the patch locally and this look OK. Is it also possible to support the following notebooks:
|
Author
|
I just grabbed the evaluation version off of the website for Ubuntu 16.04; it looks like that puts me on version 2.6. In any case, I fixed the wxCrafter inconsistencies introduced earlier and updated |
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeLite's dark tab theme looks really good when used with other dark-themed UI elements, but there isn't currently a good way to configure CodeLite to use that theme (besides the match-editor-theme option, which only works for editor tabs). These changes add a new option to the settings dialog (Windows & Tabs > Docking > Use dark notebook tab theme by default) which allows the user to switch the tabs to the dark theme (when not overridden by the match-editor-theme option). This option is stored using what appears to be a previously unused options bit, and should have all of the logic in place for initializing and updating the color theme of all four of CodeLite's main notebooks.
I've never used wxCrafter before making this small change, and, since it looks like it clobbered pretty much all of the .wxcb file and the related #include guard, I'm worried that I might be doing something wrong or using the wrong version. I can fix those files manually if you want me to.
I'm also not sure if there's anything special that I need to do to get the new text that's added with this change to be localization-ready; if there is, I'll take care of that too.