Load environment variables of configuration being used. #1007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not of the configuration active in the workspace. Fixes: #993
eranif
added a commit
that referenced
this pull request
Nov 6, 2015
Load environment variables of configuration being used.
fixes: #993
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to fix #993 myself.
The problem is that in
EnvironmentConfig::ApplyEnvthe active environment variables where loaded, where active is the build configuration active in the workspace.In some cases (e.g. batch build from #993), the active build configuration is not the configuration active in the workspace.
I added a parameter to
ApplyEnvto indicate what build configuration to use.ApplyEnvis only used byEnvSetter, so I also added the parameter to the relevantEnvSetterconstructor.For all the usages of the
EnvSetterconstructor, I added the used build configuration, orwxEmptyStringwhen unknown.