Add a --fail flag to hard fail a la curl#95
Merged
Conversation
If --fail is set, an error in the otelcli handler will cause an exit with status one. (Defaul behavior remains exit with status 0.) This is intended for use cases like testing that an otlp endpoint is up and receiving traffic. Fixes equinix-labs#91.
Contributor
Author
tobert
approved these changes
Nov 17, 2021
tobert
left a comment
tobert
left a comment
Contributor
There was a problem hiding this comment.
I've been thinking about what to do here and this is perfect. Thank you!
Will need some tests for it but the code looks fine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a --fail flag to hard fail a la curl
If --fail is set, an error in the otelcli handler will cause an exit with status one. (Defaul behavior remains exit with status 0.)
This is intended for use cases like testing that an otlp endpoint is up
and receiving traffic.
Fixes #91.