fix exec end timestamp (#189)#195
Merged
Merged
Conversation
added 3 commits
May 8, 2023 19:29
The argument lists were getting ridiculous, so I shifted things around and made it so endpoint, span, and span events are passed as part of the fixture or results. Added first passes at tests for the endtime bug.
Will fix bug in next commit. This commit does a little more refactoring of the CheckFuncs in the test framework. Adds a broken test for the end time not being set on exec.
Reported in #189, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds test infrastructure for more detailed checks like this case needed. Adds a test that broke as reported, and then fixed the bug.