add http testing#143
Merged
Merged
Conversation
added 12 commits
January 27, 2023 12:20
Broke the surface otel-cli and main_test care about into an interface. Ported grpcserver and referents to the interface. Added skeleton http server. Tests pass :)
Added a simple http handler for testing. Not ready yet. Added plumbing so http protocol can be requested, but it's not used yet. Correct some types.
Broke the code that converts protobuf data to CliEvents out into its own function and moved it to clievent.go. Converted the gRPC server to use that. Added it to the HTTP server and it just worked the first time. Since proto is now imported directly, it go.mod changed to reflect that.
Added ServerMeta to the CliEvent struct as a string map that httpserver now plugs a bunch of metadata into. Added that to the test harness. Added metadata to the test so now path & proto are verified.
edw-eqix
previously approved these changes
Jan 27, 2023
edw-eqix
approved these changes
Jan 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors
otlpserverto an interface and adds a simple HTTP server that can receive and translate traces.This is step 1 to do #142 correctly, as I wish to test the heck out of endpoint and protocol combinations in the next couple PRs.