Skip to content

next.js: Compat with React 19 types #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eps1lon wants to merge 4 commits into from
Closed

next.js: Compat with React 19 types #1

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2ed7144
Install React 19 types
eps1lon Mar 21, 2024
3a9540c
Apply default `preset-19` to packages,test
eps1lon Mar 21, 2024
cd92cff
Resolve rest of breaking changes
eps1lon Mar 21, 2024
97fcba3
Resolve `ReactElement<unknown>` breaking changes
eps1lon Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Resolve ReactElement<unknown> breaking changes 
The codemod affected 15 files while we only had to change a single file.
Confirms that this codemod should really be off by default.
Cautionary advise against it should be stronger.
  • Loading branch information
@eps1lon
eps1lon committed Mar 21, 2024
commit 97fcba326ef465d134862feb1990f875d360675e
6 changes: 3 additions & 3 deletions packages/next/src/pages/_document.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ function getPolyfillScripts(context: HtmlProps, props: OriginProps) {
))
}

function hasComponentProps(child: any): child is React.ReactElement {
function hasComponentProps(child: any): child is React.ReactElement<any> {
return !!child && !!child.props
}

Expand All @@ -106,7 +106,7 @@ function AmpStyles({
if (!styles) return null

// try to parse styles from fragment for backwards compat
const curStyles: React.ReactElement[] = Array.isArray(styles)
const curStyles: React.ReactElement<any>[] = Array.isArray(styles)
? (styles as React.ReactElement[])
: []
if (
Expand All @@ -115,7 +115,7 @@ function AmpStyles({
// @ts-ignore Property 'props' does not exist on type ReactElement
Array.isArray(styles.props.children)
) {
const hasStyles = (el: React.ReactElement) =>
const hasStyles = (el: React.ReactElement<any>) =>
el?.props?.dangerouslySetInnerHTML?.__html
// @ts-ignore Property 'props' does not exist on type ReactElement
styles.props.children.forEach((child: React.ReactElement) => {
Expand Down