feat: v0.1.0 quality hardening — R1-R20#1
Merged
Conversation
Critical (R1-R3): - NoopSink public + prelude re-export - TelemetrySink Send + Sync bounds - mask_secrets regex-based full masking Performance (R4-R6): - cosine_similarity single-pass accumulation - classify_failure fast-path byte-prefix for error[EXXXX] - estimate_tokens match-based char_cpt replacing CPT_TABLE Stability (R7-R11): - related_nodes depth parameter applied to recursive CTE - wizard.rs 4 duplicate branches collapsed to single path - BearerAuth::generate xorshift limitations documented - embed_batch partial failure behavior documented - 4 ignored doc tests changed to no_run with compile-check Completeness (R12-R20): - JSON-RPC 2.0 batch request support - MCP resources/read dispatch - McpNotification enum + format_notification - strip_ansi for ANSI escape removal - FailureCategory FromStr implementation - tiktoken docstring reference removed - EmbeddingResult.dim field -> dim() method - TelemetryEvent enum-gated (ToolName, FeatureName, ProviderCategory) - Cargo.toml keywords/categories metadata
…_secrets all-occurrence - Add NoopSink to telemetry/mod.rs re-exports and prelude - Add Send + Sync supertraits to TelemetrySink - Fix mask_secrets infinite loop: track search_from position - mask_secrets now masks ALL occurrences of each pattern - Add standalone sk-* API key masking - Add 3 new tests: mask_multiple_passwords, mask_multiple_bearer, mask_standalone_sk_key
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
llm-kernel v0.1.0 Quality Hardening
라이브러리 성능/안정성/완성도 평가에서 식별된 20개 이슈 전부 개선.
Critical (R1-R3)
NoopSink공개 + prelude re-export (옵트아웃 경로 복구)TelemetrySink: Send + Syncsupertrait 추가mask_secrets모든 발생 마스킹 —Bearer,sk-*,password=,token=,key=,secret=Performance (R4-R6)
cosine_similarity단일 패스 accumulation (3-pass → 1-pass fold)classify_failureerror[EXXXX]byte-prefix fast path (regex 우회)estimate_tokensmatch-basedchar_cpt— CPT_TABLE linear scan 제거Stability (R7-R11)
related_nodesdepth 파라미터 CTE 실제 적용 (기존_depth무시)wizard.rs4개 동일 분기 단일 경로로 통합BearerAuth::generatexorshift 한계 Security Note 문서화embed_batch부분 실패 동작 문서화ignore독테스트 →no_run(컴파일 검증 활성화)Completeness (R12-R20)
resources/read디스패치 (set_resource_handler/read_resource)McpNotificationenum +format_notification(ToolsListChanged, ResourcesListChanged, Progress)strip_ansiANSI 이스케이프 제거 (ECMA-48 compliant)FailureCategoryFromStr구현 (roundtrip 검증)EmbeddingResult.dim필드 →dim()메서드TelemetryEventenum-gated (ToolName,FeatureName,ProviderCategory)Cargo.tomlkeywords/categories 메타데이터Verification
🤖 Generated with Claude Code