fix(evolve): from_db_str Unknown + edit_type test + token_estimate scaffold (#81)#95
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #81 — the 3 residual correctness/quality follow-ups from PR #75 that #77/#78/#79 did not address.
Changes
EditType::from_db_strno longer distorts unknown DB values intoAddSkill: addedEditType::Unknown, made"add_skill"explicit (the old wildcard caught it), and_ => Unknown.Unknownis excluded fromall()so it never pollutes edit-type coverage.edit_type_roundtripstest timestamp is now index-based (enumerate), notas_str().len()— structurally unique, survives a future UNIQUE constraint or new variant.token_estimate/estimate_tokensdocumented as intentional scaffold (not silently unused) — kept populated for future planner cost-weighting.Acceptance Criteria
from_db_str_unknown_is_not_distorted_to_add_skill+unknown_excluded_from_all(new tests).token_estimate/estimate_tokenscarry scaffold doc rationale; clippy clean.cargo test --lib651 passed; clippy clean; fmt clean.Test Plan