Feature/add support for negation operator#94
Merged
Saibo-creator merged 4 commits intoSep 19, 2024
Merged
Conversation
Collaborator
|
@nathanrchn Could you add a unit test for this feature in the P.S. If I didn’t mention it before, running |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the negation operator. It only supports negative ranges for now.
To do so, I proceeded as follows: for a given negative range [a, b], the allowed range is: [0, a - 1] U [b + 1, max_ord].
I set the max_ord to 0xFF but I think it's better to support unicode chars too. But if I set it to 0xFFFF, it will be the same value as the
END_OF_GRAMMAR_MARKERconstant. So maybe the best thing is to setEND_OF_GRAMMAR_MARKERto 0xFFFFF?