Add Support to Gemma2#75
Merged
Merged
Conversation
Collaborator
|
@fillassuncao Thank you for the awesome work ! 💯 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support to the
google/gemma2model.I've extended the code in some places to consider the Gemma tokenizer similar to the llama one. Also extended the supported tokenizers, and added a test for it, check the image bellow for the test report:
In addition, I have fixed a couple of issues in the requirements.txt, including the bump of the transformers version to the one where the
GemmaTokenizerFastwas first introduced.Note: the
google/gemma2models are gated, and therefore to run the tests you need to configure the hf token locally.