React hooks test case part 2 -- useMemo#2144
Merged
Merged
Conversation
ljharb
approved these changes
May 29, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #2011 .
Add
useMemotest cases in both shallow and mount test suites to make sure it works with enzyme. There are 2 tests for each:useMemoand pass it down to child. Then rerender the component by changing a prop which is not in the dependencies ofuseMemocall. So we can assert that the prop passed down will be the same (===) between two rendering. Note that the memoized value is an object in the test so we can make sure they are shallow equal.useMemo, so now the prop passed down will be different between two rendering.Any advice on additional tests is welcome :-)