hooks testcase written#2029
Merged
Merged
Conversation
Contributor
Author
pgangwani
suggested changes
Mar 6, 2019
There was a problem hiding this comment.
@k3ithl1m : Could you please add testcase to simulate wrapper.setProps() to get new initial state from props (simulate to test concepts : getDerivedStateFromProps or componentWillReceiveProps) passing initialFooVal
act(() => { wrapper.setProps({ initialFooVal: "HELLO" }); });
Contributor
Author
|
@pgangwani Sounds like a plan |
ljharb
requested changes
Mar 7, 2019
ljharb
left a comment
ljharb
left a comment
Member
There was a problem hiding this comment.
Thanks, this is a great start.
Contributor
Author
|
@pgangwani @ljharb I've added the component will receive props test case. Let me know if there are any other changes |
|
@k3ithl1m there is #2041 also open. Lets wait for it getting merged then I would work with you ( and whoever else intrested) to implement all remaining test cases specifically for react hooks. |
ljharb
force-pushed
the
master
branch
3 times, most recently
from
April 12, 2019 23:05
40cc703 to
0a17404
Compare
ljharb
approved these changes
Jun 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test cases written to test useState and useEffect