Skip to content

Updating repository paths in README under benchmarks.#609

Merged
mum4k merged 2 commits intoenvoyproxy:mainfrom
mum4k:benchmark-rename
Jan 26, 2021
Merged

Updating repository paths in README under benchmarks.#609
mum4k merged 2 commits intoenvoyproxy:mainfrom
mum4k:benchmark-rename

Conversation

@mum4k
Copy link
Copy Markdown
Collaborator

@mum4k mum4k commented Jan 25, 2021

Changing github repository paths from oschaaf to envoyproxy.

Signed-off-by: Jakub Sobon [email protected]

@mum4k
Updating README under benchmarks.
adb7190 
Changing github repository paths from oschaaf to envoyproxy.

Signed-off-by: Jakub Sobon <[email protected]>
@mum4k mum4k requested a review from oschaaf January 25, 2021 05:14
@mum4k mum4k added the waiting-for-review A PR waiting for a review. label Jan 25, 2021
@mum4k
Copy link
Copy Markdown
Collaborator Author

mum4k commented Jan 25, 2021

@oschaaf there is also a reference to oschaaf/benchmark-dev:latest in the same readme. Is that the correct path for us to use?

oschaaf
oschaaf approved these changes Jan 25, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@oschaaf oschaaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yeah, good idea.

@oschaaf oschaaf removed the waiting-for-review A PR waiting for a review. label Jan 25, 2021
@mum4k
Copy link
Copy Markdown
Collaborator Author

mum4k commented Jan 26, 2021

@oschaaf please see my question about the reference to oschaaf/benchmark-dev:latest in the same file.

@oschaaf
Copy link
Copy Markdown
Member

oschaaf commented Jan 26, 2021

@oschaaf there is also a reference to oschaaf/benchmark-dev:latest in the same readme. Is that the correct path for us to use?

Oh, sorry I missed that. I think that for the time being it's the best option, because we don't push the image in CI to a proper location. There's https://hub.docker.com/r/envoyproxy/nighthawk-dev, maybe we should try to also obtain https://hub.docker.com/r/envoyproxy/nighthawk-benchmark-dev (or some such) as a location to push to.

@oschaaf oschaaf mentioned this pull request Jan 26, 2021
Closed
@oschaaf
Copy link
Copy Markdown
Member

oschaaf commented Jan 26, 2021

(Filed #611 to track)

@mum4k
Copy link
Copy Markdown
Collaborator Author

mum4k commented Jan 26, 2021

Thank you @oschaaf!

@mum4k mum4k merged commit 9ade1a5 into envoyproxy:main Jan 26, 2021
@mum4k mum4k deleted the benchmark-rename branch January 26, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@oschaaf oschaaf oschaaf approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mum4k @oschaaf