Skip to content

Commit 7ff2dd2

Browse files
committed
Review: fix nits
Signed-off-by: Otto van der Schaaf <[email protected]>
1 parent f5e0521 commit 7ff2dd2

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

CONTRIBUTING.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,12 +22,12 @@ Both API and implementation stability are important to Nighthawk. Since the API
2222

2323
# PR review policy for maintainers
2424

25-
* Generally Nighthawk mirros [Envoy's policy](https://github.com/envoyproxy/envoy/blob/master/CONTRIBUTING.md#pr-review-policy-for-maintainers) with respect to maintainer review policy.
25+
* Generally Nighthawk mirrors [Envoy's policy](https://github.com/envoyproxy/envoy/blob/master/CONTRIBUTING.md#pr-review-policy-for-maintainers) with respect to maintainer review policy.
2626
* See [OWNERS.md](OWNERS.md) for the current list of maintainers.
2727

2828
# DCO: Sign your work
2929

30-
Commits need to be signed off. [See here](https://github.com/envoyproxy/envoy/blob/master/CONTRIBUTING.md#dco-sign-your-work).
30+
Commits need to be signed off. See [here](https://github.com/envoyproxy/envoy/blob/master/CONTRIBUTING.md#dco-sign-your-work).
3131

3232

3333
## Triggering CI re-run without making changes

MAINTAINERS.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ This document aims to assist [maintainers](OWNERS.md).
66

77
As a guideline, concepts in Nighthawk that are derived from Envoy
88
require someone with Envoy domain expertise in review. Notable examples
9-
are the way Nighthawk internal computes cluster configuration, its
9+
are the way Nighthawk internally computes cluster configuration, its
1010
connection pool derivations, the `StreamDecoder` class, as well as anything related to the Nighthawk test server.
1111

1212
See [OWNERS.md](OWNERS.md) to find maintainers with expertise of
@@ -16,7 +16,7 @@ Envoy internals.
1616

1717
- Does the PR have breaking changes? Then that should be explicitly mentioned in the [version history](docs/root/version_history.md).
1818
- New features should be added to the [version history](docs/root/version_history.md).
19-
- Breaking changes to the [proto apis](api/) are not allowed.
19+
- Breaking changes to the [protobuf APIs](api/) are not allowed.
2020

2121
## Updates to the Envoy dependency
2222

0 commit comments

Comments
 (0)