Review feedback

oschaaf · oschaaf · commit 6f235976d261 · 2019-12-11T22:04:42.000+01:00
Signed-off-by: Otto van der Schaaf &lt;oschaaf@we-amp.com&gt;
diff --git a/RELEASE_PROCEDURE.md b/RELEASE_PROCEDURE.md
@@ -3,5 +3,9 @@
 - Update [version_history.md](docs/root/version_history.md). 
   - Make sure breaking changes are explicitly called out.
   - Ensure the release notes are complete.
-- Tag the release in git using the current version number
+- Tag the release in git using the current version number:
+```bash
+git tag -a "v0.3" -m "Release v0.3"
+git push origin v0.3
+```
 - Bump `MAJOR_VERSION` / `MINOR_VERSION` in [version.h](include/nighthawk/common/version.h) to the next version.
diff --git a/include/nighthawk/common/version.h b/include/nighthawk/common/version.h
@@ -7,7 +7,7 @@ namespace Nighthawk {
 const int MAJOR_VERSION{0};
 const int MINOR_VERSION{3};
 
-class Globals {
+class VersionUtils {
 public:
   static std::string VersionString() { return absl::StrCat(MAJOR_VERSION, ".", MINOR_VERSION); }
 };
diff --git a/source/client/options_impl.cc b/source/client/options_impl.cc
@@ -31,7 +31,7 @@ OptionsImpl::OptionsImpl(int argc, const char* const* argv) {
   // TODO(oschaaf): Purge the validation we perform here. Most of it should have become
   // redundant now that we also perform validation of the resulting proto.
   const char* descr = "L7 (HTTP/HTTPS/HTTP2) performance characterization tool.";
-  TCLAP::CmdLine cmd(descr, ' ', Globals::VersionString()); // NOLINT
+  TCLAP::CmdLine cmd(descr, ' ', VersionUtils::VersionString()); // NOLINT
 
   // Any default values we pass into TCLAP argument declarations are arbitrary, as we do not rely on
   // TCLAP for providing default values. Default values are declared in and sourced from
diff --git a/source/client/output_transform_main.cc b/source/client/output_transform_main.cc
@@ -24,7 +24,7 @@ namespace Client {
 OutputTransformMain::OutputTransformMain(int argc, const char* const* argv, std::istream& input)
     : input_(input) {
   const char* descr = "L7 (HTTP/HTTPS/HTTP2) performance characterization transformation tool.";
-  TCLAP::CmdLine cmd(descr, ' ', Globals::VersionString()); // NOLINT
+  TCLAP::CmdLine cmd(descr, ' ', VersionUtils::VersionString()); // NOLINT
   std::vector<std::string> output_formats = OutputFormatterImpl::getLowerCaseOutputFormats();
   TCLAP::ValuesConstraint<std::string> output_formats_allowed(output_formats);
   TCLAP::ValueArg<std::string> output_format(
diff --git a/source/client/service_main.cc b/source/client/service_main.cc
@@ -15,7 +15,7 @@ namespace Client {
 
 ServiceMain::ServiceMain(int argc, const char** argv) {
   const char* descr = "L7 (HTTP/HTTPS/HTTP2) performance characterization tool.";
-  TCLAP::CmdLine cmd(descr, ' ', Globals::VersionString()); // NOLINT
+  TCLAP::CmdLine cmd(descr, ' ', VersionUtils::VersionString()); // NOLINT
 
   TCLAP::ValueArg<std::string> listen_arg(
       "", "listen",
