Review feedback

oschaaf · oschaaf · commit 2529ea6826f3 · 2020-10-06T08:57:43.000+02:00
Signed-off-by: Otto van der Schaaf &lt;oschaaf@we-amp.com&gt;
diff --git a/source/server/http_test_server_filter.cc b/source/server/http_test_server_filter.cc
@@ -41,7 +41,8 @@ HttpTestServerDecoderFilter::decodeHeaders(Envoy::Http::RequestHeaderMap& header
   config_->computeEffectiveConfiguration(headers);
   if (end_stream) {
     if (!config_->maybeSendErrorReply(*decoder_callbacks_)) {
-      const auto effective_config = config_->getEffectiveConfiguration();
+      const absl::StatusOr<EffectiveFilterConfigurationPtr> effective_config =
+          config_->getEffectiveConfiguration();
       if (effective_config.value()->echo_request_headers()) {
         std::stringstream headers_dump;
         headers_dump << "\nRequest Headers:\n" << headers;
diff --git a/source/server/http_time_tracking_filter.cc b/source/server/http_time_tracking_filter.cc
@@ -47,7 +47,8 @@ Envoy::Http::FilterDataStatus HttpTimeTrackingFilter::decodeData(Envoy::Buffer::
 
 Envoy::Http::FilterHeadersStatus
 HttpTimeTrackingFilter::encodeHeaders(Envoy::Http::ResponseHeaderMap& response_headers, bool) {
-  const auto effective_config = config_->getEffectiveConfiguration();
+  const absl::StatusOr<EffectiveFilterConfigurationPtr> effective_config =
+      config_->getEffectiveConfiguration();
   if (effective_config.ok()) {
     const std::string previous_request_delta_in_response_header =
         effective_config.value()->emit_previous_request_delta_in_response_header();
diff --git a/test/server/http_test_server_filter_integration_test.cc b/test/server/http_test_server_filter_integration_test.cc
@@ -9,10 +9,11 @@
 #include "gtest/gtest.h"
 
 namespace Nighthawk {
+namespace {
 
 using namespace testing;
 
-const std::string kDefaultProto = R"EOF(
+constexpr absl::string_view kDefaultProto = R"EOF(
 name: test-server
 typed_config:
   "@type": type.googleapis.com/nighthawk.server.ResponseOptions
@@ -21,7 +22,7 @@ name: test-server
   - { header: { key: "x-supplied-by", value: "nighthawk-test-server"} }
 )EOF";
 
-const std::string kNoConfigProto = R"EOF(
+constexpr absl::string_view kNoConfigProto = R"EOF(
 name: test-server
 )EOF";
 
@@ -248,4 +249,5 @@ TEST(HttpTestServerDecoderFilterTest, HeaderMerge) {
   EXPECT_EQ(3, options.response_headers_size());
 }
 
+} // namespace
 } // namespace Nighthawk
