Skip to content

Commit 0711c15

Browse files
oschaafoschaaf
committed
Review feedback: better target tests
Signed-off-by: Otto van der Schaaf <[email protected]>
1 parent fac1a1c commit 0711c15

File tree

6 files changed

+34
-1148
lines changed

6 files changed

+34
-1148
lines changed

‎test/BUILD‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -99,14 +99,14 @@ envoy_cc_test(
9999
name = "output_formatter_test",
100100
srcs = ["output_formatter_test.cc"],
101101
data = [
102-
"test_data/large-sample.json",
103102
"test_data/output_formatter.dotted.gold",
104103
"test_data/output_formatter.json.gold",
105-
"test_data/output_formatter.large.txt.gold",
106104
"test_data/output_formatter.medium.fortio.gold",
107105
"test_data/output_formatter.medium.proto.gold",
108106
"test_data/output_formatter.txt.gold",
109107
"test_data/output_formatter.yaml.gold",
108+
"test_data/percentile-column-overflow.json",
109+
"test_data/percentile-column-overflow.txt.gold",
110110
],
111111
repository = "@envoy",
112112
deps = [

‎test/output_formatter_test.cc‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -193,10 +193,10 @@ TEST_F(MediumOutputCollectorTest, FortioFormatter) {
193193
}
194194

195195
TEST_F(MediumOutputCollectorTest, ConsoleOutputFormatter) {
196-
const auto input_proto = loadProtoFromFile("test/test_data/large-sample.json");
196+
const auto input_proto = loadProtoFromFile("test/test_data/percentile-column-overflow.json");
197197
ConsoleOutputFormatterImpl formatter;
198198
expectEqualToGoldFile(formatter.formatProto(input_proto),
199-
"test/test_data/output_formatter.large.txt.gold");
199+
"test/test_data/percentile-column-overflow.txt.gold");
200200
}
201201

202202
class StatidToNameTest : public Test {};

0 commit comments

Comments
 (0)