Merged
Conversation
Needed to be compatible with internal build rules. Signed-off-by: Teju Nareddy <[email protected]>
kyessenov
approved these changes
Sep 6, 2019
Contributor
kyessenov
left a comment
kyessenov
left a comment
There was a problem hiding this comment.
Thanks.
For context: Google internal tooling separates go and grpc packages so this double import allows automatic rewrites.
kyessenov
pushed a commit
that referenced
this pull request
Sep 9, 2019
Needed to be compatible with internal build rules. Signed-off-by: Teju Nareddy <[email protected]> Signed-off-by: Kuat Yessenov <[email protected]>
kyessenov
pushed a commit
that referenced
this pull request
Sep 9, 2019
Needed to be compatible with internal build rules. Signed-off-by: Teju Nareddy <[email protected]> Signed-off-by: Kuat Yessenov <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed to be compatible with internal build rules.
So separate out grpc service imports from regular proto imports.
Signed-off-by: Teju Nareddy [email protected]