Add status in HTTPRoute when Ratelimit is disabled by arkodg · Pull Request #982 · envoyproxy/gateway

arkodg · 2023-02-04T02:32:52Z

Signed-off-by: Arko Dasgupta [email protected]

Signed-off-by: Arko Dasgupta <[email protected]>

arkodg · 2023-02-04T02:33:17Z

apiVersion: v1
items:
- apiVersion: gateway.networking.k8s.io/v1beta1
  kind: HTTPRoute
  metadata:
    annotations:
      kubectl.kubernetes.io/last-applied-configuration: |
        {"apiVersion":"gateway.networking.k8s.io/v1beta1","kind":"HTTPRoute","metadata":{"annotations":{},"name":"backend","namespace":"default"},"spec":{"hostnames":["www.example.com"],"parentRefs":[{"name":"eg"}],"rules":[{"backendRefs":[{"group":"","kind":"Service","name":"backend","port":3000,"weight":1}],"filters":[{"extensionRef":{"group":"gateway.envoyproxy.io","kind":"RateLimitFilter","name":"ratelimit-specific-user"},"type":"ExtensionRef"}],"matches":[{"path":{"type":"PathPrefix","value":"/"}}]}]}}
    creationTimestamp: "2023-02-04T02:23:14Z"
    generation: 2
    name: backend
    namespace: default
    resourceVersion: "1049"
    uid: eaa7aa0f-518b-47fc-b71c-a5f80dbb30ca
  spec:
    hostnames:
    - www.example.com
    parentRefs:
    - group: gateway.networking.k8s.io
      kind: Gateway
      name: eg
    rules:
    - backendRefs:
      - group: ""
        kind: Service
        name: backend
        port: 3000
        weight: 1
      filters:
      - extensionRef:
          group: gateway.envoyproxy.io
          kind: RateLimitFilter
          name: ratelimit-specific-user
        type: ExtensionRef
      matches:
      - path:
          type: PathPrefix
          value: /
  status:
    parents:
    - conditions:
      - lastTransitionTime: "2023-02-04T02:31:22Z"
        message: 'Enable Ratelimit in the EnvoyGateway config to configure RateLimitFilter:
          default/ratelimit-specific-user'
        observedGeneration: 2
        reason: UnsupportedValue
        status: "False"
        type: Accepted
      - lastTransitionTime: "2023-02-04T02:31:22Z"
        message: 'Enable Ratelimit in the EnvoyGateway config to configure RateLimitFilter:
          default/ratelimit-specific-user'
        observedGeneration: 2
        reason: BackendNotFound
        status: "False"
        type: ResolvedRefs
      controllerName: gateway.envoyproxy.io/gatewayclass-controller
      parentRef:
        group: gateway.networking.k8s.io
        kind: Gateway
        name: eg
kind: List
metadata:
  resourceVersion: ""

Signed-off-by: Arko Dasgupta <[email protected]>

codecov-commenter · 2023-02-04T02:53:30Z

Codecov Report

Merging #982 (cc1a685) into main (82e7672) will decrease coverage by 0.09%.
The diff coverage is 0.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #982      +/-   ##
==========================================
- Coverage   62.24%   62.16%   -0.09%     
==========================================
  Files          55       55              
  Lines        8778     8785       +7     
==========================================
- Hits         5464     5461       -3     
- Misses       2946     2955       +9     
- Partials      368      369       +1

Impacted Files	Coverage Δ
internal/gatewayapi/filters.go	`79.57% <0.00%> (-0.79%)`	⬇️
internal/gatewayapi/runner/runner.go	`28.26% <0.00%> (-0.32%)`	⬇️
internal/gatewayapi/translator.go	`97.10% <ø> (ø)`
internal/provider/kubernetes/helpers.go	`83.10% <0.00%> (-2.03%)`	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

* Add status in HTTPRoute when Ratelimit is disabled Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit ebb902b) Signed-off-by: Arko Dasgupta <[email protected]>

* Add status in HTTPRoute when Ratelimit is disabled Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit ebb902b) Signed-off-by: bitliu <[email protected]>

* fix: incorrect command in release schedule (#973) * chore: rename release-notes v0.3.0-rc1.yaml to v0.3.0-rc.1.yaml Signed-off-by: bitliu <[email protected]> * fix: incorrect command in release schedule Signed-off-by: bitliu <[email protected]> --------- Signed-off-by: bitliu <[email protected]> (cherry picked from commit 7639637) Signed-off-by: bitliu <[email protected]> * xds: Deprecated http2_protocol_options (#974) * xds: Deprecated http2_protocol_options Signed-off-by: hejianpeng <[email protected]> (cherry picked from commit 4a04915) Signed-off-by: bitliu <[email protected]> * Use HTTP1.1 to connect to upstream jwks endpoint (#977) Use HTTP1.1 to connec to upstream jwks endpoint Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit 82e7672) Signed-off-by: bitliu <[email protected]> * Add status in HTTPRoute when Ratelimit is disabled (#982) * Add status in HTTPRoute when Ratelimit is disabled Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit ebb902b) Signed-off-by: bitliu <[email protected]> * build(deps): bump actions/deploy-pages from 1.2.3 to 1.2.4 (#984) Bumps [actions/deploy-pages](https://github.com/actions/deploy-pages) from 1.2.3 to 1.2.4. - [Release notes](https://github.com/actions/deploy-pages/releases) - [Commits](actions/deploy-pages@v1.2.3...v1.2.4) --- updated-dependencies: - dependency-name: actions/deploy-pages dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit 1bea44e) Signed-off-by: bitliu <[email protected]> * build(deps): bump sigs.k8s.io/controller-runtime from 0.14.2 to 0.14.4 (#985) Bumps [sigs.k8s.io/controller-runtime](https://github.com/kubernetes-sigs/controller-runtime) from 0.14.2 to 0.14.4. - [Release notes](https://github.com/kubernetes-sigs/controller-runtime/releases) - [Changelog](https://github.com/kubernetes-sigs/controller-runtime/blob/master/RELEASE.md) - [Commits](kubernetes-sigs/controller-runtime@v0.14.2...v0.14.4) --- updated-dependencies: - dependency-name: sigs.k8s.io/controller-runtime dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> (cherry picked from commit fadc142) Signed-off-by: bitliu <[email protected]> * fix function names for RL Infra (#976) The create and delete function names were incorrectly swapped. Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit 265c419) Signed-off-by: bitliu <[email protected]> * Add docs for GRPCRoute (#969) * Add docs for GRPCRoute Fixes: #642 Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit 3516d10) Signed-off-by: bitliu <[email protected]> * align wellknown package (#981) Signed-off-by: hejianpeng <[email protected]> (cherry picked from commit eec43d2) Signed-off-by: bitliu <[email protected]> * Plug in rate limit service URL into xds cluster (#983) * Plug in rate limit service URL into xds cluster Signed-off-by: Arko Dasgupta <[email protected]> * more guardrails Signed-off-by: Arko Dasgupta <[email protected]> * set to grpcPort and pin image Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit 1b26380) Signed-off-by: bitliu <[email protected]> * Adds JWT Authn User Docs (#991) Signed-off-by: danehans <[email protected]> (cherry picked from commit 2a431c1) Signed-off-by: bitliu <[email protected]> * user docs for global rate limit (#989) * user docs for global rate limit Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit ab47d2e) Signed-off-by: bitliu <[email protected]> * docs: add ref to global ratelimit (#999) Signed-off-by: bitliu <[email protected]> (cherry picked from commit 5115330) Signed-off-by: bitliu <[email protected]> * Update gateway-api to v0.6.1 (#1003) https://github.com/kubernetes-sigs/gateway-api/releases/tag/v0.6.1 Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit d01daec) Signed-off-by: bitliu <[email protected]> * Add GRPCRoute to SupportedKinds (#990) Fixes: #950 Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit beb6eae) Signed-off-by: bitliu <[email protected]> * Use `path_separated_prefix` Route match (#1004) * Use `path_separated_prefix` Route match We were using `prefix` Route match in xds for the `PathPrefix` Gateway API match defined here https://gateway-api.sigs.k8s.io/references/spec/#gateway.networking.k8s.io/v1beta1.HTTPPathMatch The match translates to a `path_separated_prefix` instead https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/route/v3/route_components.proto#config-route-v3-routematch This should fix the `HTTPRouteMatching` conformance test where requests with `/v2example` should match `/` and not `/v2` Fixes: #995 Signed-off-by: Arko Dasgupta <[email protected]> * rewrite empty match case Signed-off-by: Arko Dasgupta <[email protected]> * use prefix match for `/` Signed-off-by: Arko Dasgupta <[email protected]> --------- Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit c26d894) Signed-off-by: bitliu <[email protected]> * Adds API Docs Tooling (#980) Signed-off-by: danehans <[email protected]> (cherry picked from commit d5a5b25) Signed-off-by: bitliu <[email protected]> * Updates API godocs for improved markdown rendering (#1010) Updates API godocs for improved html rendering Signed-off-by: danehans <[email protected]> (cherry picked from commit b43574a) Signed-off-by: bitliu <[email protected]> * chore: bump testdata to gwapi v0.6.1 (#1011) Signed-off-by: bitliu <[email protected]> (cherry picked from commit f39b025) Signed-off-by: bitliu <[email protected]> * conformance: enable GatewayClassObservedGenerationBump (#896) Signed-off-by: bitliu <[email protected]> (cherry picked from commit b668002) Signed-off-by: bitliu <[email protected]> * Run all conformance tests except redirect tests (#1014) Redirect tests are failing due to a possible issue with the way upstream conformance tests have made assumptions Skipping them for now until below issues are resolved #992 #993 #994 Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit 38a6ddd) Signed-off-by: bitliu <[email protected]> * remove empty route error check in auth xds logic (#1019) the Xds translator should not error out when the IR routes are empty Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit 821b7d5) Signed-off-by: bitliu <[email protected]> * Removes GatewayObservedGenerationBump and HTTPRouteObservedGenerationBump Tests (#1021) (cherry picked from commit d016a66) Signed-off-by: bitliu <[email protected]> * Add Gateway API support doc (#1017) add gatewayapi support doc Signed-off-by: AliceProxy <[email protected]> (cherry picked from commit a33e627) Signed-off-by: bitliu <[email protected]> * Adds Cherry-Pick Steps to Release Doc (#1018) Signed-off-by: danehans <[email protected]> (cherry picked from commit 3d8120e) Signed-off-by: bitliu <[email protected]> * update to validate 1.26 (#1020) * update to validate 1.26 Signed-off-by: Held, Jarad <[email protected]> * correct the tag for kubernetes version for comformance tests Signed-off-by: Held, Jarad <[email protected]> --------- Signed-off-by: Held, Jarad <[email protected]> (cherry picked from commit 6bf8617) Signed-off-by: bitliu <[email protected]> * Bumps Compatibility Matrix for v0.3 (#1002) Signed-off-by: danehans <[email protected]> (cherry picked from commit d7a2e19) Signed-off-by: bitliu <[email protected]> * update gateway api support doc (#1022) * add note about not supported `filters` for `HTTPBackendRef` * rm `extensionRef` support for `GRPCRoute` * move the link under docs/latest Signed-off-by: Arko Dasgupta <[email protected]> (cherry picked from commit 9991359) Signed-off-by: bitliu <[email protected]> * release(v0.3.0): add release notes and release announcement (#1013) * release(v0.3.0): add release notes and release announcement Signed-off-by: bitliu <[email protected]> * update Signed-off-by: bitliu <[email protected]> --------- Signed-off-by: bitliu <[email protected]> (cherry picked from commit e55c15f) Signed-off-by: bitliu <[email protected]> * release: cut v0.3.0 versioned docs (#1025) Signed-off-by: bitliu <[email protected]> (cherry picked from commit 5b316b4) Signed-off-by: bitliu <[email protected]> --------- Signed-off-by: bitliu <[email protected]> Signed-off-by: hejianpeng <[email protected]> Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: danehans <[email protected]> Signed-off-by: AliceProxy <[email protected]> Signed-off-by: Held, Jarad <[email protected]> Co-authored-by: zirain <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Daneyon Hansen <[email protected]> Co-authored-by: Alice Wasko <[email protected]> Co-authored-by: Jarad <[email protected]>

Add status in HTTPRoute when Ratelimit is disabled

dcf16d6

Signed-off-by: Arko Dasgupta <[email protected]>

arkodg requested a review from a team as a code owner February 4, 2023 02:32

fix test

cc1a685

Signed-off-by: Arko Dasgupta <[email protected]>

zirain approved these changes Feb 4, 2023

View reviewed changes

arkodg merged commit ebb902b into envoyproxy:main Feb 4, 2023

arkodg deleted the rl-status-disabled branch February 4, 2023 21:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add status in HTTPRoute when Ratelimit is disabled#982

Add status in HTTPRoute when Ratelimit is disabled#982
arkodg merged 2 commits intoenvoyproxy:mainfrom
arkodg:rl-status-disabled

arkodg commented Feb 4, 2023

Uh oh!

arkodg commented Feb 4, 2023

Uh oh!

codecov-commenter commented Feb 4, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

arkodg commented Feb 4, 2023

Uh oh!

arkodg commented Feb 4, 2023

Uh oh!

codecov-commenter commented Feb 4, 2023

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants