RateLimitFilter: Gateway API to Xds IR translaton#933
Merged
arkodg merged 2 commits intoenvoyproxy:mainfrom Jan 24, 2023
Merged
RateLimitFilter: Gateway API to Xds IR translaton#933arkodg merged 2 commits intoenvoyproxy:mainfrom
arkodg merged 2 commits intoenvoyproxy:mainfrom
Conversation
* Also rm'ed `ResetConditon` and instead set `Accepted=False` for negative cases for ExtensionFilter cases Relates to envoyproxy#670 Signed-off-by: Arko Dasgupta <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #933 +/- ##
==========================================
- Coverage 64.33% 64.29% -0.05%
==========================================
Files 54 54
Lines 7691 7743 +52
==========================================
+ Hits 4948 4978 +30
- Misses 2431 2451 +20
- Partials 312 314 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Arko Dasgupta <[email protected]>
danehans
approved these changes
Jan 24, 2023
internal/gatewayapi/testdata/httproute-with-invalid-ratelimitfilter.out.yaml
Show resolved
Hide resolved
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ResetConditonand instead setAccepted=Falsefor negative cases for ExtensionFilter casesRelates to #670
Signed-off-by: Arko Dasgupta [email protected]