fix(egctl): correct user-facing grammar in help text#9217
Merged
Conversation
Signed-off-by: immanuwell <[email protected]>
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #9217 +/- ##
==========================================
- Coverage 74.89% 74.89% -0.01%
==========================================
Files 252 252
Lines 40799 40799
==========================================
- Hits 30558 30556 -2
- Misses 8158 8159 +1
- Partials 2083 2084 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
zirain
approved these changes
Jun 12, 2026
Member
|
/retest |
kkk777-7
approved these changes
Jun 13, 2026
cleman95
pushed a commit
to cleman95/gateway
that referenced
this pull request
Jun 25, 2026
Signed-off-by: immanuwell <[email protected]>
zac-nixon
pushed a commit
to zac-nixon/gateway
that referenced
this pull request
Jun 29, 2026
Signed-off-by: immanuwell <[email protected]>
guydc
pushed a commit
to guydc/gateway
that referenced
this pull request
Jun 30, 2026
Signed-off-by: immanuwell <[email protected]>
cnvergence
pushed a commit
to cnvergence/gateway
that referenced
this pull request
Jul 7, 2026
Signed-off-by: immanuwell <[email protected]> (cherry picked from commit ef1d118) Signed-off-by: Immanuel Tikhonov <[email protected]>
cnvergence
added a commit
that referenced
this pull request
Jul 7, 2026
* fix(validation): allow IPv6 to be specific in loadBalancerSourceRanges (#9050) * fix(validation): allow IPv6 to be specific in loadBalancerSourceRanges and loadBalancerIP Signed-off-by: Marc 'risson' Schmitt <[email protected]> (cherry picked from commit 3c1d7b9) * fix: allow Backend TLS to disable ALPN with an empty list (#9162) * Fixed Backend TLS to disable upstream ALPN instead of inheriting EnvoyProxy BackendTLS defaults. Signed-off-by: Huabing Zhao <[email protected]> * add test case for envoyproxy without tls Signed-off-by: Huabing Zhao <[email protected]> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <[email protected]> Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comments Signed-off-by: Huabing Zhao <[email protected]> --------- Signed-off-by: Huabing Zhao <[email protected]> Signed-off-by: Huabing (Robin) Zhao <[email protected]> Co-authored-by: Copilot Autofix powered by AI <[email protected]> (cherry picked from commit 21eb101) * fix(gatewayapi): sort api key auth credentials (#9042) * fix(gatewayapi): sort api key auth credentials Signed-off-by: Alexej Disterhoft <[email protected]> * docs(release-notes): add api key auth fix note Signed-off-by: Alexej Disterhoft <[email protected]> --------- Signed-off-by: Alexej Disterhoft <[email protected]> Signed-off-by: Alexej Disterhoft <[email protected]> Signed-off-by: zirain <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]> Co-authored-by: zirain <[email protected]> (cherry picked from commit b96a2d3) * fix(egctl): correct user-facing grammar in help text (#9217) Signed-off-by: immanuwell <[email protected]> (cherry picked from commit ef1d118) Signed-off-by: Immanuel Tikhonov <[email protected]> * fix: reject ExternalName Service as a route backend (#9190) fix: reject Service as a route backend Signed-off-by: Huabing Zhao <[email protected]> Signed-off-by: Huabing (Robin) Zhao <[email protected]> (cherry picked from commit ee16b3f) * fix(status): fall back to service externalIPs for Gateway addresses (#9209) When the Envoy service is of type LoadBalancer but no load balancer controller assigns an ingress address (e.g. bare-metal clusters), the Gateway status had no addresses and stayed Programmed=False with reason AddressNotAssigned, even when reachable addresses were configured via spec.externalIPs (e.g. through an EnvoyProxy service patch). Use spec.externalIPs as a fallback when the load balancer ingress list is empty. Ingress addresses keep priority when present, so behavior is unchanged for clusters with a working load balancer controller. Fixes #8987 Signed-off-by: Jules Dutel <[email protected]> (cherry picked from commit f2c0921) Signed-off-by: jvlxz <[email protected]> * fix: correct the config hot reload validation order (#9214) Co-authored-by: Nimisha Mehta <[email protected]> (cherry picked from commit 7e4492d) Signed-off-by: Mengjia Liang <[email protected]> * fix: panic with empty deploy (#9365) Signed-off-by: zirain <[email protected]> (cherry picked from commit 42a0c2c) * fix: DaemonSet pod not using the configured custom ServiceAccount name (#9347) * add test case Signed-off-by: zirain <[email protected]> * fix daemonset pod serviceaccount name Signed-off-by: zirain <[email protected]> * release notes Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> (cherry picked from commit 59a0cab) * fix: use int64 format for ratelimit Requests field (#9377) Signed-off-by: jukie <[email protected]> (cherry picked from commit 6916245) Signed-off-by: Isaac Wilson <[email protected]> * [release/v1.7] bump envoy to 1.37.5 and ratelimit to f2fb1577 Signed-off-by: Karol Szwaj <[email protected]> * [release/v1.7] add release notes for v1.7.5 Signed-off-by: Karol Szwaj <[email protected]> * fix gen Signed-off-by: Karol Szwaj <[email protected]> * fix rn Signed-off-by: Karol Szwaj <[email protected]> --------- Signed-off-by: Marc 'risson' Schmitt <[email protected]> Signed-off-by: Huabing Zhao <[email protected]> Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Alexej Disterhoft <[email protected]> Signed-off-by: Alexej Disterhoft <[email protected]> Signed-off-by: zirain <[email protected]> Signed-off-by: immanuwell <[email protected]> Signed-off-by: Immanuel Tikhonov <[email protected]> Signed-off-by: Jules Dutel <[email protected]> Signed-off-by: jvlxz <[email protected]> Signed-off-by: Mengjia Liang <[email protected]> Signed-off-by: jukie <[email protected]> Signed-off-by: Isaac Wilson <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> Co-authored-by: Marc 'risson' Schmitt <[email protected]> Co-authored-by: Huabing (Robin) Zhao <[email protected]> Co-authored-by: Copilot Autofix powered by AI <[email protected]> Co-authored-by: Alexej Disterhoft <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]> Co-authored-by: zirain <[email protected]> Co-authored-by: Immanuel Tikhonov <[email protected]> Co-authored-by: jvlxz <[email protected]> Co-authored-by: Mengjia Liang <[email protected]> Co-authored-by: Nimisha Mehta <[email protected]> Co-authored-by: Isaac Wilson <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix
What this PR does / why we need it:
Fixes 3 user-facing
egctltypos in help and error text.Small papercut, but its on the normal CLI path so people hit it pretty fast.
Which issue(s) this PR fixes:
N/A
Release Notes: No
Repro:
main, rungo run ./cmd/egctl config envoy-ratelimit --help.go run ./cmd/egctl experimental status --help.Specific a namespace....git show origin/main:internal/cmd/egctl/status.go | rg "must specific|Specific a namespace"