[release-1.8] bump envoy to 1.38.1#9168
Conversation
Signed-off-by: zirain <[email protected]>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3bfdc89e42
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| DefaultDeploymentMemoryResourceRequests = "512Mi" | ||
| // DefaultEnvoyProxyImage is the default image used by envoyproxy | ||
| DefaultEnvoyProxyImage = "docker.io/envoyproxy/envoy:distroless-v1.38.0" | ||
| DefaultEnvoyProxyImage = "docker.io/envoyproxy/envoy:distroless-v1.38.1" |
There was a problem hiding this comment.
When Helm users set global.images.envoyProxy.image without an explicit tag (for example to use a private registry/repository while relying on the chart's default tag), the chart still falls back to distroless-v1.38.0 in charts/gateway-helm/templates/_helpers.tpl:171. That path renders into the EnvoyGateway ConfigMap via eg.default-envoy-gateway-config, so those installs keep deploying the old Envoy image despite this default being bumped for the controller-generated resources; please update the Helm fallback tag to distroless-v1.38.1 as well.
Useful? React with 👍 / 👎.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/v1.8 #9168 +/- ##
================================================
- Coverage 74.81% 74.81% -0.01%
================================================
Files 251 251
Lines 40417 40417
================================================
- Hits 30239 30236 -3
- Misses 8111 8113 +2
- Partials 2067 2068 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Signed-off-by: zirain <[email protected]>
3 participants
xref: GHSA-22m2-hvr2-xqc8