fix rate limit validation on K8s 1.36#9166
Merged
Merged
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #9166 +/- ##
==========================================
- Coverage 74.81% 74.80% -0.01%
==========================================
Files 251 252 +1
Lines 40417 40756 +339
==========================================
+ Hits 30236 30489 +253
- Misses 8114 8185 +71
- Partials 2067 2082 +15 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
zirain
reviewed
Jun 4, 2026
Starting with K8s 1.36 the int range and maximum are validated against each other, which breaks the BTP tests. This can be fixed validating the field as uint32. Signed-off-by: Clemens Beck <[email protected]>
e1f4129 to
160aabe
Compare
zirain
approved these changes
Jun 4, 2026
jukie
approved these changes
Jun 4, 2026
Member
|
Add this to 1.8.2, in case some users want to run 1.8 with kubernetes 1.36. |
cleman95
pushed a commit
to cleman95/gateway
that referenced
this pull request
Jun 25, 2026
fixi: rate limit validation on K8s 1.36 Starting with K8s 1.36 the int range and maximum are validated against each other, which breaks the BTP tests. This can be fixed validating the field as uint32. Signed-off-by: Clemens Beck <[email protected]> Co-authored-by: Clemens Beck <[email protected]>
This was referenced Jun 29, 2026
jukie
added a commit
that referenced
this pull request
Jul 1, 2026
* fix rate limit validation on K8s 1.36 (#9166) fixi: rate limit validation on K8s 1.36 Starting with K8s 1.36 the int range and maximum are validated against each other, which breaks the BTP tests. This can be fixed validating the field as uint32. Signed-off-by: Clemens Beck <[email protected]> Co-authored-by: Clemens Beck <[email protected]> (cherry picked from commit a21fd29) Signed-off-by: jukie <[email protected]> * fix(validation): allow IPv6 to be specific in loadBalancerSourceRanges (#9050) * fix(validation): allow IPv6 to be specific in loadBalancerSourceRanges and loadBalancerIP Signed-off-by: Marc 'risson' Schmitt <[email protected]> (cherry picked from commit 3c1d7b9) Signed-off-by: jukie <[email protected]> * fix: allow Backend TLS to disable ALPN with an empty list (#9162) * Fixed Backend TLS to disable upstream ALPN instead of inheriting EnvoyProxy BackendTLS defaults. Signed-off-by: Huabing Zhao <[email protected]> * add test case for envoyproxy without tls Signed-off-by: Huabing Zhao <[email protected]> * Potential fix for pull request finding Co-authored-by: Copilot Autofix powered by AI <[email protected]> Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comments Signed-off-by: Huabing Zhao <[email protected]> --------- Signed-off-by: Huabing Zhao <[email protected]> Signed-off-by: Huabing (Robin) Zhao <[email protected]> Co-authored-by: Copilot Autofix powered by AI <[email protected]> (cherry picked from commit 21eb101) Signed-off-by: jukie <[email protected]> * fix(gatewayapi): sort api key auth credentials (#9042) * fix(gatewayapi): sort api key auth credentials Signed-off-by: Alexej Disterhoft <[email protected]> * docs(release-notes): add api key auth fix note Signed-off-by: Alexej Disterhoft <[email protected]> --------- Signed-off-by: Alexej Disterhoft <[email protected]> Signed-off-by: Alexej Disterhoft <[email protected]> Signed-off-by: zirain <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]> Co-authored-by: zirain <[email protected]> (cherry picked from commit b96a2d3) Signed-off-by: jukie <[email protected]> * fix(status): separate listener programmed state from HTTPRoute Accepted condition (#9129) * fix(status): separate listener programmed state from HTTPRoute Accepted condition Remove the NoReadyListeners block that set Accepted: False on routes when no listeners were programmed. Route acceptance reflects binding validity; listener programmed state is already tracked by the listener's own conditions. Signed-off-by: apkatsikas <[email protected]> * fix(status): separate listener programmed state from TCPRoute/UDPRoute Accepted condition Routes with a valid binding to an unprogrammed listener now correctly reach Accepted=True regardless of listener readiness. Moves accepted=true and IncrementAttachedRoutes before the IsReady check so the Accepted condition reflects binding validity only, consistent with the HTTPRoute fix and the Gateway API spec. Signed-off-by: apkatsikas <[email protected]> (cherry picked from commit e9c3ac5) Signed-off-by: jukie <[email protected]> * fix: reject ExternalName Service as a route backend (#9190) fix: reject Service as a route backend Signed-off-by: Huabing Zhao <[email protected]> Signed-off-by: Huabing (Robin) Zhao <[email protected]> (cherry picked from commit ee16b3f) Signed-off-by: jukie <[email protected]> * fix(status): fall back to service externalIPs for Gateway addresses (#9209) When the Envoy service is of type LoadBalancer but no load balancer controller assigns an ingress address (e.g. bare-metal clusters), the Gateway status had no addresses and stayed Programmed=False with reason AddressNotAssigned, even when reachable addresses were configured via spec.externalIPs (e.g. through an EnvoyProxy service patch). Use spec.externalIPs as a fallback when the load balancer ingress list is empty. Ingress addresses keep priority when present, so behavior is unchanged for clusters with a working load balancer controller. Fixes #8987 Signed-off-by: Jules Dutel <[email protected]> (cherry picked from commit f2c0921) Signed-off-by: jukie <[email protected]> * fix: don't duplicate ValidatingAdmissionPolicy in install.yaml (#9182) * Fix duplicate VAP in install.yaml Signed-off-by: jukie <[email protected]> * Add regression check and release notes Signed-off-by: jukie <[email protected]> --------- Signed-off-by: jukie <[email protected]> (cherry picked from commit 332081c) Signed-off-by: jukie <[email protected]> * fix(listenerset): implement hostname conflict listener precedence (#9192) * fix(listenerset): implement hostname conflict listener precedence - In Gateway, multiple listeners with the same hostname all get marked Conflicted (no winner). In ListenerSet, a Gateway-owned listener wins over ListenerSet listeners; among ListenerSet listeners the first in processing order wins. - Conflicted ListenerSet listeners now get Accepted=False and Programmed=False with the conflict reason (HostnameConflict or ProtocolConflict), matching the Gateway API conformance expectation. - AttachedListenerSets on the Gateway status is now incremented only for ListenerSets that have at least one accepted listener, aligning with the spec definition of "successfully attached". Signed-off-by: zirain <[email protected]> * ListenerSet conflict Signed-off-by: zirain <[email protected]> * fix and improve message Signed-off-by: zirain <[email protected]> * better display gateway listener Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> (cherry picked from commit 9271654) Signed-off-by: jukie <[email protected]> * fix: correct the config hot reload validation order (#9214) Co-authored-by: Nimisha Mehta <[email protected]> (cherry picked from commit 7e4492d) Signed-off-by: jukie <[email protected]> * feat(helm): add CRDs dependency toggle (#8850) * feat(helm): add CRDs dependency toggle Allow skipping installation of the `crds` dependency on the gateway-helm chart by providing a conditional `crds.enabled` variable. This boolean defaults to `true` and toggles the inclusion of the dependency on the parent chart. ref: #8560 Signed-off-by: Gaston Festari <[email protected]> * docs: update Helm installation steps Use the `crds.enabled` variable in the examples instead of the `--skip-crds` flag. Update crds.enabled variable description. Co-authored-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Gaston Festari <[email protected]> --------- Signed-off-by: Gaston Festari <[email protected]> Signed-off-by: Huabing (Robin) Zhao <[email protected]> Co-authored-by: Huabing (Robin) Zhao <[email protected]> (cherry picked from commit 62e01ce) Signed-off-by: jukie <[email protected]> * fix: validate API Key auth ExtractFrom (#9250) * fix: validate API Key auth ExtractFrom Signed-off-by: Huabing (Robin) Zhao <[email protected]> * add test Signed-off-by: Huabing (Robin) Zhao <[email protected]> * update Signed-off-by: Huabing (Robin) Zhao <[email protected]> * update Signed-off-by: Huabing (Robin) Zhao <[email protected]> * update Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> (cherry picked from commit 50b1339) Signed-off-by: jukie <[email protected]> * fix: XRateLimitHeadersOptionDisabled constant value must match CRD enum (#9224) * fix: XRateLimitHeadersOptionDisabled constant value must match CRD enum The constant held "Disabled" but the CRD enum specifies "Off", causing xRateLimitHeaders: "Off" to silently fall through the translator switch and always emit X-RateLimit headers. Fixes #9223 Signed-off-by: gianniskt <[email protected]> * fix: XRateLimitHeadersOptionDisabled constant value must match CRD enum The constant held "Disabled" but the CRD enum specifies "Off", causing xRateLimitHeaders: "Off" to silently fall through the translator switch and always emit X-RateLimit headers. Fixes #9223 Signed-off-by: gianniskt <[email protected]> * fix: add release note for XRateLimitHeadersOptionDisabled fix Signed-off-by: gianniskt <[email protected]> --------- Signed-off-by: gianniskt <[email protected]> Signed-off-by: Ioannis Koutroumpis <[email protected]> (cherry picked from commit 43c9d8e) Signed-off-by: jukie <[email protected]> * fix(ratelimit): shared global ratelimit with cost not working (#9245) * fix(ratelimit): shared global ratelimit with cost not working Signed-off-by: zirain <[email protected]> * fix Signed-off-by: zirain <[email protected]> * fix mixed shared rule Signed-off-by: zirain <[email protected]> * add e2e Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> (cherry picked from commit 7997791) Signed-off-by: jukie <[email protected]> * fix(gatewayapi): http retry without backoff (#9238) * fix http retry without backoff Signed-off-by: zirain <[email protected]> * release notes Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> (cherry picked from commit 4872e53) Signed-off-by: jukie <[email protected]> * fix: panic with empty deploy (#9365) Signed-off-by: zirain <[email protected]> (cherry picked from commit 42a0c2c) Signed-off-by: jukie <[email protected]> * chore: restore current.yaml after cherry-picks The cherry-picked bug-fix commits appended their release-note entries to release-notes/current.yaml. Those notes are already finalized in release-notes/v1.8.2.yaml, so restore current.yaml to its prior state to avoid duplicating them in the next release cycle. Signed-off-by: jukie <[email protected]> * [release-1.8] bump ratelimit image to 1e50889b Bump the Envoy Ratelimit image from ff287602 to 1e50889b in source and the gateway-helm chart, and note the bump under security updates in the v1.8.2 release notes. Signed-off-by: jukie <[email protected]> * testdata Signed-off-by: jukie <[email protected]> * fix: use int64 format for ratelimit Requests field (#9377) Signed-off-by: jukie <[email protected]> --------- Signed-off-by: Clemens Beck <[email protected]> Signed-off-by: jukie <[email protected]> Signed-off-by: Marc 'risson' Schmitt <[email protected]> Signed-off-by: Huabing Zhao <[email protected]> Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Alexej Disterhoft <[email protected]> Signed-off-by: Alexej Disterhoft <[email protected]> Signed-off-by: zirain <[email protected]> Signed-off-by: apkatsikas <[email protected]> Signed-off-by: Jules Dutel <[email protected]> Signed-off-by: Gaston Festari <[email protected]> Signed-off-by: gianniskt <[email protected]> Signed-off-by: Ioannis Koutroumpis <[email protected]> Co-authored-by: Clemens Beck <[email protected]> Co-authored-by: Clemens Beck <[email protected]> Co-authored-by: Marc 'risson' Schmitt <[email protected]> Co-authored-by: Huabing (Robin) Zhao <[email protected]> Co-authored-by: Copilot Autofix powered by AI <[email protected]> Co-authored-by: Alexej Disterhoft <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]> Co-authored-by: zirain <[email protected]> Co-authored-by: Andrew Katsikas <[email protected]> Co-authored-by: jvlxz <[email protected]> Co-authored-by: Mengjia Liang <[email protected]> Co-authored-by: Nimisha Mehta <[email protected]> Co-authored-by: Gaston Festari <[email protected]> Co-authored-by: Ioannis Koutroumpis <[email protected]>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting with K8s 1.36 the int range and maximum are validated against each other, which breaks the BTP tests.
This can be fixed validating the field as int64.
What this PR does / why we need it:
The issue was discovered while adding CI validation for K8s 1.36 in #8990.
CI action failing with 1.36: https://github.com/envoyproxy/gateway/actions/runs/26950365285/job/79513790168
Release Notes: No