fix: add unary interceptor and fix fail-open auth in GatewayNamespaceMode#8986
Merged
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…Mode Signed-off-by: Karol Szwaj <[email protected]>
cnvergence
force-pushed
the
fix-gnm-interceptor
branch
from
bf2f381 to
39585d7
Compare
Signed-off-by: Karol Szwaj <[email protected]>
Member
Author
|
Codex Review: Didn't find any major issues. Keep it up! ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8986 +/- ##
==========================================
+ Coverage 74.76% 74.79% +0.02%
==========================================
Files 251 251
Lines 40397 40417 +20
==========================================
+ Hits 30204 30229 +25
+ Misses 8128 8119 -9
- Partials 2065 2069 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rudrakhp
approved these changes
May 13, 2026
zhaohuabing
approved these changes
May 13, 2026
zhaohuabing
left a comment
zhaohuabing
left a comment
Member
There was a problem hiding this comment.
LGTM. Thanks for the quick fix!
Member
Author
|
/retest |
jukie
approved these changes
May 13, 2026
jukie
pushed a commit
to jukie/gateway
that referenced
this pull request
May 13, 2026
…Mode (envoyproxy#8986) Signed-off-by: jukie <[email protected]>
rudrakhp
pushed a commit
to rudrakhp/gateway
that referenced
this pull request
May 14, 2026
…Mode (envoyproxy#8986) Signed-off-by: Rudrakh Panigrahi <[email protected]>
nguyenptk
pushed a commit
to nguyenptk/gateway
that referenced
this pull request
May 15, 2026
…Mode (envoyproxy#8986) Signed-off-by: nguyenptk <[email protected]>
cnvergence
added a commit
to cnvergence/gateway
that referenced
this pull request
May 29, 2026
…Mode (envoyproxy#8986) Signed-off-by: Karol Szwaj <[email protected]>
cnvergence
added a commit
that referenced
this pull request
May 29, 2026
…atewayNamespaceMode (#8986) (#9116) fix: add unary interceptor and fix fail-open auth in GatewayNamespaceMode (#8986) Signed-off-by: Karol Szwaj <[email protected]>
cnvergence
added a commit
that referenced
this pull request
May 30, 2026
…atewayNamespaceMode (#8986) (#9118) fix: add unary interceptor and fix fail-open auth in GatewayNamespaceMode (#8986) Signed-off-by: Karol Szwaj <[email protected]>
cleman95
pushed a commit
to cleman95/gateway
that referenced
this pull request
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
The xDS gRPC server in GatewayNamespaceMode had no UnaryInterceptor, leaving all unary RPCs completely unauthenticated. The go-control-plane xDS server exposes both streaming and unary methods for all registered discovery services. Additionally, the stream interceptor only validated DeltaDiscoveryRequest messages.
This PR adds UnaryInterceptor, handles SotW requests as well and validates message types.
I have cleaned the code as well and added unit tests for interceptors.
Which issue(s) this PR fixes:
Fixes #
Release Notes: Yes