Skip to content

fix json report#8614

Merged
cnvergence merged 1 commit into
envoyproxy:mainfrom
zhaohuabing:fix-json-report
Mar 30, 2026
Merged

fix json report#8614
cnvergence merged 1 commit into
envoyproxy:mainfrom
zhaohuabing:fix-json-report

Conversation

@zhaohuabing

@zhaohuabing zhaohuabing commented Mar 30, 2026

Copy link
Copy Markdown
Member

Nighthawk emits nearby histogram percentiles instead of exact decimal values, for example the benchmark testdata shows values like:

  Percentile  Count   Value
  0.500000    17999   478.255µs
  0.750000    27001   494.671µs
  0.800000    28801   500.831µs
  0.900000    32398   524.479µs
  0.950000    34199   565.567µs
  0.990625    35660   1.174719ms
  0.999023    35962   4.073215ms

The current Json file will output 0 for P99.

        "percentiles": {
          "p50": 0.47825500000000004,
          "p75": 0.494671,
          "p80": 0.500831,
          "p90": 0.524479,
          "p95": 0.565567,
          "p99": 0,
          "p999": 0
        }

Signed-off-by: Huabing (Robin) Zhao <[email protected]>
@zhaohuabing zhaohuabing requested a review from a team as a code owner March 30, 2026 06:08
@netlify

netlify Bot commented Mar 30, 2026

Copy link
Copy Markdown

Deploy Preview for cerulean-figolla-1f9435 canceled.

Name Link
🔨 Latest commit 2656297
🔍 Latest deploy log https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69ca136e35f4a000080120d7

@zhaohuabing zhaohuabing requested a review from zirain March 30, 2026 06:08
@zhaohuabing zhaohuabing requested a review from a team March 30, 2026 06:13
@codecov

codecov Bot commented Mar 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.31%. Comparing base (945fe9f) to head (2656297).
⚠️ Report is 85 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8614      +/-   ##
==========================================
- Coverage   74.33%   74.31%   -0.03%     
==========================================
  Files         243      243              
  Lines       38155    38155              
==========================================
- Hits        28364    28354      -10     
- Misses       7802     7809       +7     
- Partials     1989     1992       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cnvergence cnvergence merged commit 4768ca7 into envoyproxy:main Mar 30, 2026
99 of 105 checks passed
rudrakhp added a commit that referenced this pull request Apr 24, 2026
* fix json report (#8614)

Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Signed-off-by: Rudrakh Panigrahi <[email protected]>

* fix: deep copy status in translator layer to avoid race (#8778)

Signed-off-by: Rudrakh Panigrahi <[email protected]>

* chore: setup translator test (#7627)

* chore: setup gatewayapi translator test

Signed-off-by: kkk777-7 <[email protected]>

* remove: duplicate resources in testfiles

Signed-off-by: kkk777-7 <[email protected]>

* update gatewayapi test output

Signed-off-by: kkk777-7 <[email protected]>

---------

Signed-off-by: kkk777-7 <[email protected]>
Signed-off-by: Rudrakh Panigrahi <[email protected]>

* perf: introduce translator context (#7535)

* perf: introduce translator context

Signed-off-by: kkk777-7 <[email protected]>

* perf: add policy map in translator context

Signed-off-by: kkk777-7 <[email protected]>

* chore: update tranlate bench

Signed-off-by: kkk777-7 <[email protected]>

* Revert "perf: add policy map in translator context"

This reverts commit 14a3784.

Signed-off-by: kkk777-7 <[email protected]>

* add translator context method, remove unused function

Signed-off-by: kkk777-7 <[email protected]>

* update gatewayapi test output

Signed-off-by: kkk777-7 <[email protected]>

* add resources in translator context

Signed-off-by: kkk777-7 <[email protected]>

* add gatewayapi translate bench

Signed-off-by: kkk777-7 <[email protected]>

* fix: set resources in translator context

Signed-off-by: kkk777-7 <[email protected]>

* fix: go lint

Signed-off-by: kkk777-7 <[email protected]>

* address comments

Signed-off-by: kkk777-7 <[email protected]>

* feat: support egctl translate options

Signed-off-by: kkk777-7 <[email protected]>

* update: bench test

Signed-off-by: kkk777-7 <[email protected]>

* update embedded field

Signed-off-by: kkk777-7 <[email protected]>

* fix gatewayapi testdata output

Signed-off-by: kkk777-7 <[email protected]>

---------

Signed-off-by: kkk777-7 <[email protected]>
Co-authored-by: zirain <[email protected]>
Signed-off-by: Rudrakh Panigrahi <[email protected]>

* fix gen-check

Signed-off-by: Rudrakh Panigrahi <[email protected]>

---------

Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Signed-off-by: Rudrakh Panigrahi <[email protected]>
Signed-off-by: kkk777-7 <[email protected]>
Co-authored-by: Huabing (Robin) Zhao <[email protected]>
Co-authored-by: Kota Kimura <[email protected]>
Co-authored-by: zirain <[email protected]>
skos-ninja pushed a commit to skos-ninja/envoy-gateway that referenced this pull request May 1, 2026
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Signed-off-by: Jake Oliver <[email protected]>
cnvergence added a commit that referenced this pull request May 9, 2026
* fix json report (#8614)

Signed-off-by: Huabing (Robin) Zhao <[email protected]>
(cherry picked from commit 4768ca7)

* fix: deep copy status in translator layer to avoid race (#8778)

Signed-off-by: Rudrakh Panigrahi <[email protected]>
(cherry picked from commit 3f70a89)

* fix: force HTTP1 for upstream connections for WS and WSS backends (#8699)

* force HTTP1 for upstream connections for WS and WSS backends

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

* use different clusters for mixed upstream protocols

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

* update

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

* fix lint

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

---------

Signed-off-by: Huabing (Robin) Zhao <[email protected]>
(cherry picked from commit 7633125)

* fix: reason with multiple errors rejected validation (#8859)

* fix: reason with multiple errors rejected validation

Signed-off-by: zirain <[email protected]>

* release notes

Signed-off-by: zirain <[email protected]>

* fix lint

Signed-off-by: zirain <[email protected]>

---------

Signed-off-by: zirain <[email protected]>
(cherry picked from commit 7811d86)

* feat(chart): Allow configuring envoy proxy image via helm chart (#8785)

* feat: Allow configuring envoy proxy defaults via helm chart

This commit is a continuation of the previous work to support supplying default proxy settings added in #7698 and adds three new chart values under `global.images.envoyProxy`:

| Value | Type | Default | Description |
|----------------------------------------|--------|------|---------------------------------------------------------------------|
| `global.images.envoyProxy.image`       | string | `""` | Full image name (`registry/repo:tag`) for the Envoy Proxy container |
| `global.images.envoyProxy.pullPolicy`  | string | `""` | Image pull policy                                                   |
| `global.images.envoyProxy.pullSecrets` | list   | `[]` | Image pull secrets                                                  |

When any of these are set, the chart generates an `envoyProxy:` block inside the `EnvoyGateway` ConfigMap, wiring into the existing `EnvoyGatewaySpec.envoyProxy` field (added in #7698). The global `imageRegistry` override takes highest precedence, consistent with other chart components.

Full EnvoyProxy defaults (replicas, resources, etc.) can be provided via `config.envoyGateway.envoyProxy`; the image values are merged on top.

Closes #4764.

Signed-off-by: Michael Sommerville <[email protected]>
(cherry picked from commit 8570285)

* add rn and version bump

Signed-off-by: Karol Szwaj <[email protected]>

* fix: respect backend endpoint hostname for health checks (#8929)

* fix: respect backend endpoint hostname for health checks

- Keep BackendTrafficPolicy HTTP health check hostnames as explicit cluster-level hosts, and leave route-derived host fallback to xDS cluster translation.
- Preserve Backend endpoint hostnames as per-endpoint overrides via Endpoint.HealthCheckConfig.hostname, ahead of the route fallback.
- Update gatewayapi/xDS fixtures, release notes, and generated API docs/CRDs for the host selection order.

- go test ./internal/ir
- go test ./internal/xds/translator
- go test ./internal/gatewayapi -run TestTranslate/backendtrafficpolicy
- go test ./internal/gatewayapi -run TestTranslate/(clienttrafficpolicy-http-health-check|envoyextensionpolicy-with-extproc-with-retries|envoyextensionpolicy-with-extproc-with-traffic-features|envoyproxy-accesslog-with-traffic|envoyproxy-tracing-backend-uds|envoyproxy-tracing-backend|securitypolicy-with-jwt-backendcluster|securitypolicy-with-jwt-backendsettings)
- make generate
- make manifests
- git diff --check

Signed-off-by: Arko Dasgupta <[email protected]>
Co-authored-by: Codex <[email protected]>

* fix gen

Signed-off-by: zirain <[email protected]>

---------

Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: zirain <[email protected]>
Co-authored-by: Codex <[email protected]>
Co-authored-by: zirain <[email protected]>

* update release notes

Signed-off-by: Karol Szwaj <[email protected]>

* fix gen-check

Signed-off-by: Karol Szwaj <[email protected]>

* Revert "feat(chart): Allow configuring envoy proxy image via helm chart (#8785)"

This reverts commit 092cc67.

Signed-off-by: Karol Szwaj <[email protected]>

---------

Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Signed-off-by: Rudrakh Panigrahi <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: Michael Sommerville <[email protected]>
Signed-off-by: Karol Szwaj <[email protected]>
Signed-off-by: Arko Dasgupta <[email protected]>
Co-authored-by: Huabing (Robin) Zhao <[email protected]>
Co-authored-by: Rudrakh Panigrahi <[email protected]>
Co-authored-by: zirain <[email protected]>
Co-authored-by: Michael Sommerville <[email protected]>
Co-authored-by: Arko Dasgupta <[email protected]>
Co-authored-by: Codex <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants