fix: aggregate xRoute/xPolicy statuses across GWCs in gateway-api runner by zhaohuabing · Pull Request #8387 · envoyproxy/gateway

zhaohuabing · 2026-03-02T10:14:33Z

This PR aggregates route and policy status across multiple GatewayClasses managed by the same controller, so resources preserve status from all relevant parents and ancestors instead of being overwritten by the last processed GatewayClass.

Fixes: #8318
Release note: yes

This PR continues the work from #7557. Thanks @y-rabie for all your previous work on this!

Signed-off-by: y-rabie <[email protected]>

netlify · 2026-03-02T10:14:38Z

✅ Deploy Preview for cerulean-figolla-1f9435 canceled.

Name	Link
🔨 Latest commit	`646784f`
🔍 Latest deploy log	https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/69a93986f1bd840008227108

…atewayclasses

codecov · 2026-03-03T07:03:47Z

Codecov Report

❌ Patch coverage is 18.67470% with 135 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.09%. Comparing base (6f6fa01) to head (646784f).
⚠️ Report is 7 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/gatewayapi/runner/runner.go	11.92%	133 Missing ⚠️
internal/gatewayapi/extensionserverpolicy.go	86.66%	1 Missing and 1 partial ⚠️

❌ Your patch status has failed because the patch coverage (18.67%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8387      +/-   ##
==========================================
- Coverage   74.23%   74.09%   -0.15%     
==========================================
  Files         242      242              
  Lines       37322    37405      +83     
==========================================
+ Hits        27705    27714       +9     
- Misses       7686     7757      +71     
- Partials     1931     1934       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

zhaohuabing · 2026-03-03T08:15:06Z

internal/gatewayapi/runner/runner.go

+				// Backend statuses have no parents, so they are not aggregated.
+				for _, backend := range result.Backends {
+					key := utils.NamespacedName(backend)
+					if len(backend.Status.Conditions) > 0 {


I'm not sure why we need this check, which is inconsistent with Gateway and listenerSet, but it's the existing behavior. cc @arkodg

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

arkodg · 2026-03-05T05:48:02Z

internal/gatewayapi/runner/runner.go

+				ExtensionServerPolicies: make(map[message.NamespacedNameAndGVK]*gwapiv1.PolicyStatus),
+			}
+
+			mergeRouteStatus := func(status, other *gwapiv1.RouteStatus) *gwapiv1.RouteStatus {


can we add a _test.go that includes tests for mergeRouteStatus and mergePolicyStatus since these are not covered by the testdata yaml ?

Added unit tests for mergeRouteStatus and mergePolicyStatus. Also e2e tests for BackendTrafficPolicy and HTTPRoute with multiple GCs.

internal/gatewayapi/runner/runner.go

arkodg · 2026-03-05T05:49:57Z

internal/gatewayapi/runner/runner.go

+				if other != nil {
+					if status != nil {
+						status.Parents = append(status.Parents, other.Parents...)
+					} else {


similar to https://github.com/envoyproxy/gateway/pull/8387/changes#r2887766809

Would you mind if we handle the route cap in a follow-up PR? It’s a broader existing issue, and I’d like to keep the scope of this PR focused.

This is unlikely to happen - the cap is 32, and keep that fix out would help CP this PR to v1.7.1 and v1.6.5.

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

…atewayclasses

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

…ner (envoyproxy#8387) * fix: aggregate xRoute/xPolicy statuses across GWCs in gateway-api runner Signed-off-by: y-rabie <[email protected]> * polish Signed-off-by: Huabing (Robin) Zhao <[email protected]> * add e2e test Signed-off-by: Huabing (Robin) Zhao <[email protected]> * release note Signed-off-by: Huabing (Robin) Zhao <[email protected]> * truncate policy status & add tests Signed-off-by: Huabing (Robin) Zhao <[email protected]> * update Signed-off-by: Huabing (Robin) Zhao <[email protected]> * update Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: y-rabie <[email protected]> Signed-off-by: Huabing (Robin) Zhao <[email protected]> Co-authored-by: y-rabie <[email protected]>

…ner (envoyproxy#8387) * fix: aggregate xRoute/xPolicy statuses across GWCs in gateway-api runner Signed-off-by: y-rabie <[email protected]> * polish Signed-off-by: Huabing (Robin) Zhao <[email protected]> * add e2e test Signed-off-by: Huabing (Robin) Zhao <[email protected]> * release note Signed-off-by: Huabing (Robin) Zhao <[email protected]> * truncate policy status & add tests Signed-off-by: Huabing (Robin) Zhao <[email protected]> * update Signed-off-by: Huabing (Robin) Zhao <[email protected]> * update Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: y-rabie <[email protected]> Signed-off-by: Huabing (Robin) Zhao <[email protected]> Co-authored-by: y-rabie <[email protected]> Signed-off-by: Karol Szwaj <[email protected]>

* api: make ConnectionLimit.Value optional (#8478) * api: make ConnectionLimit.Value optional Signed-off-by: Felipe Sabadini Facina <[email protected]> * release-notes: add entry for ConnectionLimit.Value optional Signed-off-by: Felipe Sabadini Facina <[email protected]> * fix: add CEL rule to require value when closeDelay is set Signed-off-by: Felipe Sabadini Facina <[email protected]> --------- Signed-off-by: Felipe Sabadini Facina <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix up release notes Signed-off-by: Karol Szwaj <[email protected]> * fix: aggregate xRoute/xPolicy statuses across GWCs in gateway-api runner (#8387) * fix: aggregate xRoute/xPolicy statuses across GWCs in gateway-api runner Signed-off-by: y-rabie <[email protected]> * polish Signed-off-by: Huabing (Robin) Zhao <[email protected]> * add e2e test Signed-off-by: Huabing (Robin) Zhao <[email protected]> * release note Signed-off-by: Huabing (Robin) Zhao <[email protected]> * truncate policy status & add tests Signed-off-by: Huabing (Robin) Zhao <[email protected]> * update Signed-off-by: Huabing (Robin) Zhao <[email protected]> * update Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: y-rabie <[email protected]> Signed-off-by: Huabing (Robin) Zhao <[email protected]> Co-authored-by: y-rabie <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix: active health check respect endpoint hostname (#8452) revert unrelated changes Signed-off-by: zirain <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix: exclude unmanaged route parents from xPolicy status ancestors (#8321) * add test for mixed managed and unmanaged Gateway parents Signed-off-by: Huabing (Robin) Zhao <[email protected]> * fix the policy status when the targeting routes have managed and unmanged Gateway parents Signed-off-by: Huabing (Robin) Zhao <[email protected]> * fix test Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix: add ownerReferences to ratelimit ConfigMap and HPA (#8358) Signed-off-by: Tejasriram Parvathaneni <[email protected]> Co-authored-by: Karol Szwaj <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix: computeHosts doesn't work when listener and route both wildcard (#8186) * fix: computeHosts doesn't work when listener and route both wildcard Signed-off-by: zirain <[email protected]> * remove skipped tests Signed-off-by: zirain <[email protected]> * Update internal/gatewayapi/helpers.go Co-authored-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> Co-authored-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix: fixed local object reference resolution from parent in merged BackendTrafficPolicies (#8210) Signed-off-by: Rudrakh Panigrahi <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix: XListenerSet allows route from same namespace (#8226) Previously, using allowedRoutes/Same for an XListenerSet with an xRoute in the same namespace would return an error. Now it properly allows xRoutes from the same namespace. Signed-off-by: Kris Hicks <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix: API key auth (#8267) * add test for multiple keys Signed-off-by: Huabing (Robin) Zhao <[email protected]> * revert secret transform Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix gen-check Signed-off-by: Karol Szwaj <[email protected]> * add release notes Signed-off-by: Karol Szwaj <[email protected]> * add release notes for envoy proxy image Signed-off-by: Karol Szwaj <[email protected]> --------- Signed-off-by: Felipe Sabadini Facina <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> Signed-off-by: y-rabie <[email protected]> Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> Signed-off-by: Tejasriram Parvathaneni <[email protected]> Signed-off-by: Rudrakh Panigrahi <[email protected]> Signed-off-by: Kris Hicks <[email protected]> Co-authored-by: Felipe Sabadini Facina <[email protected]> Co-authored-by: Huabing (Robin) Zhao <[email protected]> Co-authored-by: y-rabie <[email protected]> Co-authored-by: zirain <[email protected]> Co-authored-by: Tejasriram Parvathaneni <[email protected]> Co-authored-by: Rudrakh Panigrahi <[email protected]> Co-authored-by: Kris Hicks <[email protected]>

…ner (envoyproxy#8387) * fix: aggregate xRoute/xPolicy statuses across GWCs in gateway-api runner Signed-off-by: y-rabie <[email protected]> * polish Signed-off-by: Huabing (Robin) Zhao <[email protected]> * add e2e test Signed-off-by: Huabing (Robin) Zhao <[email protected]> * release note Signed-off-by: Huabing (Robin) Zhao <[email protected]> * truncate policy status & add tests Signed-off-by: Huabing (Robin) Zhao <[email protected]> * update Signed-off-by: Huabing (Robin) Zhao <[email protected]> * update Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: y-rabie <[email protected]> Signed-off-by: Huabing (Robin) Zhao <[email protected]> Co-authored-by: y-rabie <[email protected]>

…ner (envoyproxy#8387) * fix: aggregate xRoute/xPolicy statuses across GWCs in gateway-api runner Signed-off-by: y-rabie <[email protected]> * polish Signed-off-by: Huabing (Robin) Zhao <[email protected]> * add e2e test Signed-off-by: Huabing (Robin) Zhao <[email protected]> * release note Signed-off-by: Huabing (Robin) Zhao <[email protected]> * truncate policy status & add tests Signed-off-by: Huabing (Robin) Zhao <[email protected]> * update Signed-off-by: Huabing (Robin) Zhao <[email protected]> * update Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: y-rabie <[email protected]> Signed-off-by: Huabing (Robin) Zhao <[email protected]> Co-authored-by: y-rabie <[email protected]> Signed-off-by: Rudrakh Panigrahi <[email protected]>

* fix: fixed local object reference resolution from parent in merged BackendTrafficPolicies (#8210) Signed-off-by: Rudrakh Panigrahi <[email protected]> * fix: exclude unmanaged route parents from xPolicy status ancestors (#8321) * add test for mixed managed and unmanaged Gateway parents Signed-off-by: Huabing (Robin) Zhao <[email protected]> * fix the policy status when the targeting routes have managed and unmanged Gateway parents Signed-off-by: Huabing (Robin) Zhao <[email protected]> * fix test Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Rudrakh Panigrahi <[email protected]> * fix: computeHosts doesn't work when listener and route both wildcard (#8186) * fix: computeHosts doesn't work when listener and route both wildcard Signed-off-by: zirain <[email protected]> * remove skipped tests Signed-off-by: zirain <[email protected]> * Update internal/gatewayapi/helpers.go Co-authored-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> Co-authored-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Rudrakh Panigrahi <[email protected]> * fix: aggregate xRoute/xPolicy statuses across GWCs in gateway-api runner (#8387) * fix: aggregate xRoute/xPolicy statuses across GWCs in gateway-api runner Signed-off-by: y-rabie <[email protected]> * polish Signed-off-by: Huabing (Robin) Zhao <[email protected]> * add e2e test Signed-off-by: Huabing (Robin) Zhao <[email protected]> * release note Signed-off-by: Huabing (Robin) Zhao <[email protected]> * truncate policy status & add tests Signed-off-by: Huabing (Robin) Zhao <[email protected]> * update Signed-off-by: Huabing (Robin) Zhao <[email protected]> * update Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: y-rabie <[email protected]> Signed-off-by: Huabing (Robin) Zhao <[email protected]> Co-authored-by: y-rabie <[email protected]> Signed-off-by: Rudrakh Panigrahi <[email protected]> * fix: add ownerReferences to ratelimit ConfigMap and HPA (#8358) Signed-off-by: Tejasriram Parvathaneni <[email protected]> Co-authored-by: Karol Szwaj <[email protected]> Signed-off-by: Rudrakh Panigrahi <[email protected]> * api: make ConnectionLimit.Value optional (#8478) * api: make ConnectionLimit.Value optional Signed-off-by: Felipe Sabadini Facina <[email protected]> * release-notes: add entry for ConnectionLimit.Value optional Signed-off-by: Felipe Sabadini Facina <[email protected]> * fix: add CEL rule to require value when closeDelay is set Signed-off-by: Felipe Sabadini Facina <[email protected]> --------- Signed-off-by: Felipe Sabadini Facina <[email protected]> Signed-off-by: Rudrakh Panigrahi <[email protected]> * fix test race (#8180) * fix test race Signed-off-by: zirain <[email protected]> * use io.Discard Signed-off-by: zirain <[email protected]> * use sync.WaitGroup Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> Signed-off-by: Isaac Wilson <[email protected]> Co-authored-by: Isaac Wilson <[email protected]> Signed-off-by: Rudrakh Panigrahi <[email protected]> * fix gen check Signed-off-by: Rudrakh Panigrahi <[email protected]> --------- Signed-off-by: Rudrakh Panigrahi <[email protected]> Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> Signed-off-by: y-rabie <[email protected]> Signed-off-by: Tejasriram Parvathaneni <[email protected]> Signed-off-by: Felipe Sabadini Facina <[email protected]> Signed-off-by: Isaac Wilson <[email protected]> Co-authored-by: Huabing (Robin) Zhao <[email protected]> Co-authored-by: zirain <[email protected]> Co-authored-by: y-rabie <[email protected]> Co-authored-by: Teja079 <[email protected]> Co-authored-by: Karol Szwaj <[email protected]> Co-authored-by: Felipe Sabadini <[email protected]> Co-authored-by: Isaac Wilson <[email protected]>

fix: aggregate xRoute/xPolicy statuses across GWCs in gateway-api runner

53a85ba

Signed-off-by: y-rabie <[email protected]>

zhaohuabing requested a review from a team as a code owner March 2, 2026 10:14

zhaohuabing marked this pull request as draft March 2, 2026 10:35

zhaohuabing added this to the v1.8.0-rc.1 Release milestone Mar 2, 2026

zhaohuabing added 2 commits March 3, 2026 14:53

Merge remote-tracking branch 'origin/main' into merge-status-across-g…

a5dcd5b

…atewayclasses

Merge remote-tracking branch 'origin/main' into merge-status-across-g…

e97967c

…atewayclasses

zhaohuabing force-pushed the merge-status-across-gatewayclasses branch from 7fbcd34 to e97967c Compare March 3, 2026 06:54

zhaohuabing added 2 commits March 3, 2026 15:24

polish

a561b22

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

add e2e test

71581c2

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

zhaohuabing force-pushed the merge-status-across-gatewayclasses branch from da9c884 to 71581c2 Compare March 3, 2026 07:59

zhaohuabing added cherrypick/release-v1.7.1 cherrypick/release-v1.6.5 labels Mar 3, 2026

zhaohuabing marked this pull request as ready for review March 3, 2026 08:10

zhaohuabing commented Mar 3, 2026

View reviewed changes

zhaohuabing added 2 commits March 3, 2026 16:48

release note

830d1c9

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

Merge branch 'main' into merge-status-across-gatewayclasses

783348a

arkodg reviewed Mar 5, 2026

View reviewed changes

internal/gatewayapi/runner/runner.go Outdated Show resolved Hide resolved

arkodg reviewed Mar 5, 2026

View reviewed changes

zhaohuabing added 4 commits March 5, 2026 15:45

truncate policy status & add tests

7ef58b8

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

update

c5fc60f

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

Merge remote-tracking branch 'origin/main' into merge-status-across-g…

109f9b8

…atewayclasses

update

646784f

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

zhaohuabing mentioned this pull request Mar 5, 2026

Handle the route status cap (32) #8413

Closed

zhaohuabing requested a review from arkodg March 5, 2026 09:05

arkodg approved these changes Mar 5, 2026

View reviewed changes

arkodg requested review from a team March 5, 2026 16:17

zirain approved these changes Mar 6, 2026

View reviewed changes

zhaohuabing merged commit db383ef into envoyproxy:main Mar 6, 2026
152 of 174 checks passed

zhaohuabing deleted the merge-status-across-gatewayclasses branch March 6, 2026 06:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: aggregate xRoute/xPolicy statuses across GWCs in gateway-api runner#8387

fix: aggregate xRoute/xPolicy statuses across GWCs in gateway-api runner#8387
zhaohuabing merged 11 commits intoenvoyproxy:mainfrom
zhaohuabing:merge-status-across-gatewayclasses

zhaohuabing commented Mar 2, 2026 •

edited

Loading

Uh oh!

netlify bot commented Mar 2, 2026 •

edited

Loading

Uh oh!

codecov bot commented Mar 3, 2026 •

edited

Loading

Uh oh!

zhaohuabing Mar 3, 2026 •

edited

Loading

Uh oh!

arkodg Mar 5, 2026

Uh oh!

zhaohuabing Mar 5, 2026

Uh oh!

Uh oh!

arkodg Mar 5, 2026

Uh oh!

zhaohuabing Mar 5, 2026 •

edited

Loading

Uh oh!

arkodg Mar 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

zhaohuabing commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

netlify bot commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cerulean-figolla-1f9435 canceled.

Uh oh!

codecov bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

zhaohuabing Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arkodg Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

zhaohuabing Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

arkodg Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

zhaohuabing Mar 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

arkodg Mar 5, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

zhaohuabing commented Mar 2, 2026 •

edited

Loading

netlify bot commented Mar 2, 2026 •

edited

Loading

codecov bot commented Mar 3, 2026 •

edited

Loading

zhaohuabing Mar 3, 2026 •

edited

Loading

zhaohuabing Mar 5, 2026 •

edited

Loading