fix: route idle timeout by zhaohuabing · Pull Request #8058 · envoyproxy/gateway

zhaohuabing · 2026-01-26T07:57:13Z

netlify · 2026-01-26T07:57:18Z

✅ Deploy Preview for cerulean-figolla-1f9435 ready!

Name	Link
🔨 Latest commit	`69823cd`
🔍 Latest deploy log	https://app.netlify.com/projects/cerulean-figolla-1f9435/deploys/697c4e383919620008d4b05e
😎 Deploy Preview	https://deploy-preview-8058--cerulean-figolla-1f9435.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

zhaohuabing · 2026-01-26T08:03:12Z

internal/xds/translator/route.go

+	// When a user-configured request timeout exists at the route level, and no user-configured stream idle timeout exists
+	// at the listener level, set a route-level idle timeout to avoid stream timeout before request timeout.
+	requestTimeout := getEffectiveRequestTimeout(httpRoute)
+	idleTimeout := time.Hour // Default to 1 hour


Or we could remove the route-level implicit default, and add a warning status to the HTTPRoute when the configured request timeout is longer than the default HCM-level 5 minutes idle timeout - this would be a breaking change.

codecov · 2026-01-26T08:33:02Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.67%. Comparing base (8e4e092) to head (69823cd).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8058      +/-   ##
==========================================
- Coverage   73.68%   73.67%   -0.02%     
==========================================
  Files         240      240              
  Lines       36465    36470       +5     
==========================================
  Hits        26868    26868              
- Misses       7694     7698       +4     
- Partials     1903     1904       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

internal/xds/translator/route.go

guydc

LGTM, thanks!

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

zhaohuabing · 2026-01-30T13:40:59Z

Cherry-pick this into previous releases, as this blocks users from setting listener level idle timeout.

* fix: route idle timeout Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comments Signed-off-by: Huabing (Robin) Zhao <[email protected]> * add test Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Sadmi Bouhafs <[email protected]>

* fix: route idle timeout Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comments Signed-off-by: Huabing (Robin) Zhao <[email protected]> * add test Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Karol Szwaj <[email protected]>

* e2e: speed tracing tests (#8124) * e2e: speed tracing tests Signed-off-by: zirain <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix(translator): allow single-label backends in host mode (#8123) Signed-off-by: Adrian Cole <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * ci: release json report (#8107) Signed-off-by: zirain <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix oidc flakiness (#8119) * fix oidc flakiness Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix: skip_test_workflow doesn't exist (#8116) This also uses grouped redirects to satisfy shellcheck SC2129. Signed-off-by: Dylan M. Taylor <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix e2e test panic (#8109) fix e2e test Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * chore: bump func-e to v1.4.0 (#8105) bump func-e to v1.4.0 Signed-off-by: Adrian Cole <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix: route idle timeout (#8058) * fix: route idle timeout Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comments Signed-off-by: Huabing (Robin) Zhao <[email protected]> * add test Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * docs: add Mirakl to adopters list (#8138) Signed-off-by: Thierry Wandja <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * docs: add security warning to control plane extensions (#7967) chore(docs): add warnings about control plane extensions Signed-off-by: Guy Daich <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * chore: add lint for release notes filenames (#8137) * chore: add lint for release notes filenames Signed-off-by: zirain <[email protected]> * remove 1.7.0 Signed-off-by: zirain <[email protected]> * fix lint Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix: remove global logger in message package (#8131) * fix: remove global logger in message package Signed-off-by: zirain <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * docs: fix url result of regex rewrite (#7864) * Update http-urlrewrite.md Signed-off-by: Sadmi Bouhafs <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * chore: log skipped xds (#8132) log skipped xds Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * docs: fixes for OPA sidecar + Unix Domain Socket task (#8142) Signed-off-by: Matt Miller <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix: basic auth validation (#8053) * fix basic auth validation Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix: controller cache-sync readiness check (#7430) Signed-off-by: Karol Szwaj <[email protected]> * fix: replace context.TODO with timeout context in config dump (#8122) * fix: replace context.TODO with timeout context in config dump Uses context.WithTimeout instead of context.TODO() to enable proper cancellation and prevent indefinite hangs when Kubernetes API is slow or unavailable. Fixes #8121 Signed-off-by: jaffar <[email protected]> * Make config dump timeout configurable with 30s default - Add Timeout field to ConfigDump struct - Add DefaultConfigDumpTimeout constant (30s) - Add getTimeout() helper that returns configured timeout or default - Update Collect() to use cd.getTimeout() instead of hardcoded value Signed-off-by: jaffar <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * refactor: convert IR map fields to slices to ensure deterministic Dee… (#7953) * refactor: convert IR map fields to slices to ensure deterministic DeepEqual Addresses issue #7852. Signed-off-by: Junnygram <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix links in releasing and develop docs (#8141) * fix links in releasing and develop docs Signed-off-by: Karol Szwaj <[email protected]> * update quickstart link Signed-off-by: Karol Szwaj <[email protected]> --------- Signed-off-by: Karol Szwaj <[email protected]> * docs: add provider guide for entra (#7977) * docs: add provider guide for entra Signed-off-by: Oliver Bähler <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * chore: clean up test output files (#8154) clean up test output files Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix: TCPRoute mTLS didn't work (#8152) * fix: remove auto HTTP config on TCP cluster Signed-off-by: zirain <[email protected]> * fix lint Signed-off-by: zirain <[email protected]> * add e2e Signed-off-by: zirain <[email protected]> * fix e2e Signed-off-by: zirain <[email protected]> * fix comment Signed-off-by: zirain <[email protected]> * fix Signed-off-by: zirain <[email protected]> * fix resource name Signed-off-by: zirain <[email protected]> * address Arko's comment Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * v1.7.0-rc2 release notes (#8163) * v1.7.0-rc2 release notes Signed-off-by: Karol Szwaj <[email protected]> * fix the date Signed-off-by: Karol Szwaj <[email protected]> --------- Signed-off-by: Karol Szwaj <[email protected]> --------- Signed-off-by: zirain <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> Signed-off-by: Adrian Cole <[email protected]> Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Dylan M. Taylor <[email protected]> Signed-off-by: Thierry Wandja <[email protected]> Signed-off-by: Guy Daich <[email protected]> Signed-off-by: Sadmi Bouhafs <[email protected]> Signed-off-by: Matt Miller <[email protected]> Signed-off-by: jaffar <[email protected]> Signed-off-by: Junnygram <[email protected]> Signed-off-by: Oliver Bähler <[email protected]> Co-authored-by: zirain <[email protected]> Co-authored-by: Adrian Cole <[email protected]> Co-authored-by: Huabing (Robin) Zhao <[email protected]> Co-authored-by: Dylan M. Taylor <[email protected]> Co-authored-by: Thierry Wandja <[email protected]> Co-authored-by: Guy Daich <[email protected]> Co-authored-by: Sadmi Bouhafs <[email protected]> Co-authored-by: Matt Miller <[email protected]> Co-authored-by: Isaac Wilson <[email protected]> Co-authored-by: jaffar keikei <[email protected]> Co-authored-by: Olaleye <[email protected]> Co-authored-by: Oliver Bähler <[email protected]>

* fix: route idle timeout Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comments Signed-off-by: Huabing (Robin) Zhao <[email protected]> * add test Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]>

* feat: Ignore ready and stats listener metrics in shutdown manager calculation (#7985) * feat: Ignore ready and stats listener metrics in shutdown manager calculation Signed-off-by: zirain <[email protected]> * fix Signed-off-by: zirain <[email protected]> * fix Signed-off-by: zirain <[email protected]> * refactor Signed-off-by: zirain <[email protected]> * remove USE_SERVER_CONNECTIONS Signed-off-by: zirain <[email protected]> * address review comment Signed-off-by: zirain <[email protected]> * display the real value Signed-off-by: zirain <[email protected]> * comment for worker thread Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> * fix: custom response should be put at the first of the filter chain (#8061) * fix: custom response should be put before oauth2 Signed-off-by: Huabing (Robin) Zhao <[email protected]> * move the custom response filter to first Signed-off-by: Huabing (Robin) Zhao <[email protected]> * add release note Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> * fix: route idle timeout (#8058) * fix: route idle timeout Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comments Signed-off-by: Huabing (Robin) Zhao <[email protected]> * add test Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> * fix: remove global logger in message package (#8131) * fix: remove global logger in message package Signed-off-by: zirain <[email protected]> * fix gen Signed-off-by: zirain <[email protected]> * fix: controller cache-sync readiness check (#7430) Signed-off-by: zirain <[email protected]> * release notes for v1.5.9 (#8219) * release notes for v1.5.9 Signed-off-by: zirain <[email protected]> * update Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> * update VERSION Signed-off-by: zirain <[email protected]> * update release notes Signed-off-by: zirain <[email protected]> * update Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> Signed-off-by: Huabing (Robin) Zhao <[email protected]> Co-authored-by: Huabing (Robin) Zhao <[email protected]> Co-authored-by: Isaac Wilson <[email protected]>

* fix(status): align BackendTLSPolicy ResolvedRefs reason with Gateway API (#7793) * fix(status): align BackendTLSPolicy ResolvedRefs reason with Gateway API Signed-off-by: Aditya7880900936 <[email protected]> * fix(gatewayapi): use accurate error for missing CA bundle in BackendTLSPolicy Signed-off-by: Aditya7880900936 <[email protected]> * gatewayapi: fix BackendTLSPolicy status reasons for invalid CA refs Signed-off-by: Aditya7880900936 <[email protected]> * Update internal/gatewayapi/backendtlspolicy.go Co-authored-by: Arko Dasgupta <[email protected]> Signed-off-by: Aditya Sanskar Srivastav <[email protected]> * gatewayapi: align BackendTLSPolicy invalid CA status and formatting Signed-off-by: Aditya7880900936 <[email protected]> * gatewayapi: align BackendTLSPolicy invalid CA error message with validation output Signed-off-by: Aditya7880900936 <[email protected]> * testdata: regenerate BackendTLSPolicy invalid CA output Signed-off-by: Aditya7880900936 <[email protected]> * fix(gatewayapi): keep Accepted reason as NoValidCACertificate for invalid CA ref kind Signed-off-by: Aditya7880900936 <[email protected]> * chore(gatewayapi): fix import grouping in BackendTLSPolicy Signed-off-by: Aditya7880900936 <[email protected]> --------- Signed-off-by: Aditya7880900936 <[email protected]> Signed-off-by: Aditya Sanskar Srivastav <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]> * feat: Ignore ready and stats listener metrics in shutdown manager calculation (#7985) * feat: Ignore ready and stats listener metrics in shutdown manager calculation Signed-off-by: zirain <[email protected]> * fix Signed-off-by: zirain <[email protected]> * fix Signed-off-by: zirain <[email protected]> * refactor Signed-off-by: zirain <[email protected]> * remove USE_SERVER_CONNECTIONS Signed-off-by: zirain <[email protected]> * address review comment Signed-off-by: zirain <[email protected]> * display the real value Signed-off-by: zirain <[email protected]> * comment for worker thread Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> * fix: custom response should be put at the first of the filter chain (#8061) * fix: custom response should be put before oauth2 Signed-off-by: Huabing (Robin) Zhao <[email protected]> * move the custom response filter to first Signed-off-by: Huabing (Robin) Zhao <[email protected]> * add release note Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> * fix: route idle timeout (#8058) * fix: route idle timeout Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comments Signed-off-by: Huabing (Robin) Zhao <[email protected]> * add test Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> * fix: remove global logger in message package (#8131) * fix: remove global logger in message package Signed-off-by: zirain <[email protected]> * fix: TCPRoute mTLS didn't work (#8152) * fix: remove auto HTTP config on TCP cluster Signed-off-by: zirain <[email protected]> * fix lint Signed-off-by: zirain <[email protected]> * add e2e Signed-off-by: zirain <[email protected]> * fix e2e Signed-off-by: zirain <[email protected]> * fix comment Signed-off-by: zirain <[email protected]> * fix Signed-off-by: zirain <[email protected]> * fix resource name Signed-off-by: zirain <[email protected]> * address Arko's comment Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> * fix: continue processing the remaining xDS with invalid EnvoyPatchPolicies (#8153) continue processing the remaining xDS with invalid EnvoyPatchPolicies Signed-off-by: Huabing (Robin) Zhao <[email protected]> * fix gen Signed-off-by: zirain <[email protected]> * fix gen Signed-off-by: zirain <[email protected]> * fix: controller cache-sync readiness check (#7430) Signed-off-by: zirain <[email protected]> * fix gen Signed-off-by: zirain <[email protected]> * release notes for v1.6.4 (#8221) * release notes for v1.6.4 Signed-off-by: zirain <[email protected]> * update Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> * update VERSION Signed-off-by: zirain <[email protected]> * update release notes Signed-off-by: zirain <[email protected]> * update Signed-off-by: zirain <[email protected]> --------- Signed-off-by: Aditya7880900936 <[email protected]> Signed-off-by: Aditya Sanskar Srivastav <[email protected]> Signed-off-by: zirain <[email protected]> Signed-off-by: Huabing (Robin) Zhao <[email protected]> Co-authored-by: Aditya Sanskar Srivastav <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]> Co-authored-by: Huabing (Robin) Zhao <[email protected]> Co-authored-by: Isaac Wilson <[email protected]>

zhaohuabing requested a review from a team as a code owner January 26, 2026 07:57

zhaohuabing requested a review from guydc January 26, 2026 07:57

zhaohuabing marked this pull request as draft January 26, 2026 07:57

zhaohuabing force-pushed the fix-7806 branch from 0bf1dd6 to a6960a5 Compare January 26, 2026 08:00

zhaohuabing commented Jan 26, 2026

View reviewed changes

zhaohuabing marked this pull request as ready for review January 26, 2026 08:03

zhaohuabing added this to the v1.7.0-rc.1 Release milestone Jan 26, 2026

zhaohuabing force-pushed the fix-7806 branch from a6960a5 to 689a5b5 Compare January 26, 2026 08:23

arkodg reviewed Jan 28, 2026

View reviewed changes

internal/xds/translator/route.go Show resolved Hide resolved

arkodg modified the milestones: v1.7.0-rc.1 Release, v1.7.0 Release Jan 28, 2026

guydc approved these changes Jan 30, 2026

View reviewed changes

arkodg approved these changes Jan 30, 2026

View reviewed changes

zhaohuabing added 3 commits January 30, 2026 14:22

fix: route idle timeout

1794295

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

address comments

777a634

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

add test

69823cd

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

zirain force-pushed the fix-7806 branch from 6958d24 to 69823cd Compare January 30, 2026 06:22

zhaohuabing merged commit 45f92bc into envoyproxy:main Jan 30, 2026
57 of 59 checks passed

zhaohuabing added the cherrypick/release-v1.6.4 label Jan 30, 2026

zhaohuabing deleted the fix-7806 branch January 30, 2026 13:39

zhaohuabing added the cherrypick/release-v1.5.9 label Jan 30, 2026

zirain mentioned this pull request Feb 9, 2026

[release-1.5] cherry pick for v1.5.9 #8217

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: route idle timeout#8058

fix: route idle timeout#8058
zhaohuabing merged 3 commits intoenvoyproxy:mainfrom
zhaohuabing:fix-7806

zhaohuabing commented Jan 26, 2026

Uh oh!

netlify bot commented Jan 26, 2026 •

edited

Loading

Uh oh!

zhaohuabing Jan 26, 2026

Uh oh!

codecov bot commented Jan 26, 2026 •

edited

Loading

Uh oh!

Uh oh!

guydc left a comment

Uh oh!

Uh oh!

zhaohuabing commented Jan 30, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

zhaohuabing commented Jan 26, 2026

Uh oh!

netlify bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cerulean-figolla-1f9435 ready!

Uh oh!

zhaohuabing Jan 26, 2026

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Jan 26, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

guydc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

zhaohuabing commented Jan 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

netlify bot commented Jan 26, 2026 •

edited

Loading

codecov bot commented Jan 26, 2026 •

edited

Loading

zhaohuabing commented Jan 30, 2026 •

edited

Loading