Merged
Conversation
✅ Deploy Preview for cerulean-figolla-1f9435 canceled.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8053 +/- ##
==========================================
- Coverage 73.74% 73.69% -0.05%
==========================================
Files 240 240
Lines 36470 36475 +5
==========================================
- Hits 26893 26882 -11
- Misses 7678 7689 +11
- Partials 1899 1904 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
cnvergence
previously approved these changes
Jan 27, 2026
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
arkodg
reviewed
Jan 30, 2026
| if !strings.HasPrefix(password, "{SHA}") { | ||
| return fmt.Errorf("unsupported htpasswd format: please use {SHA}") | ||
| } | ||
| // Envoy BasicAuth only supports unsalted SHA1 {SHA}<base64> generated by htpasswd. |
Contributor
There was a problem hiding this comment.
can we rm L1834 string SHA check, since this makes it redundant
Member
Author
There was a problem hiding this comment.
It's not redundant - the hashed password must start with "{SHA}", and Line1838 doesn't check that.
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
arkodg
approved these changes
Jan 31, 2026
nareddyt
approved these changes
Jan 31, 2026
cnvergence
pushed a commit
to cnvergence/gateway
that referenced
this pull request
Feb 3, 2026
* fix basic auth validation Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Karol Szwaj <[email protected]>
cnvergence
added a commit
that referenced
this pull request
Feb 3, 2026
* e2e: speed tracing tests (#8124) * e2e: speed tracing tests Signed-off-by: zirain <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix(translator): allow single-label backends in host mode (#8123) Signed-off-by: Adrian Cole <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * ci: release json report (#8107) Signed-off-by: zirain <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix oidc flakiness (#8119) * fix oidc flakiness Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix: skip_test_workflow doesn't exist (#8116) This also uses grouped redirects to satisfy shellcheck SC2129. Signed-off-by: Dylan M. Taylor <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix e2e test panic (#8109) fix e2e test Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * chore: bump func-e to v1.4.0 (#8105) bump func-e to v1.4.0 Signed-off-by: Adrian Cole <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix: route idle timeout (#8058) * fix: route idle timeout Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comments Signed-off-by: Huabing (Robin) Zhao <[email protected]> * add test Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * docs: add Mirakl to adopters list (#8138) Signed-off-by: Thierry Wandja <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * docs: add security warning to control plane extensions (#7967) chore(docs): add warnings about control plane extensions Signed-off-by: Guy Daich <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * chore: add lint for release notes filenames (#8137) * chore: add lint for release notes filenames Signed-off-by: zirain <[email protected]> * remove 1.7.0 Signed-off-by: zirain <[email protected]> * fix lint Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix: remove global logger in message package (#8131) * fix: remove global logger in message package Signed-off-by: zirain <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * docs: fix url result of regex rewrite (#7864) * Update http-urlrewrite.md Signed-off-by: Sadmi Bouhafs <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * chore: log skipped xds (#8132) log skipped xds Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * docs: fixes for OPA sidecar + Unix Domain Socket task (#8142) Signed-off-by: Matt Miller <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix: basic auth validation (#8053) * fix basic auth validation Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix: controller cache-sync readiness check (#7430) Signed-off-by: Karol Szwaj <[email protected]> * fix: replace context.TODO with timeout context in config dump (#8122) * fix: replace context.TODO with timeout context in config dump Uses context.WithTimeout instead of context.TODO() to enable proper cancellation and prevent indefinite hangs when Kubernetes API is slow or unavailable. Fixes #8121 Signed-off-by: jaffar <[email protected]> * Make config dump timeout configurable with 30s default - Add Timeout field to ConfigDump struct - Add DefaultConfigDumpTimeout constant (30s) - Add getTimeout() helper that returns configured timeout or default - Update Collect() to use cd.getTimeout() instead of hardcoded value Signed-off-by: jaffar <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * refactor: convert IR map fields to slices to ensure deterministic Dee… (#7953) * refactor: convert IR map fields to slices to ensure deterministic DeepEqual Addresses issue #7852. Signed-off-by: Junnygram <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix links in releasing and develop docs (#8141) * fix links in releasing and develop docs Signed-off-by: Karol Szwaj <[email protected]> * update quickstart link Signed-off-by: Karol Szwaj <[email protected]> --------- Signed-off-by: Karol Szwaj <[email protected]> * docs: add provider guide for entra (#7977) * docs: add provider guide for entra Signed-off-by: Oliver Bähler <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * chore: clean up test output files (#8154) clean up test output files Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix: TCPRoute mTLS didn't work (#8152) * fix: remove auto HTTP config on TCP cluster Signed-off-by: zirain <[email protected]> * fix lint Signed-off-by: zirain <[email protected]> * add e2e Signed-off-by: zirain <[email protected]> * fix e2e Signed-off-by: zirain <[email protected]> * fix comment Signed-off-by: zirain <[email protected]> * fix Signed-off-by: zirain <[email protected]> * fix resource name Signed-off-by: zirain <[email protected]> * address Arko's comment Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * v1.7.0-rc2 release notes (#8163) * v1.7.0-rc2 release notes Signed-off-by: Karol Szwaj <[email protected]> * fix the date Signed-off-by: Karol Szwaj <[email protected]> --------- Signed-off-by: Karol Szwaj <[email protected]> --------- Signed-off-by: zirain <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> Signed-off-by: Adrian Cole <[email protected]> Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Dylan M. Taylor <[email protected]> Signed-off-by: Thierry Wandja <[email protected]> Signed-off-by: Guy Daich <[email protected]> Signed-off-by: Sadmi Bouhafs <[email protected]> Signed-off-by: Matt Miller <[email protected]> Signed-off-by: jaffar <[email protected]> Signed-off-by: Junnygram <[email protected]> Signed-off-by: Oliver Bähler <[email protected]> Co-authored-by: zirain <[email protected]> Co-authored-by: Adrian Cole <[email protected]> Co-authored-by: Huabing (Robin) Zhao <[email protected]> Co-authored-by: Dylan M. Taylor <[email protected]> Co-authored-by: Thierry Wandja <[email protected]> Co-authored-by: Guy Daich <[email protected]> Co-authored-by: Sadmi Bouhafs <[email protected]> Co-authored-by: Matt Miller <[email protected]> Co-authored-by: Isaac Wilson <[email protected]> Co-authored-by: jaffar keikei <[email protected]> Co-authored-by: Olaleye <[email protected]> Co-authored-by: Oliver Bähler <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #8034
Add SHA1 format validation for Basic Auth, aligning with Envoy’s validation in the Basic Auth filter.