Skip to content

fix: make port-forward worked for OTel collector on port 19001#7860

Merged
zirain merged 1 commit intoenvoyproxy:mainfrom
zirain:fix-otel
Jan 6, 2026
Merged

fix: make port-forward worked for OTel collector on port 19001#7860
zirain merged 1 commit intoenvoyproxy:mainfrom
zirain:fix-otel

Conversation

@zirain
Copy link
Copy Markdown
Member

@zirain zirain commented Jan 4, 2026

fixes: #7858

@zirain zirain requested a review from a team as a code owner January 4, 2026 12:58
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.79%. Comparing base (83cd3fd) to head (4e91f93).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7860      +/-   ##
==========================================
+ Coverage   72.75%   72.79%   +0.03%     
==========================================
  Files         236      236              
  Lines       35190    35190              
==========================================
+ Hits        25604    25615      +11     
+ Misses       7764     7757       -7     
+ Partials     1822     1818       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@rudrakhp rudrakhp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like empty is empty is treated as 0.0.0.0/::

| opentelemetry-collector.config.exporters.otlp.endpoint | string | `"tempo.monitoring.svc:4317"` | |
| opentelemetry-collector.config.exporters.otlp.tls.insecure | bool | `true` | |
| opentelemetry-collector.config.exporters.prometheus.endpoint | string | `"[${env:MY_POD_IP}]:19001"` | |
| opentelemetry-collector.config.exporters.prometheus.endpoint | string | `":19001"` | |
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to port this change to v1.5 docs as well if you plan for this to be part of v1.5.7 patch release?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the doc will be fixed automatically after release happen.

@zirain zirain merged commit b3e7437 into envoyproxy:main Jan 6, 2026
56 of 58 checks passed
@zirain zirain deleted the fix-otel branch January 6, 2026 01:26
zirain added a commit to zirain/gateway that referenced this pull request Jan 8, 2026
rudrakhp pushed a commit to rudrakhp/gateway that referenced this pull request Jan 8, 2026
zirain added a commit that referenced this pull request Jan 9, 2026
* fix: set observedGeneration in envoy patch policy (#7715)

* fix: set observedGeneration in envoy patch policy

Signed-off-by: kkk777-7 <[email protected]>

* add release note

Signed-off-by: kkk777-7 <[email protected]>

---------

Signed-off-by: kkk777-7 <[email protected]>
Signed-off-by: zirain <[email protected]>

* fix: add validation for request buffer limit (#7687)

Signed-off-by: kkk777-7 <[email protected]>
Signed-off-by: zirain <[email protected]>

* fix: setting externalTrafficPolicy for NodePort service type (#7823)

Signed-off-by: Rudrakh Panigrahi <[email protected]>
Signed-off-by: zirain <[email protected]>

* fix: make port-forward worked for OTel collector on port 19001 (#7860)

Signed-off-by: zirain <[email protected]>

* chore: fix goroutine leak (#7880)

fix goroutine leak

Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: zirain <[email protected]>

* fix gen

Signed-off-by: zirain <[email protected]>

* bump envoy to 1.35.8

Signed-off-by: zirain <[email protected]>

---------

Signed-off-by: kkk777-7 <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: Rudrakh Panigrahi <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Co-authored-by: Kota Kimura <[email protected]>
Co-authored-by: Rudrakh Panigrahi <[email protected]>
Co-authored-by: Huabing (Robin) Zhao <[email protected]>
rudrakhp added a commit that referenced this pull request Jan 9, 2026
* fix: set observedGeneration in envoy patch policy (#7715)

* fix: set observedGeneration in envoy patch policy

Signed-off-by: kkk777-7 <[email protected]>

* add release note

Signed-off-by: kkk777-7 <[email protected]>

---------

Signed-off-by: kkk777-7 <[email protected]>
Signed-off-by: Rudrakh Panigrahi <[email protected]>

* fix: add validation for request buffer limit (#7687)

Signed-off-by: kkk777-7 <[email protected]>
Signed-off-by: Rudrakh Panigrahi <[email protected]>

* fix: nil pointer error when applying BackendTrafficPolicy to HTTPRoute with no backendRefs (#7765)

* fix: checking route section name in backend traffic policy

Signed-off-by: kkk777-7 <[email protected]>
Signed-off-by: Rudrakh Panigrahi <[email protected]>

* fix: setting externalTrafficPolicy for NodePort service type (#7823)

Signed-off-by: Rudrakh Panigrahi <[email protected]>

* fix: add indexing and processing for CRL references in ClientTrafficPolicies (#7829)

Signed-off-by: Rudrakh Panigrahi <[email protected]>

* feat: change the benchmark report to json format (#6818)

* benchmark json output

Signed-off-by: zirain <[email protected]>

* fix

Signed-off-by: zirain <[email protected]>

* fix

Signed-off-by: zirain <[email protected]>

* fix lint

Signed-off-by: zirain <[email protected]>

* fix

Signed-off-by: zirain <[email protected]>

* revert

Signed-off-by: zirain <[email protected]>

* fix seconds

Signed-off-by: zirain <[email protected]>

---------

Signed-off-by: zirain <[email protected]>
Signed-off-by: Rudrakh Panigrahi <[email protected]>

* bechmark: scale up RPS to test data plane CPU performance (#7810)

* Scale up RPS to test data plane CPU performance

Signed-off-by: Huabing Zhao <[email protected]>

* set duration to 120s

Signed-off-by: Huabing Zhao <[email protected]>

* discard invalid samples

Signed-off-by: Huabing Zhao <[email protected]>

* change scrape interval to 10s

Signed-off-by: Huabing Zhao <[email protected]>

* remove invalid cpu sampling data

Signed-off-by: Huabing Zhao <[email protected]>

* reduce duration to 60

Signed-off-by: Huabing Zhao <[email protected]>

* fix benchmark end time

Signed-off-by: Huabing Zhao <[email protected]>

* fix data plane benchmark start time

Signed-off-by: Huabing Zhao <[email protected]>

* increase test time to get more samples

Signed-off-by: Huabing Zhao <[email protected]>

* adjust rps for each scale

Signed-off-by: Huabing Zhao <[email protected]>

* address comments

Signed-off-by: Huabing(Robin) Zhao <[email protected]>

---------

Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing(Robin) Zhao <[email protected]>
Signed-off-by: Rudrakh Panigrahi <[email protected]>

* fix: make port-forward worked for OTel collector on port 19001 (#7860)

Signed-off-by: zirain <[email protected]>
Signed-off-by: Rudrakh Panigrahi <[email protected]>

* chore: fix goroutine leak (#7880)

fix goroutine leak

Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Rudrakh Panigrahi <[email protected]>

* fix gen-check

Signed-off-by: Rudrakh Panigrahi <[email protected]>

---------

Signed-off-by: kkk777-7 <[email protected]>
Signed-off-by: Rudrakh Panigrahi <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: Huabing Zhao <[email protected]>
Signed-off-by: Huabing(Robin) Zhao <[email protected]>
Co-authored-by: Kota Kimura <[email protected]>
Co-authored-by: zirain <[email protected]>
Co-authored-by: Huabing (Robin) Zhao <[email protected]>
SadmiB pushed a commit to SadmiB/gateway that referenced this pull request Jan 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

wrong otel_pod port number

3 participants