fix: make IR map comparison deterministic in runner tests#7852
Closed
Aditya7880900936 wants to merge 5 commits intoenvoyproxy:mainfrom
Closed
fix: make IR map comparison deterministic in runner tests#7852Aditya7880900936 wants to merge 5 commits intoenvoyproxy:mainfrom
Aditya7880900936 wants to merge 5 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Aditya7880900936 <[email protected]>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7852 +/- ##
==========================================
+ Coverage 72.77% 72.79% +0.02%
==========================================
Files 235 235
Lines 35165 35190 +25
==========================================
+ Hits 25592 25618 +26
+ Misses 7756 7755 -1
Partials 1817 1817 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Aditya7880900936 <[email protected]>
Aditya7880900936
force-pushed
the
fix-ir-map-to-slice
branch
from
1598a08 to
60054cc
Compare
rudrakhp
reviewed
Dec 31, 2025
cnvergence
reviewed
Dec 31, 2025
Signed-off-by: Aditya7880900936 <[email protected]>
Contributor
|
@Aditya7880900936 we want to eliminate maps from the IR and use a list of structs instead to ensure order |
Contributor
Author
|
Hi @arkodg @rudrakhp , That makes sense. This PR focuses on making the existing tests deterministic without changing the IR shape, but I agree the proper fix is to eliminate maps from the IR entirely and replace them with ordered slices of structs. Happy to follow up with a separate PR that converts the relevant IR maps to slices, if that sounds good. |
Contributor
Author
Signed-off-by: Aditya Sanskar Srivastav <[email protected]>
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
Contributor
Author
|
Hi @arkodg , |
Junnygram
added a commit
to Junnygram/gateway
that referenced
this pull request
Jan 14, 2026
…pEqual Addresses issue envoyproxy#7852. Signed-off-by: Junnygram <[email protected]>
Contributor
|
closing in favor of #7953 |
Junnygram
added a commit
to Junnygram/gateway
that referenced
this pull request
Jan 25, 2026
…pEqual Addresses issue envoyproxy#7852. Signed-off-by: Junnygram <[email protected]>
zirain
pushed a commit
to Junnygram/gateway
that referenced
this pull request
Jan 28, 2026
…pEqual Addresses issue envoyproxy#7852. Signed-off-by: Junnygram <[email protected]>
Junnygram
added a commit
to Junnygram/gateway
that referenced
this pull request
Jan 30, 2026
…pEqual Addresses issue envoyproxy#7852. Signed-off-by: Junnygram <[email protected]>
Junnygram
added a commit
to Junnygram/gateway
that referenced
this pull request
Jan 30, 2026
…pEqual Addresses issue envoyproxy#7852. Signed-off-by: Junnygram <[email protected]>
zirain
pushed a commit
to Junnygram/gateway
that referenced
this pull request
Jan 31, 2026
…pEqual Addresses issue envoyproxy#7852. Signed-off-by: Junnygram <[email protected]>
Junnygram
added a commit
to Junnygram/gateway
that referenced
this pull request
Jan 31, 2026
…pEqual Addresses issue envoyproxy#7852. Signed-off-by: Junnygram <[email protected]>
arkodg
pushed a commit
that referenced
this pull request
Feb 1, 2026
#7953) * refactor: convert IR map fields to slices to ensure deterministic DeepEqual Addresses issue #7852. Signed-off-by: Junnygram <[email protected]>
cnvergence
pushed a commit
to cnvergence/gateway
that referenced
this pull request
Feb 3, 2026
envoyproxy#7953) * refactor: convert IR map fields to slices to ensure deterministic DeepEqual Addresses issue envoyproxy#7852. Signed-off-by: Junnygram <[email protected]> Signed-off-by: Karol Szwaj <[email protected]>
cnvergence
added a commit
that referenced
this pull request
Feb 3, 2026
* e2e: speed tracing tests (#8124) * e2e: speed tracing tests Signed-off-by: zirain <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix(translator): allow single-label backends in host mode (#8123) Signed-off-by: Adrian Cole <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * ci: release json report (#8107) Signed-off-by: zirain <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix oidc flakiness (#8119) * fix oidc flakiness Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix: skip_test_workflow doesn't exist (#8116) This also uses grouped redirects to satisfy shellcheck SC2129. Signed-off-by: Dylan M. Taylor <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix e2e test panic (#8109) fix e2e test Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * chore: bump func-e to v1.4.0 (#8105) bump func-e to v1.4.0 Signed-off-by: Adrian Cole <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix: route idle timeout (#8058) * fix: route idle timeout Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comments Signed-off-by: Huabing (Robin) Zhao <[email protected]> * add test Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * docs: add Mirakl to adopters list (#8138) Signed-off-by: Thierry Wandja <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * docs: add security warning to control plane extensions (#7967) chore(docs): add warnings about control plane extensions Signed-off-by: Guy Daich <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * chore: add lint for release notes filenames (#8137) * chore: add lint for release notes filenames Signed-off-by: zirain <[email protected]> * remove 1.7.0 Signed-off-by: zirain <[email protected]> * fix lint Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix: remove global logger in message package (#8131) * fix: remove global logger in message package Signed-off-by: zirain <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * docs: fix url result of regex rewrite (#7864) * Update http-urlrewrite.md Signed-off-by: Sadmi Bouhafs <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * chore: log skipped xds (#8132) log skipped xds Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * docs: fixes for OPA sidecar + Unix Domain Socket task (#8142) Signed-off-by: Matt Miller <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix: basic auth validation (#8053) * fix basic auth validation Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix: controller cache-sync readiness check (#7430) Signed-off-by: Karol Szwaj <[email protected]> * fix: replace context.TODO with timeout context in config dump (#8122) * fix: replace context.TODO with timeout context in config dump Uses context.WithTimeout instead of context.TODO() to enable proper cancellation and prevent indefinite hangs when Kubernetes API is slow or unavailable. Fixes #8121 Signed-off-by: jaffar <[email protected]> * Make config dump timeout configurable with 30s default - Add Timeout field to ConfigDump struct - Add DefaultConfigDumpTimeout constant (30s) - Add getTimeout() helper that returns configured timeout or default - Update Collect() to use cd.getTimeout() instead of hardcoded value Signed-off-by: jaffar <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * refactor: convert IR map fields to slices to ensure deterministic Dee… (#7953) * refactor: convert IR map fields to slices to ensure deterministic DeepEqual Addresses issue #7852. Signed-off-by: Junnygram <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix links in releasing and develop docs (#8141) * fix links in releasing and develop docs Signed-off-by: Karol Szwaj <[email protected]> * update quickstart link Signed-off-by: Karol Szwaj <[email protected]> --------- Signed-off-by: Karol Szwaj <[email protected]> * docs: add provider guide for entra (#7977) * docs: add provider guide for entra Signed-off-by: Oliver Bähler <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * chore: clean up test output files (#8154) clean up test output files Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix: TCPRoute mTLS didn't work (#8152) * fix: remove auto HTTP config on TCP cluster Signed-off-by: zirain <[email protected]> * fix lint Signed-off-by: zirain <[email protected]> * add e2e Signed-off-by: zirain <[email protected]> * fix e2e Signed-off-by: zirain <[email protected]> * fix comment Signed-off-by: zirain <[email protected]> * fix Signed-off-by: zirain <[email protected]> * fix resource name Signed-off-by: zirain <[email protected]> * address Arko's comment Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * v1.7.0-rc2 release notes (#8163) * v1.7.0-rc2 release notes Signed-off-by: Karol Szwaj <[email protected]> * fix the date Signed-off-by: Karol Szwaj <[email protected]> --------- Signed-off-by: Karol Szwaj <[email protected]> --------- Signed-off-by: zirain <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> Signed-off-by: Adrian Cole <[email protected]> Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Dylan M. Taylor <[email protected]> Signed-off-by: Thierry Wandja <[email protected]> Signed-off-by: Guy Daich <[email protected]> Signed-off-by: Sadmi Bouhafs <[email protected]> Signed-off-by: Matt Miller <[email protected]> Signed-off-by: jaffar <[email protected]> Signed-off-by: Junnygram <[email protected]> Signed-off-by: Oliver Bähler <[email protected]> Co-authored-by: zirain <[email protected]> Co-authored-by: Adrian Cole <[email protected]> Co-authored-by: Huabing (Robin) Zhao <[email protected]> Co-authored-by: Dylan M. Taylor <[email protected]> Co-authored-by: Thierry Wandja <[email protected]> Co-authored-by: Guy Daich <[email protected]> Co-authored-by: Sadmi Bouhafs <[email protected]> Co-authored-by: Matt Miller <[email protected]> Co-authored-by: Isaac Wilson <[email protected]> Co-authored-by: jaffar keikei <[email protected]> Co-authored-by: Olaleye <[email protected]> Co-authored-by: Oliver Bähler <[email protected]>
Inode1
pushed a commit
to Inode1/gateway
that referenced
this pull request
Feb 23, 2026
envoyproxy#7953) * refactor: convert IR map fields to slices to ensure deterministic DeepEqual Addresses issue envoyproxy#7852. Signed-off-by: Junnygram <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix(test): make IR map comparison deterministic in runner tests
What this PR does / why we need it:
This PR fixes nondeterministic test behavior caused by using
reflect.DeepEqualon maps returned from
watchable.LoadAll()in runner tests.It introduces deterministic ordering helpers for XdsIR and InfraIR maps and
updates the runner tests to compare sorted results instead of raw maps.
This ensures stable and reliable test outcomes without changing any
production logic.
Which issue(s) this PR fixes:
Fixes #7783
Release Notes: No