fix: setting externalTrafficPolicy for NodePort service type#7823
Merged
zirain merged 1 commit intoenvoyproxy:mainfrom Dec 27, 2025
Merged
fix: setting externalTrafficPolicy for NodePort service type#7823zirain merged 1 commit intoenvoyproxy:mainfrom
zirain merged 1 commit intoenvoyproxy:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7823 +/- ##
==========================================
- Coverage 72.61% 72.60% -0.01%
==========================================
Files 235 235
Lines 34876 34879 +3
==========================================
- Hits 25325 25324 -1
- Misses 7745 7747 +2
- Partials 1806 1808 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rudrakhp
force-pushed
the
fix_etp_nodeport
branch
2 times, most recently
from
266872a to
dd8e912
Compare
Signed-off-by: Rudrakh Panigrahi <[email protected]>
rudrakhp
force-pushed
the
fix_etp_nodeport
branch
from
c7c58fe to
8c7e802
Compare
arkodg
approved these changes
Dec 26, 2025
zirain
approved these changes
Dec 27, 2025
millermatt
pushed a commit
to millermatt/envoy-gateway
that referenced
this pull request
Jan 4, 2026
…oxy#7823) Signed-off-by: Rudrakh Panigrahi <[email protected]> Signed-off-by: Matt Miller <[email protected]>
zirain
pushed a commit
to zirain/gateway
that referenced
this pull request
Jan 8, 2026
…oxy#7823) Signed-off-by: Rudrakh Panigrahi <[email protected]> Signed-off-by: zirain <[email protected]>
rudrakhp
added a commit
to rudrakhp/gateway
that referenced
this pull request
Jan 8, 2026
…oxy#7823) Signed-off-by: Rudrakh Panigrahi <[email protected]>
zirain
added a commit
that referenced
this pull request
Jan 9, 2026
* fix: set observedGeneration in envoy patch policy (#7715) * fix: set observedGeneration in envoy patch policy Signed-off-by: kkk777-7 <[email protected]> * add release note Signed-off-by: kkk777-7 <[email protected]> --------- Signed-off-by: kkk777-7 <[email protected]> Signed-off-by: zirain <[email protected]> * fix: add validation for request buffer limit (#7687) Signed-off-by: kkk777-7 <[email protected]> Signed-off-by: zirain <[email protected]> * fix: setting externalTrafficPolicy for NodePort service type (#7823) Signed-off-by: Rudrakh Panigrahi <[email protected]> Signed-off-by: zirain <[email protected]> * fix: make port-forward worked for OTel collector on port 19001 (#7860) Signed-off-by: zirain <[email protected]> * chore: fix goroutine leak (#7880) fix goroutine leak Signed-off-by: Huabing Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * fix gen Signed-off-by: zirain <[email protected]> * bump envoy to 1.35.8 Signed-off-by: zirain <[email protected]> --------- Signed-off-by: kkk777-7 <[email protected]> Signed-off-by: zirain <[email protected]> Signed-off-by: Rudrakh Panigrahi <[email protected]> Signed-off-by: Huabing Zhao <[email protected]> Co-authored-by: Kota Kimura <[email protected]> Co-authored-by: Rudrakh Panigrahi <[email protected]> Co-authored-by: Huabing (Robin) Zhao <[email protected]>
rudrakhp
added a commit
that referenced
this pull request
Jan 9, 2026
* fix: set observedGeneration in envoy patch policy (#7715) * fix: set observedGeneration in envoy patch policy Signed-off-by: kkk777-7 <[email protected]> * add release note Signed-off-by: kkk777-7 <[email protected]> --------- Signed-off-by: kkk777-7 <[email protected]> Signed-off-by: Rudrakh Panigrahi <[email protected]> * fix: add validation for request buffer limit (#7687) Signed-off-by: kkk777-7 <[email protected]> Signed-off-by: Rudrakh Panigrahi <[email protected]> * fix: nil pointer error when applying BackendTrafficPolicy to HTTPRoute with no backendRefs (#7765) * fix: checking route section name in backend traffic policy Signed-off-by: kkk777-7 <[email protected]> Signed-off-by: Rudrakh Panigrahi <[email protected]> * fix: setting externalTrafficPolicy for NodePort service type (#7823) Signed-off-by: Rudrakh Panigrahi <[email protected]> * fix: add indexing and processing for CRL references in ClientTrafficPolicies (#7829) Signed-off-by: Rudrakh Panigrahi <[email protected]> * feat: change the benchmark report to json format (#6818) * benchmark json output Signed-off-by: zirain <[email protected]> * fix Signed-off-by: zirain <[email protected]> * fix Signed-off-by: zirain <[email protected]> * fix lint Signed-off-by: zirain <[email protected]> * fix Signed-off-by: zirain <[email protected]> * revert Signed-off-by: zirain <[email protected]> * fix seconds Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> Signed-off-by: Rudrakh Panigrahi <[email protected]> * bechmark: scale up RPS to test data plane CPU performance (#7810) * Scale up RPS to test data plane CPU performance Signed-off-by: Huabing Zhao <[email protected]> * set duration to 120s Signed-off-by: Huabing Zhao <[email protected]> * discard invalid samples Signed-off-by: Huabing Zhao <[email protected]> * change scrape interval to 10s Signed-off-by: Huabing Zhao <[email protected]> * remove invalid cpu sampling data Signed-off-by: Huabing Zhao <[email protected]> * reduce duration to 60 Signed-off-by: Huabing Zhao <[email protected]> * fix benchmark end time Signed-off-by: Huabing Zhao <[email protected]> * fix data plane benchmark start time Signed-off-by: Huabing Zhao <[email protected]> * increase test time to get more samples Signed-off-by: Huabing Zhao <[email protected]> * adjust rps for each scale Signed-off-by: Huabing Zhao <[email protected]> * address comments Signed-off-by: Huabing(Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing Zhao <[email protected]> Signed-off-by: Huabing(Robin) Zhao <[email protected]> Signed-off-by: Rudrakh Panigrahi <[email protected]> * fix: make port-forward worked for OTel collector on port 19001 (#7860) Signed-off-by: zirain <[email protected]> Signed-off-by: Rudrakh Panigrahi <[email protected]> * chore: fix goroutine leak (#7880) fix goroutine leak Signed-off-by: Huabing Zhao <[email protected]> Signed-off-by: Rudrakh Panigrahi <[email protected]> * fix gen-check Signed-off-by: Rudrakh Panigrahi <[email protected]> --------- Signed-off-by: kkk777-7 <[email protected]> Signed-off-by: Rudrakh Panigrahi <[email protected]> Signed-off-by: zirain <[email protected]> Signed-off-by: Huabing Zhao <[email protected]> Signed-off-by: Huabing(Robin) Zhao <[email protected]> Co-authored-by: Kota Kimura <[email protected]> Co-authored-by: zirain <[email protected]> Co-authored-by: Huabing (Robin) Zhao <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
fix: setting externalTrafficPolicy for NodePort service type
What this PR does / why we need it:
ExternalTrafficPolicyis supported for bothLoadBalancerandNodePortservice types.Which issue(s) this PR fixes:
Fixes #7768
Release Notes: Yes