fix: set observedGeneration in envoy patch policy#7715
Merged
kkk777-7 merged 2 commits intoenvoyproxy:mainfrom Dec 13, 2025
Merged
fix: set observedGeneration in envoy patch policy#7715kkk777-7 merged 2 commits intoenvoyproxy:mainfrom
kkk777-7 merged 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: kkk777-7 <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7715 +/- ##
=======================================
Coverage 72.28% 72.29%
=======================================
Files 234 234
Lines 34480 34481 +1
=======================================
+ Hits 24924 24928 +4
+ Misses 7767 7764 -3
Partials 1789 1789 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kkk777-7
commented
Dec 10, 2025
| message: Patches have been successfully applied. | ||
| reason: Programmed | ||
| status: "True" | ||
| message: A patch operation must specify a path or jsonPath. |
Member
Author
There was a problem hiding this comment.
The changes in the xDS translate output message are likely due to modifying the processing order in translator_test.go to reflect the translation results in the policy status.
In the current code on the main branch, the test case for errMsg returns early.
https://github.com/envoyproxy/gateway/blob/main/internal/xds/translator/translator_test.go#L183-L191
Therefore, I assume that when the policy message was updated, the changes were not reflected in the test output.
Signed-off-by: kkk777-7 <[email protected]>
kkk777-7
force-pushed
the
fix-epp-status
branch
from
e99a920 to
661d494
Compare
Member
Author
|
/retest |
Member
|
/retest |
zirain
approved these changes
Dec 12, 2025
millermatt
pushed a commit
to millermatt/envoy-gateway
that referenced
this pull request
Jan 4, 2026
* fix: set observedGeneration in envoy patch policy Signed-off-by: kkk777-7 <[email protected]> * add release note Signed-off-by: kkk777-7 <[email protected]> --------- Signed-off-by: kkk777-7 <[email protected]> Signed-off-by: Matt Miller <[email protected]>
zirain
pushed a commit
to zirain/gateway
that referenced
this pull request
Jan 8, 2026
* fix: set observedGeneration in envoy patch policy Signed-off-by: kkk777-7 <[email protected]> * add release note Signed-off-by: kkk777-7 <[email protected]> --------- Signed-off-by: kkk777-7 <[email protected]> Signed-off-by: zirain <[email protected]>
rudrakhp
pushed a commit
to rudrakhp/gateway
that referenced
this pull request
Jan 8, 2026
* fix: set observedGeneration in envoy patch policy Signed-off-by: kkk777-7 <[email protected]> * add release note Signed-off-by: kkk777-7 <[email protected]> --------- Signed-off-by: kkk777-7 <[email protected]> Signed-off-by: Rudrakh Panigrahi <[email protected]>
zirain
added a commit
that referenced
this pull request
Jan 9, 2026
* fix: set observedGeneration in envoy patch policy (#7715) * fix: set observedGeneration in envoy patch policy Signed-off-by: kkk777-7 <[email protected]> * add release note Signed-off-by: kkk777-7 <[email protected]> --------- Signed-off-by: kkk777-7 <[email protected]> Signed-off-by: zirain <[email protected]> * fix: add validation for request buffer limit (#7687) Signed-off-by: kkk777-7 <[email protected]> Signed-off-by: zirain <[email protected]> * fix: setting externalTrafficPolicy for NodePort service type (#7823) Signed-off-by: Rudrakh Panigrahi <[email protected]> Signed-off-by: zirain <[email protected]> * fix: make port-forward worked for OTel collector on port 19001 (#7860) Signed-off-by: zirain <[email protected]> * chore: fix goroutine leak (#7880) fix goroutine leak Signed-off-by: Huabing Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * fix gen Signed-off-by: zirain <[email protected]> * bump envoy to 1.35.8 Signed-off-by: zirain <[email protected]> --------- Signed-off-by: kkk777-7 <[email protected]> Signed-off-by: zirain <[email protected]> Signed-off-by: Rudrakh Panigrahi <[email protected]> Signed-off-by: Huabing Zhao <[email protected]> Co-authored-by: Kota Kimura <[email protected]> Co-authored-by: Rudrakh Panigrahi <[email protected]> Co-authored-by: Huabing (Robin) Zhao <[email protected]>
rudrakhp
added a commit
that referenced
this pull request
Jan 9, 2026
* fix: set observedGeneration in envoy patch policy (#7715) * fix: set observedGeneration in envoy patch policy Signed-off-by: kkk777-7 <[email protected]> * add release note Signed-off-by: kkk777-7 <[email protected]> --------- Signed-off-by: kkk777-7 <[email protected]> Signed-off-by: Rudrakh Panigrahi <[email protected]> * fix: add validation for request buffer limit (#7687) Signed-off-by: kkk777-7 <[email protected]> Signed-off-by: Rudrakh Panigrahi <[email protected]> * fix: nil pointer error when applying BackendTrafficPolicy to HTTPRoute with no backendRefs (#7765) * fix: checking route section name in backend traffic policy Signed-off-by: kkk777-7 <[email protected]> Signed-off-by: Rudrakh Panigrahi <[email protected]> * fix: setting externalTrafficPolicy for NodePort service type (#7823) Signed-off-by: Rudrakh Panigrahi <[email protected]> * fix: add indexing and processing for CRL references in ClientTrafficPolicies (#7829) Signed-off-by: Rudrakh Panigrahi <[email protected]> * feat: change the benchmark report to json format (#6818) * benchmark json output Signed-off-by: zirain <[email protected]> * fix Signed-off-by: zirain <[email protected]> * fix Signed-off-by: zirain <[email protected]> * fix lint Signed-off-by: zirain <[email protected]> * fix Signed-off-by: zirain <[email protected]> * revert Signed-off-by: zirain <[email protected]> * fix seconds Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> Signed-off-by: Rudrakh Panigrahi <[email protected]> * bechmark: scale up RPS to test data plane CPU performance (#7810) * Scale up RPS to test data plane CPU performance Signed-off-by: Huabing Zhao <[email protected]> * set duration to 120s Signed-off-by: Huabing Zhao <[email protected]> * discard invalid samples Signed-off-by: Huabing Zhao <[email protected]> * change scrape interval to 10s Signed-off-by: Huabing Zhao <[email protected]> * remove invalid cpu sampling data Signed-off-by: Huabing Zhao <[email protected]> * reduce duration to 60 Signed-off-by: Huabing Zhao <[email protected]> * fix benchmark end time Signed-off-by: Huabing Zhao <[email protected]> * fix data plane benchmark start time Signed-off-by: Huabing Zhao <[email protected]> * increase test time to get more samples Signed-off-by: Huabing Zhao <[email protected]> * adjust rps for each scale Signed-off-by: Huabing Zhao <[email protected]> * address comments Signed-off-by: Huabing(Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing Zhao <[email protected]> Signed-off-by: Huabing(Robin) Zhao <[email protected]> Signed-off-by: Rudrakh Panigrahi <[email protected]> * fix: make port-forward worked for OTel collector on port 19001 (#7860) Signed-off-by: zirain <[email protected]> Signed-off-by: Rudrakh Panigrahi <[email protected]> * chore: fix goroutine leak (#7880) fix goroutine leak Signed-off-by: Huabing Zhao <[email protected]> Signed-off-by: Rudrakh Panigrahi <[email protected]> * fix gen-check Signed-off-by: Rudrakh Panigrahi <[email protected]> --------- Signed-off-by: kkk777-7 <[email protected]> Signed-off-by: Rudrakh Panigrahi <[email protected]> Signed-off-by: zirain <[email protected]> Signed-off-by: Huabing Zhao <[email protected]> Signed-off-by: Huabing(Robin) Zhao <[email protected]> Co-authored-by: Kota Kimura <[email protected]> Co-authored-by: zirain <[email protected]> Co-authored-by: Huabing (Robin) Zhao <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fixed that observedGeneration is missing from the EnvoyPatchPolicy status condition.
Introduce new field in IR to set observedGeneration.
Which issue(s) this PR fixes:
Fixes #7713
Release Notes: Yes