Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7364 +/- ##
==========================================
- Coverage 72.39% 72.33% -0.06%
==========================================
Files 231 231
Lines 33896 33896
==========================================
- Hits 24538 24520 -18
- Misses 7601 7615 +14
- Partials 1757 1761 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jukie
previously approved these changes
Oct 29, 2025
jukie
reviewed
Oct 29, 2025
| @@ -429,12 +429,12 @@ attribute such as [IP subnet][] in the future that are not relevant in the [HTTP | |||
| * A Status field within the RateLimitFilter API will be added to reflect whether the specific configuration was programmed correctly in these multiple locations or not. | |||
|
|
|||
| [PolicyAttachment]: https://gateway-api.sigs.k8s.io/references/policy-attachment/ | |||
Contributor
There was a problem hiding this comment.
Looks like references should be updated to reference. There's a redirect in place but that's what is causing issues.
Contributor
There was a problem hiding this comment.
Looks like I was wrong here and it's more tedious. A few links on the https://gateway-api.sigs.k8s.io site are also breaking in the same way.
Signed-off-by: zirain <[email protected]>
jukie
approved these changes
Oct 30, 2025
kkk777-7
approved these changes
Oct 30, 2025
Member
|
thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.