Rate Limiter: Enable rate limit for month and year#6715
Merged
arkodg merged 5 commits intoenvoyproxy:mainfrom Aug 6, 2025
Merged
Rate Limiter: Enable rate limit for month and year#6715arkodg merged 5 commits intoenvoyproxy:mainfrom
arkodg merged 5 commits intoenvoyproxy:mainfrom
Conversation
commoddity
changed the title
added 2 commits
August 6, 2025 11:59
Signed-off-by: Pascal van Leeuwen <[email protected]>
Signed-off-by: Pascal van Leeuwen <[email protected]>
commoddity
force-pushed
the
rate-limit-month-year
branch
from
c506b3d to
bbacb1a
Compare
Contributor
|
thanks for taking this forward @commoddity, |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #6715 +/- ##
==========================================
+ Coverage 71.04% 71.06% +0.02%
==========================================
Files 224 224
Lines 39615 39619 +4
==========================================
+ Hits 28144 28155 +11
+ Misses 9812 9806 -6
+ Partials 1659 1658 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
|
|
Signed-off-by: Pascal van Leeuwen <[email protected]>
Signed-off-by: Pascal van Leeuwen <[email protected]>
commoddity
force-pushed
the
rate-limit-month-year
branch
from
12113bf to
9a82610
Compare
Contributor
|
@commoddity can you rm the binaries added in the gateway-addons-helm path ? |
Contributor
Author
I've removed them. Sorry about that; seems it was something my local Helm did on its own. |
Signed-off-by: Pascal van Leeuwen <[email protected]>
commoddity
force-pushed
the
rate-limit-month-year
branch
from
0c0bd6c to
9d08fde
Compare
arkodg
approved these changes
Aug 6, 2025
guydc
approved these changes
Aug 6, 2025
zirain
pushed a commit
to zirain/gateway
that referenced
this pull request
Aug 8, 2025
* update go control plane rate limiter version Signed-off-by: Pascal van Leeuwen <[email protected]> * enable rate limit for month and year Signed-off-by: Pascal van Leeuwen <[email protected]> * add attribution Signed-off-by: Pascal van Leeuwen <[email protected]> * fix gen Signed-off-by: Pascal van Leeuwen <[email protected]> * remove helm binaries Signed-off-by: Pascal van Leeuwen <[email protected]> --------- Signed-off-by: Pascal van Leeuwen <[email protected]> Co-authored-by: Rico Pahlisch <[email protected]> Signed-off-by: zirain <[email protected]>
zirain
added a commit
that referenced
this pull request
Aug 8, 2025
* docs: rm latest from install egctl docs (#6700) * we've removed the latest egctl artifacts Relates to #6551 Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * chore: fix globalResources in GNM (#6701) Signed-off-by: zirain <[email protected]> * move ordering gateway-api resources to provider (#6695) Signed-off-by: zirain <[email protected]> * Rate Limiter: Enable rate limit for month and year (#6715) * update go control plane rate limiter version Signed-off-by: Pascal van Leeuwen <[email protected]> * enable rate limit for month and year Signed-off-by: Pascal van Leeuwen <[email protected]> * add attribution Signed-off-by: Pascal van Leeuwen <[email protected]> * fix gen Signed-off-by: Pascal van Leeuwen <[email protected]> * remove helm binaries Signed-off-by: Pascal van Leeuwen <[email protected]> --------- Signed-off-by: Pascal van Leeuwen <[email protected]> Co-authored-by: Rico Pahlisch <[email protected]> Signed-off-by: zirain <[email protected]> * docs: rm alpha alert for gateway namespace mode (#6709) Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * allow SNI and Cert SAN mismatch (#6719) Fixes: #6442 Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * chore(charts): update metadata for gateway-crds-helm (#6725) * chore(charts): update metadata for gateway-crds-helm Signed-off-by: Maxime Brunet <[email protected]> Signed-off-by: zirain <[email protected]> * chore: Don't render bootstrap local cluster if topologyInjector is disabled (#6718) * Consider topologyInjector when rendering bootstrap Signed-off-by: jukie <[email protected]> * Add logic to provider Signed-off-by: jukie <[email protected]> Signed-off-by: zirain <[email protected]> * remove nit log when Backend API is disabled (#6708) * remove nit log when Backend API is disabled Signed-off-by: zirain <[email protected]> * fix: EnvoyProxy image with digest is rejected (#6720) * fix: EnvoyProxy image with digest is rejected Signed-off-by: zirain <[email protected]> * Revert "feat: add listener metadata (#6639)" (#6727) This reverts commit 20cb68b. Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * docs: enhance extensibility index page (#6728) make it easier to pick the relevant extension type Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * docs: add docs explaining graceful shutdown (#6729) * docs: add docs explaining graceful shutdown fixes: #2686 Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * docs: ClusterTrustBundle Support in BackendTLSPolicy (#6714) Signed-off-by: zirain <[email protected]> * chore: bump go 1.24.6 (#6732) Signed-off-by: zirain <[email protected]> * [release-1.5] release-notes for v1.5.0 (#6731) * [release-1.5] release-notes for v1.5.0 Signed-off-by: zirain <[email protected]> * update compatibility matrix Signed-off-by: zirain <[email protected]> --------- Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> Signed-off-by: Pascal van Leeuwen <[email protected]> Signed-off-by: Maxime Brunet <[email protected]> Signed-off-by: jukie <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]> Co-authored-by: commoddity <[email protected]> Co-authored-by: Rico Pahlisch <[email protected]> Co-authored-by: Maxime Brunet <[email protected]> Co-authored-by: Isaac <[email protected]>
This was referenced Aug 13, 2025
zirain
added a commit
to zirain/gateway
that referenced
this pull request
Sep 16, 2025
* docs: rm latest from install egctl docs (envoyproxy#6700) * we've removed the latest egctl artifacts Relates to envoyproxy#6551 Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * chore: fix globalResources in GNM (envoyproxy#6701) Signed-off-by: zirain <[email protected]> * move ordering gateway-api resources to provider (envoyproxy#6695) Signed-off-by: zirain <[email protected]> * Rate Limiter: Enable rate limit for month and year (envoyproxy#6715) * update go control plane rate limiter version Signed-off-by: Pascal van Leeuwen <[email protected]> * enable rate limit for month and year Signed-off-by: Pascal van Leeuwen <[email protected]> * add attribution Signed-off-by: Pascal van Leeuwen <[email protected]> * fix gen Signed-off-by: Pascal van Leeuwen <[email protected]> * remove helm binaries Signed-off-by: Pascal van Leeuwen <[email protected]> --------- Signed-off-by: Pascal van Leeuwen <[email protected]> Co-authored-by: Rico Pahlisch <[email protected]> Signed-off-by: zirain <[email protected]> * docs: rm alpha alert for gateway namespace mode (envoyproxy#6709) Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * allow SNI and Cert SAN mismatch (envoyproxy#6719) Fixes: envoyproxy#6442 Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * chore(charts): update metadata for gateway-crds-helm (envoyproxy#6725) * chore(charts): update metadata for gateway-crds-helm Signed-off-by: Maxime Brunet <[email protected]> Signed-off-by: zirain <[email protected]> * chore: Don't render bootstrap local cluster if topologyInjector is disabled (envoyproxy#6718) * Consider topologyInjector when rendering bootstrap Signed-off-by: jukie <[email protected]> * Add logic to provider Signed-off-by: jukie <[email protected]> Signed-off-by: zirain <[email protected]> * remove nit log when Backend API is disabled (envoyproxy#6708) * remove nit log when Backend API is disabled Signed-off-by: zirain <[email protected]> * fix: EnvoyProxy image with digest is rejected (envoyproxy#6720) * fix: EnvoyProxy image with digest is rejected Signed-off-by: zirain <[email protected]> * Revert "feat: add listener metadata (envoyproxy#6639)" (envoyproxy#6727) This reverts commit 20cb68b. Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * docs: enhance extensibility index page (envoyproxy#6728) make it easier to pick the relevant extension type Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * docs: add docs explaining graceful shutdown (envoyproxy#6729) * docs: add docs explaining graceful shutdown fixes: envoyproxy#2686 Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * docs: ClusterTrustBundle Support in BackendTLSPolicy (envoyproxy#6714) Signed-off-by: zirain <[email protected]> * chore: bump go 1.24.6 (envoyproxy#6732) Signed-off-by: zirain <[email protected]> * [release-1.5] release-notes for v1.5.0 (envoyproxy#6731) * [release-1.5] release-notes for v1.5.0 Signed-off-by: zirain <[email protected]> * update compatibility matrix Signed-off-by: zirain <[email protected]> --------- Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> Signed-off-by: Pascal van Leeuwen <[email protected]> Signed-off-by: Maxime Brunet <[email protected]> Signed-off-by: jukie <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]> Co-authored-by: commoddity <[email protected]> Co-authored-by: Rico Pahlisch <[email protected]> Co-authored-by: Maxime Brunet <[email protected]> Co-authored-by: Isaac <[email protected]> Signed-off-by: zirain <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables month and year as rate limiting units in addition to the existing units.
Changes
Test Data
This enhancement allows users to configure rate limits with longer time windows, which is useful for scenarios requiring monthly or yearly quotas.
Fixes: Rate limiting with month and year units
🙌 NOTE 🙌
Thanks to @rpahli for the initial work on this PR which is the majority of the work done here; I just updated the
go-control-planewhich fixed the failing tests.