watchable: use Store directly instead of HandleStore wrapper by arkodg · Pull Request #6680 · envoyproxy/gateway

arkodg · 2025-08-02T17:20:03Z

GC is unable to collect the temporary references created in HandleStore

Here is some pprof data between v1.5.0-rc.1 and this PR

Running with 2000 HTTPRoutes
Agressive cacheSyncPeriod of 1m
T1 data is at 0m and T5 data is at 8m

Comparing T5 across 2 versions, there's a 19.93% decrease

$ go tool pprof -top -inuse_space -base v1.5.0-rc-profile/heap_profile_5_20250802_162916.pprof direct-store-profile/heap_profile_5_20250802_155443.pprof | grep Store
  536.37kB  0.26%  5.65%   536.33kB  0.26%  github.com/telepresenceio/watchable.(*Map[go.shape.struct { Namespace string; Name string },go.shape.*uint8]).unlockedStore
  512.19kB  0.25%  6.43%   512.19kB  0.25%  sigs.k8s.io/json/internal/golang/encoding/json.(*decodeState).literalStore
         0     0%  3.90% -40453.66kB 19.93%  github.com/envoyproxy/gateway/internal/message.HandleStore[go.shape.string,go.shape.*uint8]
         0     0%  3.90% -1024.14kB   0.5%  github.com/envoyproxy/gateway/internal/message.HandleStore[go.shape.struct { Namespace string; Name string },go.shape.*uint8]
         0     0%  3.90%  7685.33kB  3.79%  github.com/telepresenceio/watchable.(*Map[go.shape.string,go.shape.*uint8]).Store
         0     0%  3.90%  7685.33kB  3.79%  github.com/telepresenceio/watchable.(*Map[go.shape.string,go.shape.*uint8]).unlockedStore
         0     0%  3.90%   536.33kB  0.26%  github.com/telepresenceio/watchable.(*Map[go.shape.struct { Namespace string; Name string },go.shape.*uint8]).Store
         0     0%  3.90%   512.02kB  0.25%  internal/sync.(*HashTrieMap[go.shape.interface {},go.shape.interface {}]).LoadOrStore
         0     0%  3.90%   512.02kB  0.25%  sync.(*Map).LoadOrStore (inline)

Comparing T1 across 2 versions, there's a 18% decrease

$ go tool pprof -top -inuse_space -base v1.5.0-rc-profile/heap_profile_1_20250802_162116.pprof direct-store-profile/heap_profile_1_20250802_154643.pprof | grep Store
   549247B  0.25% 15.37%   1598151B  0.73%  github.com/telepresenceio/watchable.(*Map[go.shape.struct { Namespace string; Name string },go.shape.*uint8]).unlockedStore
   524668B  0.24% 16.61%   1048968B  0.48%  sigs.k8s.io/json/internal/golang/encoding/json.(*decodeState).literalStore
         0     0% 17.33% -41424572B 18.91%  github.com/envoyproxy/gateway/internal/message.HandleStore[go.shape.string,go.shape.*uint8]
         0     0% 17.33%  -1572968B  0.72%  github.com/envoyproxy/gateway/internal/message.HandleStore[go.shape.struct { Namespace string; Name string },go.shape.*uint8]
         0     0% 17.33%   9442726B  4.31%  github.com/telepresenceio/watchable.(*Map[go.shape.string,go.shape.*uint8]).Store
         0     0% 17.33%   9442726B  4.31%  github.com/telepresenceio/watchable.(*Map[go.shape.string,go.shape.*uint8]).unlockedStore
         0     0% 17.33%   1598151B  0.73%  github.com/telepresenceio/watchable.(*Map[go.shape.struct { Namespace string; Name string },go.shape.*uint8]).Store
         0     0% 17.33%    524312B  0.24%  internal/sync.(*HashTrieMap[go.shape.interface {},go.shape.interface {}]).LoadOrStore
         0     0% 17.33%    524312B  0.24%  sync.(*Map).LoadOrStore (inline)

In v1.5.0-rc.1, between T1 and T5 there's a 1% decrease


go tool pprof -top -inuse_space -base v1.5.0-rc-profile/heap_profile_1_20250802_162116.pprof v1.5.0-rc-profile/heap_profile_5_20250802_162916.pprof | grep Store
 1024.03kB  2.21% 11.63%  1024.03kB  2.21%  sigs.k8s.io/json/internal/golang/encoding/json.(*decodeState).literalStore
         0     0% 18.51%  -511.96kB  1.10%  github.com/envoyproxy/gateway/internal/message.HandleStore[go.shape.struct { Namespace string; Name string },go.shape.*uint8]
         0     0% 18.51%  -511.96kB  1.10%  github.com/telepresenceio/watchable.(*Map[go.shape.struct { Namespace string; Name string },go.shape.*uint8]).Store
         0     0% 18.51%  -511.96kB  1.10%  github.com/telepresenceio/watchable.(*Map[go.shape.struct { Namespace string; Name string },go.shape.*uint8]).unlockedStore

In current commit, between T1 and T5 there's a 2.92% decrease

$ go tool pprof -top -inuse_space -base direct-store-profile/heap_profile_1_20250802_154643.pprof direct-store-profile/heap_profile_5_20250802_155443.pprof | grep Store
       1MB  1.95% 36.86%     0.50MB  0.97%  sigs.k8s.io/json/internal/golang/encoding/json.(*decodeState).literalStore
         0     0% 37.16%    -1.50MB  2.92%  github.com/telepresenceio/watchable.(*Map[go.shape.string,go.shape.*uint8]).Store
         0     0% 37.16%    -1.50MB  2.92%  github.com/telepresenceio/watchable.(*Map[go.shape.string,go.shape.*uint8]).unlockedStore
         0     0% 37.16%    -1.50MB  2.92%  github.com/telepresenceio/watchable.(*Map[go.shape.struct { Namespace string; Name string },go.shape.*uint8]).Store
         0     0% 37.16%    -1.50MB  2.92%  github.com/telepresenceio/watchable.(*Map[go.shape.struct { Namespace string; Name string },go.shape.*uint8]).unlockedStore

Relates to #6406

codecov · 2025-08-02T17:42:00Z

Codecov Report

❌ Patch coverage is 13.55932% with 51 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.08%. Comparing base (aad1eba) to head (ea7a5bb).

Files with missing lines	Patch %	Lines
internal/gatewayapi/runner/runner.go	0.00%	45 Missing ⚠️
internal/provider/kubernetes/controller.go	33.33%	6 Missing ⚠️

❌ Your patch check has failed because the patch coverage (13.55%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6680      +/-   ##
==========================================
- Coverage   71.11%   71.08%   -0.04%     
==========================================
  Files         225      225              
  Lines       39555    39554       -1     
==========================================
- Hits        28128    28115      -13     
- Misses       9809     9818       +9     
- Partials     1618     1621       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

GC is unable to collect the temporary references created in `HandleStore` Relates to envoyproxy#6406 Signed-off-by: Arko Dasgupta <[email protected]>

Signed-off-by: Arko Dasgupta <[email protected]>

zirain · 2025-08-03T01:53:50Z

is there any way to avoid this happen again in the future?

arkodg · 2025-08-03T23:52:08Z

is there any way to avoid this happen again in the future?

We may need to run the benchmark test for longer with more triggers as a separate nightly test and watch for anomalies like memory rising without resources being added

…oxy#6680) * watchable: use Store directly instead of HandleStore wrapper GC is unable to collect the temporary references created in `HandleStore` Relates to envoyproxy#6406 Signed-off-by: Arko Dasgupta <[email protected]> * fix test Signed-off-by: Arko Dasgupta <[email protected]> --------- Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]>

* chore: cleanups from #6597 (#6647) Cleanup Signed-off-by: jukie <[email protected]> Signed-off-by: zirain <[email protected]> * fix: set order for grpc_web and grpc_stats filters (#6626) * set order for grpc_web and grpc_stats filters Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comment Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * fix: nil pointer when InsecureSkipVerify is true (#6652) * fix nil pointer when InsecureSkipVerify is true Signed-off-by: Huabing (Robin) Zhao <[email protected]> * add test Signed-off-by: Huabing (Robin) Zhao <[email protected]> * delete cacert for the xds translator test Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * fix: allow imageRepository contains port (#6658) (#6660) (cherry picked from commit c988ec5) Signed-off-by: Arko Dasgupta <[email protected]> Co-authored-by: 聪 <[email protected]> Signed-off-by: zirain <[email protected]> * docs: improve policy concepts section (#6663) better explain * targets * precedence * merge types Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * docs: observability pre req not required in admin console page (#6662) Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * docs: xds name scheme v2 (#6656) * name scheme v2 Signed-off-by: Huabing (Robin) Zhao <[email protected]> name scheme v2 Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comment Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comment Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * docs: highlight wait step (#6665) * docs: highlight wait step Signed-off-by: zirain <[email protected]> * update Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> * fix: populate status for custom backendRef not found (#6670) Signed-off-by: bitliu <[email protected]> Signed-off-by: zirain <[email protected]> * fix: xds name schema v2 (#6638) * rename route config Signed-off-by: Huabing (Robin) Zhao <[email protected]> * rename HCM statPrefix Signed-off-by: Huabing (Robin) Zhao <[email protected]> * rename virtual host Signed-off-by: Huabing (Robin) Zhao <[email protected]> * fix test Signed-off-by: Huabing (Robin) Zhao <[email protected]> * minor change Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comment Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * docs: expand Gateway Namespace Mode doc on client/server auth (#6616) * Expand Gateway Namespace Mode doc on client/server auth Signed-off-by: Karol Szwaj <[email protected]> * Add additional explanation to the overview Signed-off-by: Karol Szwaj <[email protected]> --------- Signed-off-by: Karol Szwaj <[email protected]> Signed-off-by: zirain <[email protected]> * increase earlyRequestHeaders from 16 to 64 (#6673) * created a new definition of HTTPFilterHeader that supports 64 items for `set`, `add`, and `remove` * sanitizing request headers from untrusted downstream traffic is a common use case and 16 items may not be adequate enough at times. This action needs to be performed route processing for cases and the HTTPRoute filters cannot be used Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * docs: skipping TLS verification (#6653) * docs for skipping TLS verification Signed-off-by: Huabing (Robin) Zhao <[email protected]> * remove btlsp for skiptlsverify Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comment Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comment Signed-off-by: Huabing (Robin) Zhao <[email protected]> * remove public Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * feat: add listener metadata (#6639) * add listener metadata Signed-off-by: Huabing (Robin) Zhao <[email protected]> * remove sort Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * fix: Fix BTP ZoneAware translation (#6668) * Fix BTP ZoneAware translation Signed-off-by: jukie <[email protected]> * Add e2e Signed-off-by: jukie <[email protected]> --------- Signed-off-by: jukie <[email protected]> Signed-off-by: zirain <[email protected]> * docs: unhide zoneaware api for docs (#6683) unhide api docs Signed-off-by: jukie <[email protected]> Signed-off-by: zirain <[email protected]> * watchable: use Store directly instead of HandleStore wrapper (#6680) * watchable: use Store directly instead of HandleStore wrapper GC is unable to collect the temporary references created in `HandleStore` Relates to #6406 Signed-off-by: Arko Dasgupta <[email protected]> * fix test Signed-off-by: Arko Dasgupta <[email protected]> --------- Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * docs: Update Zone Aware Routing for BackendTrafficPolicy configuration example (#6667) Update zone aware routing docs Signed-off-by: jukie <[email protected]> Signed-off-by: zirain <[email protected]> * combine the xds-translator and xds-server runner into one (#6586) * combine the xds-translator and xds-server into one xds runner * primarily to reduce memory and convergence time Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * build(deps): bump the gomod group across 1 directory with 6 updates (#6691) * build(deps): bump the gomod group across 1 directory with 6 updates Bumps the gomod group with 4 updates in the / directory: [github.com/miekg/dns](https://github.com/miekg/dns), [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang), [github.com/quic-go/quic-go](https://github.com/quic-go/quic-go) and [go.opentelemetry.io/proto/otlp](https://github.com/open-telemetry/opentelemetry-proto-go). Updates `github.com/miekg/dns` from 1.1.67 to 1.1.68 - [Changelog](https://github.com/miekg/dns/blob/master/Makefile.release) - [Commits](miekg/dns@v1.1.67...v1.1.68) Updates `github.com/prometheus/client_golang` from 1.22.0 to 1.23.0 - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.22.0...v1.23.0) Updates `github.com/quic-go/quic-go` from 0.52.0 to 0.54.0 - [Release notes](https://github.com/quic-go/quic-go/releases) - [Commits](quic-go/quic-go@v0.52.0...v0.54.0) Updates `go.opentelemetry.io/proto/otlp` from 1.7.0 to 1.7.1 - [Release notes](https://github.com/open-telemetry/opentelemetry-proto-go/releases) - [Commits](open-telemetry/opentelemetry-proto-go@v1.7.0...v1.7.1) Updates `google.golang.org/genproto/googleapis/api` from 0.0.0-20250603155806-513f23925822 to 0.0.0-20250728155136-f173205681a0 - [Commits](https://github.com/googleapis/go-genproto/commits) Updates `google.golang.org/genproto/googleapis/rpc` from 0.0.0-20250603155806-513f23925822 to 0.0.0-20250728155136-f173205681a0 - [Commits](https://github.com/googleapis/go-genproto/commits) --- updated-dependencies: - dependency-name: github.com/miekg/dns dependency-version: 1.1.68 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gomod - dependency-name: github.com/prometheus/client_golang dependency-version: 1.23.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gomod - dependency-name: github.com/quic-go/quic-go dependency-version: 0.54.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gomod - dependency-name: go.opentelemetry.io/proto/otlp dependency-version: 1.7.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gomod - dependency-name: google.golang.org/genproto/googleapis/api dependency-version: 0.0.0-20250728155136-f173205681a0 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gomod - dependency-name: google.golang.org/genproto/googleapis/rpc dependency-version: 0.0.0-20250728155136-f173205681a0 dependency-type: indirect update-type: version-update:semver-patch dependency-group: gomod ... Signed-off-by: dependabot[bot] <[email protected]> * fix gen Signed-off-by: zirain <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: zirain <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: zirain <[email protected]> Signed-off-by: zirain <[email protected]> * fix: controller panic when reloading config (#6688) * fix controller panic when reloading config Signed-off-by: zirain <[email protected]> * use gwapiv1.Duration instead of metav1.Duration (#6664) * use gwapiv1.Duration instead of metav1.Duration fixes: #4746 Signed-off-by: Arko Dasgupta <[email protected]> * add charts Signed-off-by: Arko Dasgupta <[email protected]> * go back to metav1 in IR to make YAML tests happy Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * fix: don't block deployment creating when missing secret in EnvoyProxy (#6692) * fix: don't block deployment creating when missing secret in EnvoyProxy Signed-off-by: zirain <[email protected]> * [release/v1.5] release notes for rc.2 (#6697) * [release/v1.5] release notes for rc.2 Signed-off-by: zirain <[email protected]> --------- Signed-off-by: jukie <[email protected]> Signed-off-by: zirain <[email protected]> Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: bitliu <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Isaac <[email protected]> Co-authored-by: Huabing (Robin) Zhao <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]> Co-authored-by: 聪 <[email protected]> Co-authored-by: Xunzhuo <[email protected]> Co-authored-by: Karol Szwaj <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: cleanups from envoyproxy#6597 (envoyproxy#6647) Cleanup Signed-off-by: jukie <[email protected]> Signed-off-by: zirain <[email protected]> * fix: set order for grpc_web and grpc_stats filters (envoyproxy#6626) * set order for grpc_web and grpc_stats filters Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comment Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * fix: nil pointer when InsecureSkipVerify is true (envoyproxy#6652) * fix nil pointer when InsecureSkipVerify is true Signed-off-by: Huabing (Robin) Zhao <[email protected]> * add test Signed-off-by: Huabing (Robin) Zhao <[email protected]> * delete cacert for the xds translator test Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * fix: allow imageRepository contains port (envoyproxy#6658) (envoyproxy#6660) (cherry picked from commit c988ec5) Signed-off-by: Arko Dasgupta <[email protected]> Co-authored-by: 聪 <[email protected]> Signed-off-by: zirain <[email protected]> * docs: improve policy concepts section (envoyproxy#6663) better explain * targets * precedence * merge types Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * docs: observability pre req not required in admin console page (envoyproxy#6662) Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * docs: xds name scheme v2 (envoyproxy#6656) * name scheme v2 Signed-off-by: Huabing (Robin) Zhao <[email protected]> name scheme v2 Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comment Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comment Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * docs: highlight wait step (envoyproxy#6665) * docs: highlight wait step Signed-off-by: zirain <[email protected]> * update Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> * fix: populate status for custom backendRef not found (envoyproxy#6670) Signed-off-by: bitliu <[email protected]> Signed-off-by: zirain <[email protected]> * fix: xds name schema v2 (envoyproxy#6638) * rename route config Signed-off-by: Huabing (Robin) Zhao <[email protected]> * rename HCM statPrefix Signed-off-by: Huabing (Robin) Zhao <[email protected]> * rename virtual host Signed-off-by: Huabing (Robin) Zhao <[email protected]> * fix test Signed-off-by: Huabing (Robin) Zhao <[email protected]> * minor change Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comment Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * docs: expand Gateway Namespace Mode doc on client/server auth (envoyproxy#6616) * Expand Gateway Namespace Mode doc on client/server auth Signed-off-by: Karol Szwaj <[email protected]> * Add additional explanation to the overview Signed-off-by: Karol Szwaj <[email protected]> --------- Signed-off-by: Karol Szwaj <[email protected]> Signed-off-by: zirain <[email protected]> * increase earlyRequestHeaders from 16 to 64 (envoyproxy#6673) * created a new definition of HTTPFilterHeader that supports 64 items for `set`, `add`, and `remove` * sanitizing request headers from untrusted downstream traffic is a common use case and 16 items may not be adequate enough at times. This action needs to be performed route processing for cases and the HTTPRoute filters cannot be used Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * docs: skipping TLS verification (envoyproxy#6653) * docs for skipping TLS verification Signed-off-by: Huabing (Robin) Zhao <[email protected]> * remove btlsp for skiptlsverify Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comment Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comment Signed-off-by: Huabing (Robin) Zhao <[email protected]> * remove public Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * feat: add listener metadata (envoyproxy#6639) * add listener metadata Signed-off-by: Huabing (Robin) Zhao <[email protected]> * remove sort Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * fix: Fix BTP ZoneAware translation (envoyproxy#6668) * Fix BTP ZoneAware translation Signed-off-by: jukie <[email protected]> * Add e2e Signed-off-by: jukie <[email protected]> --------- Signed-off-by: jukie <[email protected]> Signed-off-by: zirain <[email protected]> * docs: unhide zoneaware api for docs (envoyproxy#6683) unhide api docs Signed-off-by: jukie <[email protected]> Signed-off-by: zirain <[email protected]> * watchable: use Store directly instead of HandleStore wrapper (envoyproxy#6680) * watchable: use Store directly instead of HandleStore wrapper GC is unable to collect the temporary references created in `HandleStore` Relates to envoyproxy#6406 Signed-off-by: Arko Dasgupta <[email protected]> * fix test Signed-off-by: Arko Dasgupta <[email protected]> --------- Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * docs: Update Zone Aware Routing for BackendTrafficPolicy configuration example (envoyproxy#6667) Update zone aware routing docs Signed-off-by: jukie <[email protected]> Signed-off-by: zirain <[email protected]> * combine the xds-translator and xds-server runner into one (envoyproxy#6586) * combine the xds-translator and xds-server into one xds runner * primarily to reduce memory and convergence time Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * build(deps): bump the gomod group across 1 directory with 6 updates (envoyproxy#6691) * build(deps): bump the gomod group across 1 directory with 6 updates Bumps the gomod group with 4 updates in the / directory: [github.com/miekg/dns](https://github.com/miekg/dns), [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang), [github.com/quic-go/quic-go](https://github.com/quic-go/quic-go) and [go.opentelemetry.io/proto/otlp](https://github.com/open-telemetry/opentelemetry-proto-go). Updates `github.com/miekg/dns` from 1.1.67 to 1.1.68 - [Changelog](https://github.com/miekg/dns/blob/master/Makefile.release) - [Commits](miekg/dns@v1.1.67...v1.1.68) Updates `github.com/prometheus/client_golang` from 1.22.0 to 1.23.0 - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.22.0...v1.23.0) Updates `github.com/quic-go/quic-go` from 0.52.0 to 0.54.0 - [Release notes](https://github.com/quic-go/quic-go/releases) - [Commits](quic-go/quic-go@v0.52.0...v0.54.0) Updates `go.opentelemetry.io/proto/otlp` from 1.7.0 to 1.7.1 - [Release notes](https://github.com/open-telemetry/opentelemetry-proto-go/releases) - [Commits](open-telemetry/opentelemetry-proto-go@v1.7.0...v1.7.1) Updates `google.golang.org/genproto/googleapis/api` from 0.0.0-20250603155806-513f23925822 to 0.0.0-20250728155136-f173205681a0 - [Commits](https://github.com/googleapis/go-genproto/commits) Updates `google.golang.org/genproto/googleapis/rpc` from 0.0.0-20250603155806-513f23925822 to 0.0.0-20250728155136-f173205681a0 - [Commits](https://github.com/googleapis/go-genproto/commits) --- updated-dependencies: - dependency-name: github.com/miekg/dns dependency-version: 1.1.68 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gomod - dependency-name: github.com/prometheus/client_golang dependency-version: 1.23.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gomod - dependency-name: github.com/quic-go/quic-go dependency-version: 0.54.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gomod - dependency-name: go.opentelemetry.io/proto/otlp dependency-version: 1.7.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gomod - dependency-name: google.golang.org/genproto/googleapis/api dependency-version: 0.0.0-20250728155136-f173205681a0 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gomod - dependency-name: google.golang.org/genproto/googleapis/rpc dependency-version: 0.0.0-20250728155136-f173205681a0 dependency-type: indirect update-type: version-update:semver-patch dependency-group: gomod ... Signed-off-by: dependabot[bot] <[email protected]> * fix gen Signed-off-by: zirain <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: zirain <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: zirain <[email protected]> Signed-off-by: zirain <[email protected]> * fix: controller panic when reloading config (envoyproxy#6688) * fix controller panic when reloading config Signed-off-by: zirain <[email protected]> * use gwapiv1.Duration instead of metav1.Duration (envoyproxy#6664) * use gwapiv1.Duration instead of metav1.Duration fixes: envoyproxy#4746 Signed-off-by: Arko Dasgupta <[email protected]> * add charts Signed-off-by: Arko Dasgupta <[email protected]> * go back to metav1 in IR to make YAML tests happy Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * fix: don't block deployment creating when missing secret in EnvoyProxy (envoyproxy#6692) * fix: don't block deployment creating when missing secret in EnvoyProxy Signed-off-by: zirain <[email protected]> * [release/v1.5] release notes for rc.2 (envoyproxy#6697) * [release/v1.5] release notes for rc.2 Signed-off-by: zirain <[email protected]> --------- Signed-off-by: jukie <[email protected]> Signed-off-by: zirain <[email protected]> Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: bitliu <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Isaac <[email protected]> Co-authored-by: Huabing (Robin) Zhao <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]> Co-authored-by: 聪 <[email protected]> Co-authored-by: Xunzhuo <[email protected]> Co-authored-by: Karol Szwaj <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: zirain <[email protected]>

arkodg requested a review from a team as a code owner August 2, 2025 17:20

arkodg added this to the v1.5.0 Release milestone Aug 2, 2025

arkodg marked this pull request as draft August 2, 2025 18:13

arkodg marked this pull request as ready for review August 3, 2025 00:32

Arko Dasgupta added 2 commits August 3, 2025 09:52

watchable: use Store directly instead of HandleStore wrapper

0d7271a

GC is unable to collect the temporary references created in `HandleStore` Relates to envoyproxy#6406 Signed-off-by: Arko Dasgupta <[email protected]>

fix test

ea7a5bb

Signed-off-by: Arko Dasgupta <[email protected]>

zirain force-pushed the use-direct-store branch from 83880ad to ea7a5bb Compare August 3, 2025 01:52

guydc approved these changes Aug 3, 2025

View reviewed changes

zirain approved these changes Aug 3, 2025

View reviewed changes

Merge branch 'main' into use-direct-store

85a3f21

arkodg merged commit 7c47af0 into envoyproxy:main Aug 3, 2025
9 checks passed

arkodg deleted the use-direct-store branch August 3, 2025 23:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

watchable: use Store directly instead of HandleStore wrapper#6680

watchable: use Store directly instead of HandleStore wrapper#6680
arkodg merged 3 commits intoenvoyproxy:mainfrom
arkodg:use-direct-store

arkodg commented Aug 2, 2025 •

edited

Loading

Uh oh!

codecov bot commented Aug 2, 2025 •

edited

Loading

Uh oh!

zirain commented Aug 3, 2025

Uh oh!

arkodg commented Aug 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

arkodg commented Aug 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Aug 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

zirain commented Aug 3, 2025

Uh oh!

arkodg commented Aug 3, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

arkodg commented Aug 2, 2025 •

edited

Loading

codecov bot commented Aug 2, 2025 •

edited

Loading