feat(translator): add store metric by guydc · Pull Request #6406 · envoyproxy/gateway

guydc · 2025-06-25T20:24:41Z

What type of PR is this?

What this PR does / why we need it:

Adds a new metric for publish events: watchable_publish_total.

EG currently records metrics for the subscriber side. The watchable queues may coalesce and drop certain updates sent to subscribers. Users may also want to track the count of store events, in order to understand if certain layers are publishing updates successfully.

Which issue(s) this PR fixes:

Release Notes: Yes

codecov · 2025-06-25T20:34:05Z

Codecov Report

Attention: Patch coverage is 26.22951% with 90 lines in your changes missing coverage. Please review.

Project coverage is 70.68%. Comparing base (b8ca958) to head (4e67c93).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/gatewayapi/runner/runner.go	1.28%	77 Missing ⚠️
internal/provider/kubernetes/controller.go	33.33%	10 Missing ⚠️
internal/infrastructure/runner/runner.go	0.00%	1 Missing ⚠️
internal/provider/kubernetes/status.go	93.33%	1 Missing ⚠️
internal/xds/server/runner/runner.go	0.00%	1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (26.22%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6406      +/-   ##
==========================================
- Coverage   70.76%   70.68%   -0.08%     
==========================================
  Files         220      220              
  Lines       37595    37675      +80     
==========================================
+ Hits        26603    26632      +29     
- Misses       9429     9482      +53     
+ Partials     1563     1561       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

arkodg · 2025-06-26T16:31:00Z

internal/gatewayapi/runner/runner.go

can we use r.Name() instead ?

reg Message, can we add a Name helper to https://github.com/envoyproxy/gateway/blob/main/internal/message/types.go ?

Xunzhuo · 2025-07-09T09:55:52Z

internal/message/watchutil.go

Here it is, overall looks good to me! Thanks for the code polish as well

Xunzhuo · 2025-07-09T09:56:27Z

Looks like there are some conflicts..

Signed-off-by: Guy Daich <[email protected]>

* add store metric Signed-off-by: Guy Daich <[email protected]> * add naming helper, use runner.name, add test Signed-off-by: Guy Daich <[email protected]> Signed-off-by: Tjeerd Jan van der Molen <[email protected]>

GC is unable to collect the temporary references created in `HandleStore` Relates to envoyproxy#6406 Signed-off-by: Arko Dasgupta <[email protected]>

* watchable: use Store directly instead of HandleStore wrapper GC is unable to collect the temporary references created in `HandleStore` Relates to #6406 Signed-off-by: Arko Dasgupta <[email protected]> * fix test Signed-off-by: Arko Dasgupta <[email protected]> --------- Signed-off-by: Arko Dasgupta <[email protected]>

…oxy#6680) * watchable: use Store directly instead of HandleStore wrapper GC is unable to collect the temporary references created in `HandleStore` Relates to envoyproxy#6406 Signed-off-by: Arko Dasgupta <[email protected]> * fix test Signed-off-by: Arko Dasgupta <[email protected]> --------- Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]>

* chore: cleanups from #6597 (#6647) Cleanup Signed-off-by: jukie <[email protected]> Signed-off-by: zirain <[email protected]> * fix: set order for grpc_web and grpc_stats filters (#6626) * set order for grpc_web and grpc_stats filters Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comment Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * fix: nil pointer when InsecureSkipVerify is true (#6652) * fix nil pointer when InsecureSkipVerify is true Signed-off-by: Huabing (Robin) Zhao <[email protected]> * add test Signed-off-by: Huabing (Robin) Zhao <[email protected]> * delete cacert for the xds translator test Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * fix: allow imageRepository contains port (#6658) (#6660) (cherry picked from commit c988ec5) Signed-off-by: Arko Dasgupta <[email protected]> Co-authored-by: 聪 <[email protected]> Signed-off-by: zirain <[email protected]> * docs: improve policy concepts section (#6663) better explain * targets * precedence * merge types Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * docs: observability pre req not required in admin console page (#6662) Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * docs: xds name scheme v2 (#6656) * name scheme v2 Signed-off-by: Huabing (Robin) Zhao <[email protected]> name scheme v2 Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comment Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comment Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * docs: highlight wait step (#6665) * docs: highlight wait step Signed-off-by: zirain <[email protected]> * update Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> * fix: populate status for custom backendRef not found (#6670) Signed-off-by: bitliu <[email protected]> Signed-off-by: zirain <[email protected]> * fix: xds name schema v2 (#6638) * rename route config Signed-off-by: Huabing (Robin) Zhao <[email protected]> * rename HCM statPrefix Signed-off-by: Huabing (Robin) Zhao <[email protected]> * rename virtual host Signed-off-by: Huabing (Robin) Zhao <[email protected]> * fix test Signed-off-by: Huabing (Robin) Zhao <[email protected]> * minor change Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comment Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * docs: expand Gateway Namespace Mode doc on client/server auth (#6616) * Expand Gateway Namespace Mode doc on client/server auth Signed-off-by: Karol Szwaj <[email protected]> * Add additional explanation to the overview Signed-off-by: Karol Szwaj <[email protected]> --------- Signed-off-by: Karol Szwaj <[email protected]> Signed-off-by: zirain <[email protected]> * increase earlyRequestHeaders from 16 to 64 (#6673) * created a new definition of HTTPFilterHeader that supports 64 items for `set`, `add`, and `remove` * sanitizing request headers from untrusted downstream traffic is a common use case and 16 items may not be adequate enough at times. This action needs to be performed route processing for cases and the HTTPRoute filters cannot be used Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * docs: skipping TLS verification (#6653) * docs for skipping TLS verification Signed-off-by: Huabing (Robin) Zhao <[email protected]> * remove btlsp for skiptlsverify Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comment Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comment Signed-off-by: Huabing (Robin) Zhao <[email protected]> * remove public Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * feat: add listener metadata (#6639) * add listener metadata Signed-off-by: Huabing (Robin) Zhao <[email protected]> * remove sort Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * fix: Fix BTP ZoneAware translation (#6668) * Fix BTP ZoneAware translation Signed-off-by: jukie <[email protected]> * Add e2e Signed-off-by: jukie <[email protected]> --------- Signed-off-by: jukie <[email protected]> Signed-off-by: zirain <[email protected]> * docs: unhide zoneaware api for docs (#6683) unhide api docs Signed-off-by: jukie <[email protected]> Signed-off-by: zirain <[email protected]> * watchable: use Store directly instead of HandleStore wrapper (#6680) * watchable: use Store directly instead of HandleStore wrapper GC is unable to collect the temporary references created in `HandleStore` Relates to #6406 Signed-off-by: Arko Dasgupta <[email protected]> * fix test Signed-off-by: Arko Dasgupta <[email protected]> --------- Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * docs: Update Zone Aware Routing for BackendTrafficPolicy configuration example (#6667) Update zone aware routing docs Signed-off-by: jukie <[email protected]> Signed-off-by: zirain <[email protected]> * combine the xds-translator and xds-server runner into one (#6586) * combine the xds-translator and xds-server into one xds runner * primarily to reduce memory and convergence time Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * build(deps): bump the gomod group across 1 directory with 6 updates (#6691) * build(deps): bump the gomod group across 1 directory with 6 updates Bumps the gomod group with 4 updates in the / directory: [github.com/miekg/dns](https://github.com/miekg/dns), [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang), [github.com/quic-go/quic-go](https://github.com/quic-go/quic-go) and [go.opentelemetry.io/proto/otlp](https://github.com/open-telemetry/opentelemetry-proto-go). Updates `github.com/miekg/dns` from 1.1.67 to 1.1.68 - [Changelog](https://github.com/miekg/dns/blob/master/Makefile.release) - [Commits](miekg/dns@v1.1.67...v1.1.68) Updates `github.com/prometheus/client_golang` from 1.22.0 to 1.23.0 - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.22.0...v1.23.0) Updates `github.com/quic-go/quic-go` from 0.52.0 to 0.54.0 - [Release notes](https://github.com/quic-go/quic-go/releases) - [Commits](quic-go/quic-go@v0.52.0...v0.54.0) Updates `go.opentelemetry.io/proto/otlp` from 1.7.0 to 1.7.1 - [Release notes](https://github.com/open-telemetry/opentelemetry-proto-go/releases) - [Commits](open-telemetry/opentelemetry-proto-go@v1.7.0...v1.7.1) Updates `google.golang.org/genproto/googleapis/api` from 0.0.0-20250603155806-513f23925822 to 0.0.0-20250728155136-f173205681a0 - [Commits](https://github.com/googleapis/go-genproto/commits) Updates `google.golang.org/genproto/googleapis/rpc` from 0.0.0-20250603155806-513f23925822 to 0.0.0-20250728155136-f173205681a0 - [Commits](https://github.com/googleapis/go-genproto/commits) --- updated-dependencies: - dependency-name: github.com/miekg/dns dependency-version: 1.1.68 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gomod - dependency-name: github.com/prometheus/client_golang dependency-version: 1.23.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gomod - dependency-name: github.com/quic-go/quic-go dependency-version: 0.54.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gomod - dependency-name: go.opentelemetry.io/proto/otlp dependency-version: 1.7.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gomod - dependency-name: google.golang.org/genproto/googleapis/api dependency-version: 0.0.0-20250728155136-f173205681a0 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gomod - dependency-name: google.golang.org/genproto/googleapis/rpc dependency-version: 0.0.0-20250728155136-f173205681a0 dependency-type: indirect update-type: version-update:semver-patch dependency-group: gomod ... Signed-off-by: dependabot[bot] <[email protected]> * fix gen Signed-off-by: zirain <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: zirain <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: zirain <[email protected]> Signed-off-by: zirain <[email protected]> * fix: controller panic when reloading config (#6688) * fix controller panic when reloading config Signed-off-by: zirain <[email protected]> * use gwapiv1.Duration instead of metav1.Duration (#6664) * use gwapiv1.Duration instead of metav1.Duration fixes: #4746 Signed-off-by: Arko Dasgupta <[email protected]> * add charts Signed-off-by: Arko Dasgupta <[email protected]> * go back to metav1 in IR to make YAML tests happy Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * fix: don't block deployment creating when missing secret in EnvoyProxy (#6692) * fix: don't block deployment creating when missing secret in EnvoyProxy Signed-off-by: zirain <[email protected]> * [release/v1.5] release notes for rc.2 (#6697) * [release/v1.5] release notes for rc.2 Signed-off-by: zirain <[email protected]> --------- Signed-off-by: jukie <[email protected]> Signed-off-by: zirain <[email protected]> Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: bitliu <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Isaac <[email protected]> Co-authored-by: Huabing (Robin) Zhao <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]> Co-authored-by: 聪 <[email protected]> Co-authored-by: Xunzhuo <[email protected]> Co-authored-by: Karol Szwaj <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* chore: cleanups from envoyproxy#6597 (envoyproxy#6647) Cleanup Signed-off-by: jukie <[email protected]> Signed-off-by: zirain <[email protected]> * fix: set order for grpc_web and grpc_stats filters (envoyproxy#6626) * set order for grpc_web and grpc_stats filters Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comment Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * fix: nil pointer when InsecureSkipVerify is true (envoyproxy#6652) * fix nil pointer when InsecureSkipVerify is true Signed-off-by: Huabing (Robin) Zhao <[email protected]> * add test Signed-off-by: Huabing (Robin) Zhao <[email protected]> * delete cacert for the xds translator test Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * fix: allow imageRepository contains port (envoyproxy#6658) (envoyproxy#6660) (cherry picked from commit c988ec5) Signed-off-by: Arko Dasgupta <[email protected]> Co-authored-by: 聪 <[email protected]> Signed-off-by: zirain <[email protected]> * docs: improve policy concepts section (envoyproxy#6663) better explain * targets * precedence * merge types Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * docs: observability pre req not required in admin console page (envoyproxy#6662) Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * docs: xds name scheme v2 (envoyproxy#6656) * name scheme v2 Signed-off-by: Huabing (Robin) Zhao <[email protected]> name scheme v2 Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comment Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comment Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * docs: highlight wait step (envoyproxy#6665) * docs: highlight wait step Signed-off-by: zirain <[email protected]> * update Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> * fix: populate status for custom backendRef not found (envoyproxy#6670) Signed-off-by: bitliu <[email protected]> Signed-off-by: zirain <[email protected]> * fix: xds name schema v2 (envoyproxy#6638) * rename route config Signed-off-by: Huabing (Robin) Zhao <[email protected]> * rename HCM statPrefix Signed-off-by: Huabing (Robin) Zhao <[email protected]> * rename virtual host Signed-off-by: Huabing (Robin) Zhao <[email protected]> * fix test Signed-off-by: Huabing (Robin) Zhao <[email protected]> * minor change Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comment Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * docs: expand Gateway Namespace Mode doc on client/server auth (envoyproxy#6616) * Expand Gateway Namespace Mode doc on client/server auth Signed-off-by: Karol Szwaj <[email protected]> * Add additional explanation to the overview Signed-off-by: Karol Szwaj <[email protected]> --------- Signed-off-by: Karol Szwaj <[email protected]> Signed-off-by: zirain <[email protected]> * increase earlyRequestHeaders from 16 to 64 (envoyproxy#6673) * created a new definition of HTTPFilterHeader that supports 64 items for `set`, `add`, and `remove` * sanitizing request headers from untrusted downstream traffic is a common use case and 16 items may not be adequate enough at times. This action needs to be performed route processing for cases and the HTTPRoute filters cannot be used Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * docs: skipping TLS verification (envoyproxy#6653) * docs for skipping TLS verification Signed-off-by: Huabing (Robin) Zhao <[email protected]> * remove btlsp for skiptlsverify Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comment Signed-off-by: Huabing (Robin) Zhao <[email protected]> * address comment Signed-off-by: Huabing (Robin) Zhao <[email protected]> * remove public Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * feat: add listener metadata (envoyproxy#6639) * add listener metadata Signed-off-by: Huabing (Robin) Zhao <[email protected]> * remove sort Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: zirain <[email protected]> * fix: Fix BTP ZoneAware translation (envoyproxy#6668) * Fix BTP ZoneAware translation Signed-off-by: jukie <[email protected]> * Add e2e Signed-off-by: jukie <[email protected]> --------- Signed-off-by: jukie <[email protected]> Signed-off-by: zirain <[email protected]> * docs: unhide zoneaware api for docs (envoyproxy#6683) unhide api docs Signed-off-by: jukie <[email protected]> Signed-off-by: zirain <[email protected]> * watchable: use Store directly instead of HandleStore wrapper (envoyproxy#6680) * watchable: use Store directly instead of HandleStore wrapper GC is unable to collect the temporary references created in `HandleStore` Relates to envoyproxy#6406 Signed-off-by: Arko Dasgupta <[email protected]> * fix test Signed-off-by: Arko Dasgupta <[email protected]> --------- Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * docs: Update Zone Aware Routing for BackendTrafficPolicy configuration example (envoyproxy#6667) Update zone aware routing docs Signed-off-by: jukie <[email protected]> Signed-off-by: zirain <[email protected]> * combine the xds-translator and xds-server runner into one (envoyproxy#6586) * combine the xds-translator and xds-server into one xds runner * primarily to reduce memory and convergence time Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * build(deps): bump the gomod group across 1 directory with 6 updates (envoyproxy#6691) * build(deps): bump the gomod group across 1 directory with 6 updates Bumps the gomod group with 4 updates in the / directory: [github.com/miekg/dns](https://github.com/miekg/dns), [github.com/prometheus/client_golang](https://github.com/prometheus/client_golang), [github.com/quic-go/quic-go](https://github.com/quic-go/quic-go) and [go.opentelemetry.io/proto/otlp](https://github.com/open-telemetry/opentelemetry-proto-go). Updates `github.com/miekg/dns` from 1.1.67 to 1.1.68 - [Changelog](https://github.com/miekg/dns/blob/master/Makefile.release) - [Commits](miekg/dns@v1.1.67...v1.1.68) Updates `github.com/prometheus/client_golang` from 1.22.0 to 1.23.0 - [Release notes](https://github.com/prometheus/client_golang/releases) - [Changelog](https://github.com/prometheus/client_golang/blob/main/CHANGELOG.md) - [Commits](prometheus/client_golang@v1.22.0...v1.23.0) Updates `github.com/quic-go/quic-go` from 0.52.0 to 0.54.0 - [Release notes](https://github.com/quic-go/quic-go/releases) - [Commits](quic-go/quic-go@v0.52.0...v0.54.0) Updates `go.opentelemetry.io/proto/otlp` from 1.7.0 to 1.7.1 - [Release notes](https://github.com/open-telemetry/opentelemetry-proto-go/releases) - [Commits](open-telemetry/opentelemetry-proto-go@v1.7.0...v1.7.1) Updates `google.golang.org/genproto/googleapis/api` from 0.0.0-20250603155806-513f23925822 to 0.0.0-20250728155136-f173205681a0 - [Commits](https://github.com/googleapis/go-genproto/commits) Updates `google.golang.org/genproto/googleapis/rpc` from 0.0.0-20250603155806-513f23925822 to 0.0.0-20250728155136-f173205681a0 - [Commits](https://github.com/googleapis/go-genproto/commits) --- updated-dependencies: - dependency-name: github.com/miekg/dns dependency-version: 1.1.68 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gomod - dependency-name: github.com/prometheus/client_golang dependency-version: 1.23.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gomod - dependency-name: github.com/quic-go/quic-go dependency-version: 0.54.0 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: gomod - dependency-name: go.opentelemetry.io/proto/otlp dependency-version: 1.7.1 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gomod - dependency-name: google.golang.org/genproto/googleapis/api dependency-version: 0.0.0-20250728155136-f173205681a0 dependency-type: direct:production update-type: version-update:semver-patch dependency-group: gomod - dependency-name: google.golang.org/genproto/googleapis/rpc dependency-version: 0.0.0-20250728155136-f173205681a0 dependency-type: indirect update-type: version-update:semver-patch dependency-group: gomod ... Signed-off-by: dependabot[bot] <[email protected]> * fix gen Signed-off-by: zirain <[email protected]> --------- Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: zirain <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: zirain <[email protected]> Signed-off-by: zirain <[email protected]> * fix: controller panic when reloading config (envoyproxy#6688) * fix controller panic when reloading config Signed-off-by: zirain <[email protected]> * use gwapiv1.Duration instead of metav1.Duration (envoyproxy#6664) * use gwapiv1.Duration instead of metav1.Duration fixes: envoyproxy#4746 Signed-off-by: Arko Dasgupta <[email protected]> * add charts Signed-off-by: Arko Dasgupta <[email protected]> * go back to metav1 in IR to make YAML tests happy Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: zirain <[email protected]> * fix: don't block deployment creating when missing secret in EnvoyProxy (envoyproxy#6692) * fix: don't block deployment creating when missing secret in EnvoyProxy Signed-off-by: zirain <[email protected]> * [release/v1.5] release notes for rc.2 (envoyproxy#6697) * [release/v1.5] release notes for rc.2 Signed-off-by: zirain <[email protected]> --------- Signed-off-by: jukie <[email protected]> Signed-off-by: zirain <[email protected]> Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: bitliu <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Isaac <[email protected]> Co-authored-by: Huabing (Robin) Zhao <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]> Co-authored-by: 聪 <[email protected]> Co-authored-by: Xunzhuo <[email protected]> Co-authored-by: Karol Szwaj <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: zirain <[email protected]>

arkodg reviewed Jun 26, 2025

View reviewed changes

guydc marked this pull request as ready for review June 26, 2025 23:44

guydc requested a review from a team as a code owner June 26, 2025 23:44

guydc requested a review from arkodg June 27, 2025 13:12

zirain previously approved these changes Jul 1, 2025

View reviewed changes

arkodg requested a review from Xunzhuo July 1, 2025 00:59

arkodg added this to the v1.5.0-rc.1 Release milestone Jul 8, 2025

Xunzhuo previously approved these changes Jul 9, 2025

View reviewed changes

internal/message/watchutil.go Outdated

Copy link
Copy Markdown

Member

Xunzhuo Jul 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here it is, overall looks good to me! Thanks for the code polish as well

guydc added 3 commits July 9, 2025 12:41

add store metric

dabe2fb

Signed-off-by: Guy Daich <[email protected]>

add naming helper, use runner.name, add test

0078e78

Signed-off-by: Guy Daich <[email protected]>

updates

2511ca6

Signed-off-by: Guy Daich <[email protected]>

guydc dismissed stale reviews from Xunzhuo and zirain via 2511ca6 July 9, 2025 17:58

guydc force-pushed the pub-metrics branch from 748b6e3 to 2511ca6 Compare July 9, 2025 17:58

Merge branch 'main' into pub-metrics

4e67c93

Signed-off-by: Guy Daich <[email protected]>

arkodg approved these changes Jul 9, 2025

View reviewed changes

arkodg merged commit 1737078 into envoyproxy:main Jul 9, 2025
30 of 31 checks passed

arkodg mentioned this pull request Aug 2, 2025

watchable: use Store directly instead of HandleStore wrapper #6680

Merged

BrewTestBot mentioned this pull request Aug 8, 2025

egctl 1.5.0 Homebrew/homebrew-core#232799

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(translator): add store metric#6406

feat(translator): add store metric#6406
arkodg merged 4 commits intoenvoyproxy:mainfrom
guydc:pub-metrics

guydc commented Jun 25, 2025

Uh oh!

codecov bot commented Jun 25, 2025 •

edited

Loading

Uh oh!

arkodg Jun 26, 2025

Uh oh!

Xunzhuo Jul 9, 2025

Uh oh!

Xunzhuo commented Jul 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

guydc commented Jun 25, 2025

Uh oh!

codecov bot commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

arkodg Jun 26, 2025

Choose a reason for hiding this comment

Uh oh!

Xunzhuo Jul 9, 2025

Choose a reason for hiding this comment

Uh oh!

Xunzhuo commented Jul 9, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Jun 25, 2025 •

edited

Loading