Skip to content

fix: add configMap indexers for EEP reconciler#6369

Merged
zirain merged 1 commit intoenvoyproxy:mainfrom
rudrakhp:eep_cm_indexers
Jun 24, 2025
Merged

fix: add configMap indexers for EEP reconciler#6369
zirain merged 1 commit intoenvoyproxy:mainfrom
rudrakhp:eep_cm_indexers

Conversation

@rudrakhp
Copy link
Copy Markdown
Member

What type of PR is this?

fix: add configMap indexers for EEP reconciler

What this PR does / why we need it:

Updating the EEP Lua ConfigMap doesn't update the Lua filter applied to proxy. Tested this change locally and now updates seem to be reflecting.

Which issue(s) this PR fixes:

Fixes #6356

Release Notes: Yes

@rudrakhp rudrakhp requested a review from a team as a code owner June 21, 2025 08:44
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 21, 2025

Codecov Report

Attention: Patch coverage is 77.27273% with 10 lines in your changes missing coverage. Please review.

Project coverage is 70.86%. Comparing base (96d5062) to head (9f33ec4).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
internal/provider/kubernetes/indexers.go 72.72% 4 Missing and 2 partials ⚠️
internal/provider/kubernetes/predicates.go 63.63% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6369      +/-   ##
==========================================
+ Coverage   70.79%   70.86%   +0.07%     
==========================================
  Files         220      220              
  Lines       37088    37132      +44     
==========================================
+ Hits        26255    26315      +60     
+ Misses       9294     9279      -15     
+ Partials     1539     1538       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@rudrakhp rudrakhp added this to the v1.5.0-rc.1 Release milestone Jun 23, 2025
@rudrakhp rudrakhp requested review from a team and removed request for a team June 23, 2025 13:54
Copy link
Copy Markdown
Contributor

@arkodg arkodg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@zirain zirain enabled auto-merge (squash) June 24, 2025 01:15
@zirain zirain merged commit a03b857 into envoyproxy:main Jun 24, 2025
28 checks passed
shawnh2 pushed a commit to shawnh2/gateway that referenced this pull request Jul 2, 2025
zhaohuabing added a commit that referenced this pull request Jul 4, 2025
* fix(translator): ext-proc full duplex streamed trailers and validation (#6323)
* fix ext proc validation and trailer management for full duplex streamed mode

Signed-off-by: Guy Daich <[email protected]>
Signed-off-by: shawnh2 <[email protected]>

* feat: disable automountServiceAccountToken for proxy and ratelimit (#6364)

Signed-off-by: Jeff Davis <[email protected]>

* bugfix: make EnvoyPatchPolicy able to replace telemetry cluster (#6367)

Signed-off-by: zirain <[email protected]>
Signed-off-by: shawnh2 <[email protected]>

* feat: add validation of section name for Gateway listener (#6343)

* add validation of section name

Signed-off-by: kkk777-7 <[email protected]>

* update error status reason

Signed-off-by: kkk777-7 <[email protected]>

* refactor: define as function of validate section name for gateway listener

Signed-off-by: kkk777-7 <[email protected]>
Signed-off-by: shawnh2 <[email protected]>

* fix: add configMap indexers for EEP reconciler (#6369)

Signed-off-by: Rudrakh Panigrahi <[email protected]>

* fix: use buildEndpointType for access and tracing (#6370)

Signed-off-by: zirain <[email protected]>

* fix: default accesslog not working (#6441)
* fix default accesslog

Signed-off-by: zirain <[email protected]>

* release notes

Signed-off-by: zirain <[email protected]>

---------

Signed-off-by: zirain <[email protected]>
Signed-off-by: shawnh2 <[email protected]>

* chore: fix cve (#6446)

* fix cve

Signed-off-by: zirain <[email protected]>

* lint

Signed-off-by: zirain <[email protected]>

---------

Signed-off-by: zirain <[email protected]>

* fix: Do not set backendRequestTimeout when Retries are set (#6421)

* fix: Do not set backendRequestTimeout when Retries are set

Signed-off-by: sudipto baral <[email protected]>

* fix: update comment

Signed-off-by: sudipto baral <[email protected]>

---------

Signed-off-by: sudipto baral <[email protected]>

* gatewayapi: don't append gwcResource if there's invalid GatewayClass (#6379)

* gatewayapi: don't process gloabal resources when acceptedGateways is 0

Signed-off-by: zirain <[email protected]>

* update

Signed-off-by: zirain <[email protected]>

* fix test

Signed-off-by: zirain <[email protected]>

* don't skip gateways

Signed-off-by: zirain <[email protected]>

---------

Signed-off-by: zirain <[email protected]>
Signed-off-by: shawnh2 <[email protected]>

* fix testdata

Signed-off-by: shawnh2 <[email protected]>

* fix k8s provider controller

Signed-off-by: shawnh2 <[email protected]>

* fix: retry reconcile on transient errors during reconcile  (#6299)

* fix: add isTransientError helper to classify retryable errors

Introduces isTransientError to detect transient Kubernetes errors and
enable proper reconciliation retries.

Signed-off-by: Patryk Rostkowski <[email protected]>

handle errors from processing BackendRefs

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

handle errors from processing ConfigMap

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

* skip invalid GatewayClass

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

* address comment

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

* handle all transient errors

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

* don't skip failed GCs

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

---------

Signed-off-by: Patryk Rostkowski <[email protected]>
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Co-authored-by: Huabing (Robin) Zhao <[email protected]>
(cherry picked from commit 71ce56f)
Signed-off-by: Huabing (Robin) Zhao <[email protected]>

* fix: fix bug in hostname overlap detection (#6332)

fix bug in hostname overlap detection

Signed-off-by: Rudrakh Panigrahi <[email protected]>
(cherry picked from commit e78e268)
Signed-off-by: Huabing (Robin) Zhao <[email protected]>

* fix telemetry with host port not working (#6460)

Signed-off-by: zirain <[email protected]>
(cherry picked from commit c0a2ce7)
Signed-off-by: Huabing (Robin) Zhao <[email protected]>

* bugfix: BackendTlsPolicy should not reference across namespace (#6309)

* bugfix: BackendTlsPolicy should not reference across namespace

Signed-off-by: zirain <[email protected]>
(cherry picked from commit 9925189)
Signed-off-by: Huabing (Robin) Zhao <[email protected]>

---------

Signed-off-by: Guy Daich <[email protected]>
Signed-off-by: shawnh2 <[email protected]>
Signed-off-by: Jeff Davis <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: kkk777-7 <[email protected]>
Signed-off-by: Rudrakh Panigrahi <[email protected]>
Signed-off-by: sudipto baral <[email protected]>
Signed-off-by: Patryk Rostkowski <[email protected]>
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Co-authored-by: Guy Daich <[email protected]>
Co-authored-by: Jeff Davis <[email protected]>
Co-authored-by: zirain <[email protected]>
Co-authored-by: Kota Kimura <[email protected]>
Co-authored-by: Rudrakh Panigrahi <[email protected]>
Co-authored-by: Sudipto Baral <[email protected]>
Co-authored-by: Patryk Rostkowski <[email protected]>
Co-authored-by: Huabing (Robin) Zhao <[email protected]>
shawnh2 added a commit to shawnh2/gateway that referenced this pull request Sep 15, 2025
* fix(translator): ext-proc full duplex streamed trailers and validation (envoyproxy#6323)
* fix ext proc validation and trailer management for full duplex streamed mode

Signed-off-by: Guy Daich <[email protected]>
Signed-off-by: shawnh2 <[email protected]>

* feat: disable automountServiceAccountToken for proxy and ratelimit (envoyproxy#6364)

Signed-off-by: Jeff Davis <[email protected]>

* bugfix: make EnvoyPatchPolicy able to replace telemetry cluster (envoyproxy#6367)

Signed-off-by: zirain <[email protected]>
Signed-off-by: shawnh2 <[email protected]>

* feat: add validation of section name for Gateway listener (envoyproxy#6343)

* add validation of section name

Signed-off-by: kkk777-7 <[email protected]>

* update error status reason

Signed-off-by: kkk777-7 <[email protected]>

* refactor: define as function of validate section name for gateway listener

Signed-off-by: kkk777-7 <[email protected]>
Signed-off-by: shawnh2 <[email protected]>

* fix: add configMap indexers for EEP reconciler (envoyproxy#6369)

Signed-off-by: Rudrakh Panigrahi <[email protected]>

* fix: use buildEndpointType for access and tracing (envoyproxy#6370)

Signed-off-by: zirain <[email protected]>

* fix: default accesslog not working (envoyproxy#6441)
* fix default accesslog

Signed-off-by: zirain <[email protected]>

* release notes

Signed-off-by: zirain <[email protected]>

---------

Signed-off-by: zirain <[email protected]>
Signed-off-by: shawnh2 <[email protected]>

* chore: fix cve (envoyproxy#6446)

* fix cve

Signed-off-by: zirain <[email protected]>

* lint

Signed-off-by: zirain <[email protected]>

---------

Signed-off-by: zirain <[email protected]>

* fix: Do not set backendRequestTimeout when Retries are set (envoyproxy#6421)

* fix: Do not set backendRequestTimeout when Retries are set

Signed-off-by: sudipto baral <[email protected]>

* fix: update comment

Signed-off-by: sudipto baral <[email protected]>

---------

Signed-off-by: sudipto baral <[email protected]>

* gatewayapi: don't append gwcResource if there's invalid GatewayClass (envoyproxy#6379)

* gatewayapi: don't process gloabal resources when acceptedGateways is 0

Signed-off-by: zirain <[email protected]>

* update

Signed-off-by: zirain <[email protected]>

* fix test

Signed-off-by: zirain <[email protected]>

* don't skip gateways

Signed-off-by: zirain <[email protected]>

---------

Signed-off-by: zirain <[email protected]>
Signed-off-by: shawnh2 <[email protected]>

* fix testdata

Signed-off-by: shawnh2 <[email protected]>

* fix k8s provider controller

Signed-off-by: shawnh2 <[email protected]>

* fix: retry reconcile on transient errors during reconcile  (envoyproxy#6299)

* fix: add isTransientError helper to classify retryable errors

Introduces isTransientError to detect transient Kubernetes errors and
enable proper reconciliation retries.

Signed-off-by: Patryk Rostkowski <[email protected]>

handle errors from processing BackendRefs

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

handle errors from processing ConfigMap

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

* skip invalid GatewayClass

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

* address comment

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

* handle all transient errors

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

* don't skip failed GCs

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

---------

Signed-off-by: Patryk Rostkowski <[email protected]>
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Co-authored-by: Huabing (Robin) Zhao <[email protected]>
(cherry picked from commit 71ce56f)
Signed-off-by: Huabing (Robin) Zhao <[email protected]>

* fix: fix bug in hostname overlap detection (envoyproxy#6332)

fix bug in hostname overlap detection

Signed-off-by: Rudrakh Panigrahi <[email protected]>
(cherry picked from commit e78e268)
Signed-off-by: Huabing (Robin) Zhao <[email protected]>

* fix telemetry with host port not working (envoyproxy#6460)

Signed-off-by: zirain <[email protected]>
(cherry picked from commit c0a2ce7)
Signed-off-by: Huabing (Robin) Zhao <[email protected]>

* bugfix: BackendTlsPolicy should not reference across namespace (envoyproxy#6309)

* bugfix: BackendTlsPolicy should not reference across namespace

Signed-off-by: zirain <[email protected]>
(cherry picked from commit 9925189)
Signed-off-by: Huabing (Robin) Zhao <[email protected]>

---------

Signed-off-by: Guy Daich <[email protected]>
Signed-off-by: shawnh2 <[email protected]>
Signed-off-by: Jeff Davis <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: kkk777-7 <[email protected]>
Signed-off-by: Rudrakh Panigrahi <[email protected]>
Signed-off-by: sudipto baral <[email protected]>
Signed-off-by: Patryk Rostkowski <[email protected]>
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Co-authored-by: Guy Daich <[email protected]>
Co-authored-by: Jeff Davis <[email protected]>
Co-authored-by: zirain <[email protected]>
Co-authored-by: Kota Kimura <[email protected]>
Co-authored-by: Rudrakh Panigrahi <[email protected]>
Co-authored-by: Sudipto Baral <[email protected]>
Co-authored-by: Patryk Rostkowski <[email protected]>
Co-authored-by: Huabing (Robin) Zhao <[email protected]>
Signed-off-by: shawnh2 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ConfigMaps for LUA extensions are not watched

3 participants