thanks for flagging this @y-rabie, instead of disabling replicas, can we add templating to unset it ? and add a doc strin in the hpa section to recommend users to do so ?

@arkodg I'm not exactly sure what you mean by adding templating to unset it 😅 Do you mean leaving things as is and recommending to the users setting the replicas value to null when HPA is enabled?

if we added a doc string in the hpa section to comment out replicas

deployment:
  envoyGateway:
  .......
  # replicas: 1

could something like this be used in the template to avoid setting the replica ?

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

Any updates here?

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

if we added a doc string in the hpa section to comment out replicas

deployment:
  envoyGateway:
  .......
  # replicas: 1

could something like this be used in the template to avoid setting the replica ?

If I understand the comment correctly then no, not with the current template. If we set replicas: null in the helm values it will still render, which means ArgoCD (and other GitOps tool) will track and own this field. We have to not render it at all so that the HPA can own the field without triggering an out-of-sync and fight the GitOps tool.

@sherifabdlnaby will something like this work ?

+  {{- if hasKey (default (dict) .Values.deployment) "replicas" }}
   replicas: {{ .Values.deployment.replicas }}
+  {{- end }}

This pull request has been automatically marked as stale because it has not had activity in the last 30 days. Please feel free to give a status update now, ping for review, when it's ready. Thank you for your contributions!

Did this ever get merged into a release? I am still seeing this issue with Argo. Any update on this?

@y-rabie are you still working on this? if not, @proximix feel free to send another.