Skip to content

fix: add FullDuplexStreamed to enum#6103

Merged
arkodg merged 3 commits intoenvoyproxy:mainfrom
guydc:fix-cel-extproc
May 16, 2025
Merged

fix: add FullDuplexStreamed to enum#6103
arkodg merged 3 commits intoenvoyproxy:mainfrom
guydc:fix-cel-extproc

Conversation

@guydc
Copy link
Copy Markdown
Contributor

@guydc guydc commented May 16, 2025

What type of PR is this?

What this PR does / why we need it:
FullDuplexStreamed was added in #5349. However, the enum was still missing that option, creating CEL validation issues.

Which issue(s) this PR fixes:

Fixes #

Release Notes: Yes/No

@guydc guydc requested a review from a team as a code owner May 16, 2025 22:52
@arkodg arkodg requested review from a team May 16, 2025 22:59
@arkodg
Copy link
Copy Markdown
Contributor

arkodg commented May 16, 2025

cc @kfswain

@codecov
Copy link
Copy Markdown

codecov bot commented May 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.40%. Comparing base (1cd11c5) to head (c030d06).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6103   +/-   ##
=======================================
  Coverage   70.39%   70.40%           
=======================================
  Files         217      217           
  Lines       36128    36128           
=======================================
+ Hits        25433    25435    +2     
+ Misses       9176     9174    -2     
  Partials     1519     1519           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arkodg arkodg merged commit 020d60a into envoyproxy:main May 16, 2025
27 checks passed
@arkodg arkodg added the kind/bug Something isn't working label May 16, 2025
arkodg pushed a commit to arkodg/gateway that referenced this pull request Jun 3, 2025
* fix: add FullDuplexStreamed to enum

Signed-off-by: Guy Daich <[email protected]>
(cherry picked from commit 020d60a)
Signed-off-by: Arko Dasgupta <[email protected]>
arkodg added a commit that referenced this pull request Jun 4, 2025
* feat: set OverlappingTLSConfig condition for merged Gateways (#5862)

* set OverlappingTLSConfig condition for merged Gateways

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

* fix lint

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

* minor change

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

---------

Signed-off-by: Huabing (Robin) Zhao <[email protected]>
(cherry picked from commit be51e5b)
Signed-off-by: Arko Dasgupta <[email protected]>

* e2e: fix backend tls test (#6029)

* fix backend tls test

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

* enable backend tls test

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

* remove gateway TLS to simplify the test

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

* rename secret to avoid conflicts

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

---------

Signed-off-by: Huabing (Robin) Zhao <[email protected]>
(cherry picked from commit a685667)
Signed-off-by: Arko Dasgupta <[email protected]>

* validate gateway namespace mode and merged gateways (#6041)

* validate gateway namespace mode and merged gateways in translator

Signed-off-by: Karol Szwaj <[email protected]>

* fix lint

Signed-off-by: Karol Szwaj <[email protected]>

* skip merge gateways test

Signed-off-by: Karol Szwaj <[email protected]>

* validate on gatewayclass and set the status

Signed-off-by: Karol Szwaj <[email protected]>

* skip e2e test

Signed-off-by: Karol Szwaj <[email protected]>

* add valid testcases

Signed-off-by: Karol Szwaj <[email protected]>

* Update internal/provider/kubernetes/controller.go

Co-authored-by: Arko Dasgupta <[email protected]>
Signed-off-by: Karol Szwaj <[email protected]>

* fix lint

Signed-off-by: Karol Szwaj <[email protected]>

* skip merge gateways test

Signed-off-by: Karol Szwaj <[email protected]>

* rebase

Signed-off-by: Karol Szwaj <[email protected]>

---------

Signed-off-by: Karol Szwaj <[email protected]>
Co-authored-by: zirain <[email protected]>
Co-authored-by: Arko Dasgupta <[email protected]>
(cherry picked from commit c5f6831)
Signed-off-by: Arko Dasgupta <[email protected]>

* Fix shared=true when no clientSelector, (#6072)

* Fix shared=true when no clientSelector, cleanup filter logic, fix rl descriptor logic

Signed-off-by: Ryan Hristovski <[email protected]>

* testdata update

Signed-off-by: Ryan Hristovski <[email protected]>

* Linting, remove unused funcs

Signed-off-by: Ryan Hristovski <[email protected]>

* fix e2e

Signed-off-by: Ryan Hristovski <[email protected]>
(cherry picked from commit bb3c8da)
Signed-off-by: Arko Dasgupta <[email protected]>

* fix(tranlator): SubjectAltNames were being dropped from BackendTLSPolicy.validation (#6092)

* Add support for SubjectAltNames from BackendTLSPolicy.validation

Signed-off-by: Ankush Agarwal <[email protected]>
(cherry picked from commit 35420d5)
Signed-off-by: Arko Dasgupta <[email protected]>

* feat: add ownerreference to infra resources when gateway namespace mode (#6100)

* feat: add ownerreference to infra resources when gateway namespace mode

Signed-off-by: kkk777-7 <[email protected]>
(cherry picked from commit fc462a8)
Signed-off-by: Arko Dasgupta <[email protected]>

* fix: add FullDuplexStreamed to enum (#6103)

* fix: add FullDuplexStreamed to enum

Signed-off-by: Guy Daich <[email protected]>
(cherry picked from commit 020d60a)
Signed-off-by: Arko Dasgupta <[email protected]>

* fix: Use quoted values zone annotation in topology injector (#6133)

* Quoted string for zone values

Signed-off-by: jukie <[email protected]>

* release note

Signed-off-by: jukie <[email protected]>

* regen

Signed-off-by: jukie <[email protected]>
(cherry picked from commit ea9cb05)
Signed-off-by: Arko Dasgupta <[email protected]>

* fix: return early from buildwasms (#6169)

return early from buildwasms

Signed-off-by: Guy Daich <[email protected]>
(cherry picked from commit 64624fe)
Signed-off-by: Arko Dasgupta <[email protected]>

* chore: bump go and purego (#6174)

* chore: bump go and purego

Signed-off-by: zirain <[email protected]>

* fix  gen

Signed-off-by: zirain <[email protected]>

---------

Signed-off-by: zirain <[email protected]>
(cherry picked from commit 40ae9e3)
Signed-off-by: Arko Dasgupta <[email protected]>

* fix: translate xds udp listener (#6183)

* fix: translate udp listener

Signed-off-by: kkk777-7 <[email protected]>

* add: tcp/udp no routes testdata in xds translator

Signed-off-by: kkk777-7 <[email protected]>

* add: release note

Signed-off-by: kkk777-7 <[email protected]>
(cherry picked from commit 8f538e7)
Signed-off-by: Arko Dasgupta <[email protected]>

* Change static uid to  for global ratelimit dashboard (#6193)

Signed-off-by: Emin Aktas <[email protected]>
(cherry picked from commit f721925)
Signed-off-by: Arko Dasgupta <[email protected]>

* Fix broken btp ratelimit merge (#6214)

* Fix broken btp ratelimit merge

Signed-off-by: Ryan Hristovski <[email protected]>

* lint

Signed-off-by: Ryan Hristovski <[email protected]>

---------

Signed-off-by: Ryan Hristovski <[email protected]>
(cherry picked from commit 0f6f363)
Signed-off-by: Arko Dasgupta <[email protected]>

* Keep ALPN configuration for listeners with overlapping certificates when ALPN is explicitly set via ClientTrafficPolicy (#6217)

Keep ALPN configuration for listeners with overlapping certificates when ALPN is explicitly set in ClientTrafficPolicy

Signed-off-by: Huabing (Robin) Zhao <[email protected]>
(cherry picked from commit de816a6)
Signed-off-by: Arko Dasgupta <[email protected]>

* fix testdata

Signed-off-by: Arko Dasgupta <[email protected]>

* Allow for headless envoy services (#6250)

* Allow for headless envoy services

Signed-off-by: Ryan Hristovski <[email protected]>

* Allow headless service, cleanup

Signed-off-by: Ryan Hristovski <[email protected]>

* clean

Signed-off-by: Ryan Hristovski <[email protected]>

* Add test and comment

Signed-off-by: Ryan Hristovski <[email protected]>

* Fix tests

Signed-off-by: Ryan Hristovski <[email protected]>
(cherry picked from commit 2e168a8)
Signed-off-by: Arko Dasgupta <[email protected]>

* remove infra ENVOY_GATEWAY_NAMESPACE and introduce ENVOY_POD_NAMESPACE envVar for accesslog (#6221)

* remove infra ENVOY_GATEWAY_NAMESPACE and introduce ENVOY_POD_NAMESPACE envVar for accesslog

Signed-off-by: Karol Szwaj <[email protected]>

* fix e2e test

Signed-off-by: Karol Szwaj <[email protected]>

---------

Signed-off-by: Karol Szwaj <[email protected]>
(cherry picked from commit b7ed197)
Signed-off-by: Arko Dasgupta <[email protected]>

* fix lint

Signed-off-by: Arko Dasgupta <[email protected]>

---------

Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: Karol Szwaj <[email protected]>
Signed-off-by: Ryan Hristovski <[email protected]>
Signed-off-by: Ankush Agarwal <[email protected]>
Signed-off-by: kkk777-7 <[email protected]>
Signed-off-by: Guy Daich <[email protected]>
Signed-off-by: jukie <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: Emin Aktas <[email protected]>
Co-authored-by: Huabing (Robin) Zhao <[email protected]>
Co-authored-by: Karol Szwaj <[email protected]>
Co-authored-by: zirain <[email protected]>
Co-authored-by: Ryan Hristovski <[email protected]>
Co-authored-by: Ankush Agarwal <[email protected]>
Co-authored-by: Kota Kimura <[email protected]>
Co-authored-by: Guy Daich <[email protected]>
Co-authored-by: Isaac <[email protected]>
Co-authored-by: Emin AKTAS <[email protected]>
shawnh2 pushed a commit to shawnh2/gateway that referenced this pull request Sep 15, 2025
* feat: set OverlappingTLSConfig condition for merged Gateways (envoyproxy#5862)

* set OverlappingTLSConfig condition for merged Gateways

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

* fix lint

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

* minor change

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

---------

Signed-off-by: Huabing (Robin) Zhao <[email protected]>
(cherry picked from commit be51e5b)
Signed-off-by: Arko Dasgupta <[email protected]>

* e2e: fix backend tls test (envoyproxy#6029)

* fix backend tls test

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

* enable backend tls test

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

* remove gateway TLS to simplify the test

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

* rename secret to avoid conflicts

Signed-off-by: Huabing (Robin) Zhao <[email protected]>

---------

Signed-off-by: Huabing (Robin) Zhao <[email protected]>
(cherry picked from commit a685667)
Signed-off-by: Arko Dasgupta <[email protected]>

* validate gateway namespace mode and merged gateways (envoyproxy#6041)

* validate gateway namespace mode and merged gateways in translator

Signed-off-by: Karol Szwaj <[email protected]>

* fix lint

Signed-off-by: Karol Szwaj <[email protected]>

* skip merge gateways test

Signed-off-by: Karol Szwaj <[email protected]>

* validate on gatewayclass and set the status

Signed-off-by: Karol Szwaj <[email protected]>

* skip e2e test

Signed-off-by: Karol Szwaj <[email protected]>

* add valid testcases

Signed-off-by: Karol Szwaj <[email protected]>

* Update internal/provider/kubernetes/controller.go

Co-authored-by: Arko Dasgupta <[email protected]>
Signed-off-by: Karol Szwaj <[email protected]>

* fix lint

Signed-off-by: Karol Szwaj <[email protected]>

* skip merge gateways test

Signed-off-by: Karol Szwaj <[email protected]>

* rebase

Signed-off-by: Karol Szwaj <[email protected]>

---------

Signed-off-by: Karol Szwaj <[email protected]>
Co-authored-by: zirain <[email protected]>
Co-authored-by: Arko Dasgupta <[email protected]>
(cherry picked from commit c5f6831)
Signed-off-by: Arko Dasgupta <[email protected]>

* Fix shared=true when no clientSelector, (envoyproxy#6072)

* Fix shared=true when no clientSelector, cleanup filter logic, fix rl descriptor logic

Signed-off-by: Ryan Hristovski <[email protected]>

* testdata update

Signed-off-by: Ryan Hristovski <[email protected]>

* Linting, remove unused funcs

Signed-off-by: Ryan Hristovski <[email protected]>

* fix e2e

Signed-off-by: Ryan Hristovski <[email protected]>
(cherry picked from commit bb3c8da)
Signed-off-by: Arko Dasgupta <[email protected]>

* fix(tranlator): SubjectAltNames were being dropped from BackendTLSPolicy.validation (envoyproxy#6092)

* Add support for SubjectAltNames from BackendTLSPolicy.validation

Signed-off-by: Ankush Agarwal <[email protected]>
(cherry picked from commit 35420d5)
Signed-off-by: Arko Dasgupta <[email protected]>

* feat: add ownerreference to infra resources when gateway namespace mode (envoyproxy#6100)

* feat: add ownerreference to infra resources when gateway namespace mode

Signed-off-by: kkk777-7 <[email protected]>
(cherry picked from commit fc462a8)
Signed-off-by: Arko Dasgupta <[email protected]>

* fix: add FullDuplexStreamed to enum (envoyproxy#6103)

* fix: add FullDuplexStreamed to enum

Signed-off-by: Guy Daich <[email protected]>
(cherry picked from commit 020d60a)
Signed-off-by: Arko Dasgupta <[email protected]>

* fix: Use quoted values zone annotation in topology injector (envoyproxy#6133)

* Quoted string for zone values

Signed-off-by: jukie <[email protected]>

* release note

Signed-off-by: jukie <[email protected]>

* regen

Signed-off-by: jukie <[email protected]>
(cherry picked from commit ea9cb05)
Signed-off-by: Arko Dasgupta <[email protected]>

* fix: return early from buildwasms (envoyproxy#6169)

return early from buildwasms

Signed-off-by: Guy Daich <[email protected]>
(cherry picked from commit 64624fe)
Signed-off-by: Arko Dasgupta <[email protected]>

* chore: bump go and purego (envoyproxy#6174)

* chore: bump go and purego

Signed-off-by: zirain <[email protected]>

* fix  gen

Signed-off-by: zirain <[email protected]>

---------

Signed-off-by: zirain <[email protected]>
(cherry picked from commit 40ae9e3)
Signed-off-by: Arko Dasgupta <[email protected]>

* fix: translate xds udp listener (envoyproxy#6183)

* fix: translate udp listener

Signed-off-by: kkk777-7 <[email protected]>

* add: tcp/udp no routes testdata in xds translator

Signed-off-by: kkk777-7 <[email protected]>

* add: release note

Signed-off-by: kkk777-7 <[email protected]>
(cherry picked from commit 8f538e7)
Signed-off-by: Arko Dasgupta <[email protected]>

* Change static uid to  for global ratelimit dashboard (envoyproxy#6193)

Signed-off-by: Emin Aktas <[email protected]>
(cherry picked from commit f721925)
Signed-off-by: Arko Dasgupta <[email protected]>

* Fix broken btp ratelimit merge (envoyproxy#6214)

* Fix broken btp ratelimit merge

Signed-off-by: Ryan Hristovski <[email protected]>

* lint

Signed-off-by: Ryan Hristovski <[email protected]>

---------

Signed-off-by: Ryan Hristovski <[email protected]>
(cherry picked from commit 0f6f363)
Signed-off-by: Arko Dasgupta <[email protected]>

* Keep ALPN configuration for listeners with overlapping certificates when ALPN is explicitly set via ClientTrafficPolicy (envoyproxy#6217)

Keep ALPN configuration for listeners with overlapping certificates when ALPN is explicitly set in ClientTrafficPolicy

Signed-off-by: Huabing (Robin) Zhao <[email protected]>
(cherry picked from commit de816a6)
Signed-off-by: Arko Dasgupta <[email protected]>

* fix testdata

Signed-off-by: Arko Dasgupta <[email protected]>

* Allow for headless envoy services (envoyproxy#6250)

* Allow for headless envoy services

Signed-off-by: Ryan Hristovski <[email protected]>

* Allow headless service, cleanup

Signed-off-by: Ryan Hristovski <[email protected]>

* clean

Signed-off-by: Ryan Hristovski <[email protected]>

* Add test and comment

Signed-off-by: Ryan Hristovski <[email protected]>

* Fix tests

Signed-off-by: Ryan Hristovski <[email protected]>
(cherry picked from commit 2e168a8)
Signed-off-by: Arko Dasgupta <[email protected]>

* remove infra ENVOY_GATEWAY_NAMESPACE and introduce ENVOY_POD_NAMESPACE envVar for accesslog (envoyproxy#6221)

* remove infra ENVOY_GATEWAY_NAMESPACE and introduce ENVOY_POD_NAMESPACE envVar for accesslog

Signed-off-by: Karol Szwaj <[email protected]>

* fix e2e test

Signed-off-by: Karol Szwaj <[email protected]>

---------

Signed-off-by: Karol Szwaj <[email protected]>
(cherry picked from commit b7ed197)
Signed-off-by: Arko Dasgupta <[email protected]>

* fix lint

Signed-off-by: Arko Dasgupta <[email protected]>

---------

Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Signed-off-by: Arko Dasgupta <[email protected]>
Signed-off-by: Karol Szwaj <[email protected]>
Signed-off-by: Ryan Hristovski <[email protected]>
Signed-off-by: Ankush Agarwal <[email protected]>
Signed-off-by: kkk777-7 <[email protected]>
Signed-off-by: Guy Daich <[email protected]>
Signed-off-by: jukie <[email protected]>
Signed-off-by: zirain <[email protected]>
Signed-off-by: Emin Aktas <[email protected]>
Co-authored-by: Huabing (Robin) Zhao <[email protected]>
Co-authored-by: Karol Szwaj <[email protected]>
Co-authored-by: zirain <[email protected]>
Co-authored-by: Ryan Hristovski <[email protected]>
Co-authored-by: Ankush Agarwal <[email protected]>
Co-authored-by: Kota Kimura <[email protected]>
Co-authored-by: Guy Daich <[email protected]>
Co-authored-by: Isaac <[email protected]>
Co-authored-by: Emin AKTAS <[email protected]>
Signed-off-by: shawnh2 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants