feat: add ownerreference to infra resources when gateway namespace mode by kkk777-7 · Pull Request #6100 · envoyproxy/gateway

kkk777-7 · 2025-05-16T19:12:53Z

What this PR does / why we need it:
Add ownerreference (gateway) to infra resources when enable GatewayNamespaceMode.
This PR resolves the following issues when enable GatewayNamespaceMode.

[Not Scope in PR]
Add ownerreference (gatewayclass) to infra resources when enable merged gateways.

Which issue(s) this PR fixes:

Since the issue has not been resolved in all cases, it remains open.

Release Notes: Yes

Signed-off-by: kkk777-7 <[email protected]>

codecov · 2025-05-16T19:25:37Z

Codecov Report

Attention: Patch coverage is 83.00000% with 17 lines in your changes missing coverage. Please review.

Project coverage is 70.54%. Comparing base (0815cdc) to head (746be28).
Report is 37 commits behind head on main.

Files with missing lines	Patch %	Lines
internal/infrastructure/kubernetes/proxy_infra.go	63.41%	10 Missing and 5 partials ⚠️
...frastructure/kubernetes/proxy/resource_provider.go	96.36%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6100      +/-   ##
==========================================
+ Coverage   70.52%   70.54%   +0.01%     
==========================================
  Files         219      219              
  Lines       36348    36406      +58     
==========================================
+ Hits        25636    25682      +46     
- Misses       9190     9196       +6     
- Partials     1522     1528       +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: kkk777-7 <[email protected]>

zirain · 2025-05-16T23:49:21Z

internal/infrastructure/kubernetes/proxy/resource_provider.go

+	if r.ownerReferenceUID != nil {
+		if r.GatewayNamespaceMode {


we may change this later, but for now prefer
if conditionA && conditionB

zirain · 2025-05-16T23:51:58Z

internal/infrastructure/kubernetes/proxy/resource_provider.go

+			if uid, ok := r.ownerReferenceUID[ResourceKindGateway]; ok {
+				sa.OwnerReferences = []metav1.OwnerReference{
+					{
+						APIVersion: gatewayAPIV1Version,
+						Kind:       ResourceKindGateway,
+						Name:       utils.GetKubernetesResourceName(r.infra.Name),
+						UID:        uid,
+					},
+				}
+			}
+		}
+	}


can we simply this by using a function or prebuild it?

Adding to this, since K8s objects have the SetOwnerReferences() method (refer), can we generically set it for all the objects here like deployment, sa, svc, configmap, etc?
Eg:

func (r *ResourceRenderer) setOwnerReferences(object metav1.Object) { if r.ownerReferenceUID != nil { if r.GatewayNamespaceMode { if uid, ok := r.ownerReferenceUID[ResourceKindGateway]; ok { object.SetOwnerReferences([]metav1.OwnerReference{ { APIVersion: gatewayAPIV1Version, Kind: ResourceKindGateway, Name: utils.GetKubernetesResourceName(r.infra.Name), UID: uid, }, }) } } } }

And then r.setOwnerReferences(sa) or r.setOwnerReferences(deployment) everywhere else?

Setting OwnerReferences() everywhere also works, lgtm!

Signed-off-by: kkk777-7 <[email protected]>

kkk777-7 · 2025-05-17T04:38:52Z

@zirain @rudrakhp
thank for comment.
I've made the changes, please retake a look.

internal/infrastructure/kubernetes/proxy/resource_provider.go

Signed-off-by: kkk777-7 <[email protected]>

internal/utils/misc.go

internal/infrastructure/kubernetes/proxy_infra.go

rudrakhp · 2025-05-18T08:52:47Z

internal/infrastructure/kubernetes/proxy/resource_provider.go

 }

-func NewResourceRender(envoyNamespace, controllerNamespace, dnsDomain string, infra *ir.ProxyInfra, gateway *egv1a1.EnvoyGateway) *ResourceRender {
+func NewResourceRender(envoyNamespace, controllerNamespace, dnsDomain string, infra *ir.ProxyInfra, gateway *egv1a1.EnvoyGateway, ownerReferenceUID map[string]types.UID) *ResourceRender {


Can we pass the *kubernetes.Infra object to NewResourceRenderer to prevent frequent changes in signature? We will probably keep adding stuff like ownerReferenceUID now in the future as well.

rudrakhp · 2025-05-18T08:55:33Z

internal/infrastructure/kubernetes/proxy/resource_provider.go

 }

-func NewResourceRender(envoyNamespace, controllerNamespace, dnsDomain string, infra *ir.ProxyInfra, gateway *egv1a1.EnvoyGateway) *ResourceRender {
+func NewResourceRender(envoyNamespace, controllerNamespace, dnsDomain string, infra *ir.ProxyInfra, gateway *egv1a1.EnvoyGateway, ownerReferenceUID map[string]types.UID) *ResourceRender {


Suggested change

func NewResourceRender(envoyNamespace, controllerNamespace, dnsDomain string, infra *ir.ProxyInfra, gateway *egv1a1.EnvoyGateway, ownerReferenceUID map[string]types.UID) *ResourceRender {

func NewResourceRender(envoyNamespace, kubernetesInfra *kubernetes.Infra, infra *ir.ProxyInfra) *ResourceRender {

Maybe we can add a ResourceRenderConfig struct to wrap all the required parameters.

Thank for comments !

Can we pass the *kubernetes.Infra object to NewResourceRenderer to prevent frequent changes in signature?

I agree with you, makes a lot of sense.
To prevent cycle import, I've introduced an interface KubernetesInfraProvider.

Maybe we can add a ResourceRenderConfig struct to wrap all the required parameters.

Thank comment, If this approach is better, I’d be happy to revise it.

@kkk777-7 any of struct to wrap parameters or interface works, LGTM. Interface might be simpler since kubernetes.Infra already implements the getters, will let others pitch in.
Ideally we shouldn't have a cycle, maybe a refactor for another time, don't want to hold this PR hostage 😄

Signed-off-by: kkk777-7 <[email protected]>

…uent changes in signature Signed-off-by: kkk777-7 <[email protected]>

Signed-off-by: kkk777-7 <[email protected]>

cnvergence · 2025-05-19T09:27:14Z

thanks for adding this @kkk777-7

internal/infrastructure/kubernetes/proxy_infra.go

kkk777-7 · 2025-05-20T03:32:42Z

/retest

Signed-off-by: kkk777-7 <[email protected]>

kkk777-7 · 2025-05-20T17:05:31Z

/retest

arkodg · 2025-05-20T17:32:07Z

internal/infrastructure/kubernetes/proxy/resource_provider.go

+			ownerReferences = append(ownerReferences, metav1.OwnerReference{
+				APIVersion: gatewayAPIV1Version,
+				Kind:       ResourceKindGateway,
+				Name:       utils.GetKubernetesResourceName(r.infra.Name),


doesnt feel right, prefer if we enhanced

gateway/internal/ir/infra.go

Line 61 in dd1c66f

type InfraMetadata struct {

instead

thanks for comment, I’ll update it after work today by adding gateway name to InfraMetadata and using it in the render process.

@arkodg
I've finished the fix. Please check if it matches what you expected.
2d121b0

kkk777-7 · 2025-05-21T04:29:01Z

I found a case where e2e test fails in my PR.
https://github.com/envoyproxy/gateway/actions/runs/15141960646/job/42573699817?pr=6100

But, Maybe I believe it will be resolved once the following PR is merged into main.
#6041

Currently it is not supported to run Gateway Namespace Mode with Merged Gateways deployments.

arkodg · 2025-05-22T00:34:32Z

internal/gatewayapi/translator.go

@@ -310,9 +310,11 @@ func (t *Translator) InitIRs(gateways []*GatewayContext) (map[string]*ir.Xds, ma
 		if t.MergeGateways {
 			maps.Copy(labels, GatewayClassOwnerLabel(string(t.GatewayClassName)))
 			gwInfraIR.Proxy.GetProxyMetadata().Labels = labels
+			gwInfraIR.Proxy.GetProxyMetadata().Name = irKey


should this logic be ?
if GatewayNamespaceMode {
gwInfraIR.Proxy.GetProxyMetadata().OwnerReference = &ir.ResourceMetadata {
Kind: "Gateway"
......
} else {

gwInfraIR.Proxy.GetProxyMetadata().OwnerReference = &ir.ResourceMetadata {
Kind: Deployment
Name: ....
}

I would also be up for setting OwnerReference, having two Names fields in InfraIR is somewhat confusing

Setting OwnerReference makes sense! I've finished the fix.

Signed-off-by: kkk777-7 <[email protected]>

arkodg · 2025-05-22T16:51:29Z

internal/gatewayapi/translator.go

 		if t.GatewayNamespaceMode {
 			gwInfraIR.Proxy.Namespace = gateway.Namespace
+			gwInfraIR.Proxy.GetProxyMetadata().OwnerReference = &ir.ResourceMetadata{
+				Kind: "Gateway",


nit: lets use existing constant KindGateway

arkodg · 2025-05-22T16:51:43Z

internal/infrastructure/kubernetes/proxy/resource_provider.go

 	XdsTLSCaFileName = "ca.crt"
+
+	// ResourceKind indicates owner of infra proxy resources.
+	ResourceKindGateway = "Gateway"


already defined in https://github.com/envoyproxy/gateway/blob/main/internal/gatewayapi/resource/supported_kind.go

Thanks you for letting me know!

arkodg · 2025-05-22T16:53:25Z

internal/infrastructure/kubernetes/proxy/resource_provider.go

+	// ResourceKind indicates owner of infra proxy resources.
+	ResourceKindGateway = "Gateway"
+
+	gatewayAPIV1Version = "gateway.networking.k8s.io/v1"


can you retrieve this from the package instead ? gwapiv1.GroupVersion.Version ?

fixed retrieving this from the package.

arkodg · 2025-05-22T16:54:47Z

internal/infrastructure/kubernetes/proxy/resource_provider.go

+		if uid, ok := r.ownerReferenceUID[ResourceKindGateway]; ok {
+			ownerReferences = append(ownerReferences, metav1.OwnerReference{
+				APIVersion: gatewayAPIV1Version,
+				Kind:       ResourceKindGateway,


can we also get the Kind from the IR

internal/infrastructure/kubernetes/proxy/testdata/serviceaccount/gateway-namespace-mode.yaml

Signed-off-by: kkk777-7 <[email protected]>

arkodg

curious about one thing - when a Gateway is deleted in GatewayNamespace mode, now the API server will delete the Deployment, there will be a race b/w the API server and EG to delete the resource, if the API server gets there 1st, will it show up as a err log in EG or does is gracefully handle this case today ?

kkk777-7 · 2025-05-23T02:55:15Z

curious about one thing - when a Gateway is deleted in GatewayNamespace mode, now the API server will delete the Deployment, there will be a race b/w the API server and EG to delete the resource, if the API server gets there 1st, will it show up as a err log in EG or does is gracefully handle this case today ?

@arkodg That's a good point.
Infra struct call i.Client.DeleteAllOf when deleting resources.
e.g. https://github.com/envoyproxy/gateway/blob/main/internal/infrastructure/kubernetes/infra_resource.go#L453-L457

Maybe, controller-runtime's DeleteAllOf doesn't return an error if the resource isn't found. So I think EG can gracefully handle.

On a related note, InfraClient wraps the Delete method to handle errors. So, This can also be handled gracefully.
https://github.com/envoyproxy/gateway/blob/main/internal/infrastructure/kubernetes/infra_client.go#L72-L81

arkodg

LGTM thanks !

zirain · 2025-05-23T04:05:49Z

/retest

…de (envoyproxy#6100) * feat: add ownerreference to infra resources when gateway namespace mode Signed-off-by: kkk777-7 <[email protected]> (cherry picked from commit fc462a8) Signed-off-by: Arko Dasgupta <[email protected]>

* feat: set OverlappingTLSConfig condition for merged Gateways (#5862) * set OverlappingTLSConfig condition for merged Gateways Signed-off-by: Huabing (Robin) Zhao <[email protected]> * fix lint Signed-off-by: Huabing (Robin) Zhao <[email protected]> * minor change Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> (cherry picked from commit be51e5b) Signed-off-by: Arko Dasgupta <[email protected]> * e2e: fix backend tls test (#6029) * fix backend tls test Signed-off-by: Huabing (Robin) Zhao <[email protected]> * enable backend tls test Signed-off-by: Huabing (Robin) Zhao <[email protected]> * remove gateway TLS to simplify the test Signed-off-by: Huabing (Robin) Zhao <[email protected]> * rename secret to avoid conflicts Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> (cherry picked from commit a685667) Signed-off-by: Arko Dasgupta <[email protected]> * validate gateway namespace mode and merged gateways (#6041) * validate gateway namespace mode and merged gateways in translator Signed-off-by: Karol Szwaj <[email protected]> * fix lint Signed-off-by: Karol Szwaj <[email protected]> * skip merge gateways test Signed-off-by: Karol Szwaj <[email protected]> * validate on gatewayclass and set the status Signed-off-by: Karol Szwaj <[email protected]> * skip e2e test Signed-off-by: Karol Szwaj <[email protected]> * add valid testcases Signed-off-by: Karol Szwaj <[email protected]> * Update internal/provider/kubernetes/controller.go Co-authored-by: Arko Dasgupta <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix lint Signed-off-by: Karol Szwaj <[email protected]> * skip merge gateways test Signed-off-by: Karol Szwaj <[email protected]> * rebase Signed-off-by: Karol Szwaj <[email protected]> --------- Signed-off-by: Karol Szwaj <[email protected]> Co-authored-by: zirain <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]> (cherry picked from commit c5f6831) Signed-off-by: Arko Dasgupta <[email protected]> * Fix shared=true when no clientSelector, (#6072) * Fix shared=true when no clientSelector, cleanup filter logic, fix rl descriptor logic Signed-off-by: Ryan Hristovski <[email protected]> * testdata update Signed-off-by: Ryan Hristovski <[email protected]> * Linting, remove unused funcs Signed-off-by: Ryan Hristovski <[email protected]> * fix e2e Signed-off-by: Ryan Hristovski <[email protected]> (cherry picked from commit bb3c8da) Signed-off-by: Arko Dasgupta <[email protected]> * fix(tranlator): SubjectAltNames were being dropped from BackendTLSPolicy.validation (#6092) * Add support for SubjectAltNames from BackendTLSPolicy.validation Signed-off-by: Ankush Agarwal <[email protected]> (cherry picked from commit 35420d5) Signed-off-by: Arko Dasgupta <[email protected]> * feat: add ownerreference to infra resources when gateway namespace mode (#6100) * feat: add ownerreference to infra resources when gateway namespace mode Signed-off-by: kkk777-7 <[email protected]> (cherry picked from commit fc462a8) Signed-off-by: Arko Dasgupta <[email protected]> * fix: add FullDuplexStreamed to enum (#6103) * fix: add FullDuplexStreamed to enum Signed-off-by: Guy Daich <[email protected]> (cherry picked from commit 020d60a) Signed-off-by: Arko Dasgupta <[email protected]> * fix: Use quoted values zone annotation in topology injector (#6133) * Quoted string for zone values Signed-off-by: jukie <[email protected]> * release note Signed-off-by: jukie <[email protected]> * regen Signed-off-by: jukie <[email protected]> (cherry picked from commit ea9cb05) Signed-off-by: Arko Dasgupta <[email protected]> * fix: return early from buildwasms (#6169) return early from buildwasms Signed-off-by: Guy Daich <[email protected]> (cherry picked from commit 64624fe) Signed-off-by: Arko Dasgupta <[email protected]> * chore: bump go and purego (#6174) * chore: bump go and purego Signed-off-by: zirain <[email protected]> * fix gen Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> (cherry picked from commit 40ae9e3) Signed-off-by: Arko Dasgupta <[email protected]> * fix: translate xds udp listener (#6183) * fix: translate udp listener Signed-off-by: kkk777-7 <[email protected]> * add: tcp/udp no routes testdata in xds translator Signed-off-by: kkk777-7 <[email protected]> * add: release note Signed-off-by: kkk777-7 <[email protected]> (cherry picked from commit 8f538e7) Signed-off-by: Arko Dasgupta <[email protected]> * Change static uid to for global ratelimit dashboard (#6193) Signed-off-by: Emin Aktas <[email protected]> (cherry picked from commit f721925) Signed-off-by: Arko Dasgupta <[email protected]> * Fix broken btp ratelimit merge (#6214) * Fix broken btp ratelimit merge Signed-off-by: Ryan Hristovski <[email protected]> * lint Signed-off-by: Ryan Hristovski <[email protected]> --------- Signed-off-by: Ryan Hristovski <[email protected]> (cherry picked from commit 0f6f363) Signed-off-by: Arko Dasgupta <[email protected]> * Keep ALPN configuration for listeners with overlapping certificates when ALPN is explicitly set via ClientTrafficPolicy (#6217) Keep ALPN configuration for listeners with overlapping certificates when ALPN is explicitly set in ClientTrafficPolicy Signed-off-by: Huabing (Robin) Zhao <[email protected]> (cherry picked from commit de816a6) Signed-off-by: Arko Dasgupta <[email protected]> * fix testdata Signed-off-by: Arko Dasgupta <[email protected]> * Allow for headless envoy services (#6250) * Allow for headless envoy services Signed-off-by: Ryan Hristovski <[email protected]> * Allow headless service, cleanup Signed-off-by: Ryan Hristovski <[email protected]> * clean Signed-off-by: Ryan Hristovski <[email protected]> * Add test and comment Signed-off-by: Ryan Hristovski <[email protected]> * Fix tests Signed-off-by: Ryan Hristovski <[email protected]> (cherry picked from commit 2e168a8) Signed-off-by: Arko Dasgupta <[email protected]> * remove infra ENVOY_GATEWAY_NAMESPACE and introduce ENVOY_POD_NAMESPACE envVar for accesslog (#6221) * remove infra ENVOY_GATEWAY_NAMESPACE and introduce ENVOY_POD_NAMESPACE envVar for accesslog Signed-off-by: Karol Szwaj <[email protected]> * fix e2e test Signed-off-by: Karol Szwaj <[email protected]> --------- Signed-off-by: Karol Szwaj <[email protected]> (cherry picked from commit b7ed197) Signed-off-by: Arko Dasgupta <[email protected]> * fix lint Signed-off-by: Arko Dasgupta <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> Signed-off-by: Ryan Hristovski <[email protected]> Signed-off-by: Ankush Agarwal <[email protected]> Signed-off-by: kkk777-7 <[email protected]> Signed-off-by: Guy Daich <[email protected]> Signed-off-by: jukie <[email protected]> Signed-off-by: zirain <[email protected]> Signed-off-by: Emin Aktas <[email protected]> Co-authored-by: Huabing (Robin) Zhao <[email protected]> Co-authored-by: Karol Szwaj <[email protected]> Co-authored-by: zirain <[email protected]> Co-authored-by: Ryan Hristovski <[email protected]> Co-authored-by: Ankush Agarwal <[email protected]> Co-authored-by: Kota Kimura <[email protected]> Co-authored-by: Guy Daich <[email protected]> Co-authored-by: Isaac <[email protected]> Co-authored-by: Emin AKTAS <[email protected]>

* feat: set OverlappingTLSConfig condition for merged Gateways (envoyproxy#5862) * set OverlappingTLSConfig condition for merged Gateways Signed-off-by: Huabing (Robin) Zhao <[email protected]> * fix lint Signed-off-by: Huabing (Robin) Zhao <[email protected]> * minor change Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> (cherry picked from commit be51e5b) Signed-off-by: Arko Dasgupta <[email protected]> * e2e: fix backend tls test (envoyproxy#6029) * fix backend tls test Signed-off-by: Huabing (Robin) Zhao <[email protected]> * enable backend tls test Signed-off-by: Huabing (Robin) Zhao <[email protected]> * remove gateway TLS to simplify the test Signed-off-by: Huabing (Robin) Zhao <[email protected]> * rename secret to avoid conflicts Signed-off-by: Huabing (Robin) Zhao <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> (cherry picked from commit a685667) Signed-off-by: Arko Dasgupta <[email protected]> * validate gateway namespace mode and merged gateways (envoyproxy#6041) * validate gateway namespace mode and merged gateways in translator Signed-off-by: Karol Szwaj <[email protected]> * fix lint Signed-off-by: Karol Szwaj <[email protected]> * skip merge gateways test Signed-off-by: Karol Szwaj <[email protected]> * validate on gatewayclass and set the status Signed-off-by: Karol Szwaj <[email protected]> * skip e2e test Signed-off-by: Karol Szwaj <[email protected]> * add valid testcases Signed-off-by: Karol Szwaj <[email protected]> * Update internal/provider/kubernetes/controller.go Co-authored-by: Arko Dasgupta <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> * fix lint Signed-off-by: Karol Szwaj <[email protected]> * skip merge gateways test Signed-off-by: Karol Szwaj <[email protected]> * rebase Signed-off-by: Karol Szwaj <[email protected]> --------- Signed-off-by: Karol Szwaj <[email protected]> Co-authored-by: zirain <[email protected]> Co-authored-by: Arko Dasgupta <[email protected]> (cherry picked from commit c5f6831) Signed-off-by: Arko Dasgupta <[email protected]> * Fix shared=true when no clientSelector, (envoyproxy#6072) * Fix shared=true when no clientSelector, cleanup filter logic, fix rl descriptor logic Signed-off-by: Ryan Hristovski <[email protected]> * testdata update Signed-off-by: Ryan Hristovski <[email protected]> * Linting, remove unused funcs Signed-off-by: Ryan Hristovski <[email protected]> * fix e2e Signed-off-by: Ryan Hristovski <[email protected]> (cherry picked from commit bb3c8da) Signed-off-by: Arko Dasgupta <[email protected]> * fix(tranlator): SubjectAltNames were being dropped from BackendTLSPolicy.validation (envoyproxy#6092) * Add support for SubjectAltNames from BackendTLSPolicy.validation Signed-off-by: Ankush Agarwal <[email protected]> (cherry picked from commit 35420d5) Signed-off-by: Arko Dasgupta <[email protected]> * feat: add ownerreference to infra resources when gateway namespace mode (envoyproxy#6100) * feat: add ownerreference to infra resources when gateway namespace mode Signed-off-by: kkk777-7 <[email protected]> (cherry picked from commit fc462a8) Signed-off-by: Arko Dasgupta <[email protected]> * fix: add FullDuplexStreamed to enum (envoyproxy#6103) * fix: add FullDuplexStreamed to enum Signed-off-by: Guy Daich <[email protected]> (cherry picked from commit 020d60a) Signed-off-by: Arko Dasgupta <[email protected]> * fix: Use quoted values zone annotation in topology injector (envoyproxy#6133) * Quoted string for zone values Signed-off-by: jukie <[email protected]> * release note Signed-off-by: jukie <[email protected]> * regen Signed-off-by: jukie <[email protected]> (cherry picked from commit ea9cb05) Signed-off-by: Arko Dasgupta <[email protected]> * fix: return early from buildwasms (envoyproxy#6169) return early from buildwasms Signed-off-by: Guy Daich <[email protected]> (cherry picked from commit 64624fe) Signed-off-by: Arko Dasgupta <[email protected]> * chore: bump go and purego (envoyproxy#6174) * chore: bump go and purego Signed-off-by: zirain <[email protected]> * fix gen Signed-off-by: zirain <[email protected]> --------- Signed-off-by: zirain <[email protected]> (cherry picked from commit 40ae9e3) Signed-off-by: Arko Dasgupta <[email protected]> * fix: translate xds udp listener (envoyproxy#6183) * fix: translate udp listener Signed-off-by: kkk777-7 <[email protected]> * add: tcp/udp no routes testdata in xds translator Signed-off-by: kkk777-7 <[email protected]> * add: release note Signed-off-by: kkk777-7 <[email protected]> (cherry picked from commit 8f538e7) Signed-off-by: Arko Dasgupta <[email protected]> * Change static uid to for global ratelimit dashboard (envoyproxy#6193) Signed-off-by: Emin Aktas <[email protected]> (cherry picked from commit f721925) Signed-off-by: Arko Dasgupta <[email protected]> * Fix broken btp ratelimit merge (envoyproxy#6214) * Fix broken btp ratelimit merge Signed-off-by: Ryan Hristovski <[email protected]> * lint Signed-off-by: Ryan Hristovski <[email protected]> --------- Signed-off-by: Ryan Hristovski <[email protected]> (cherry picked from commit 0f6f363) Signed-off-by: Arko Dasgupta <[email protected]> * Keep ALPN configuration for listeners with overlapping certificates when ALPN is explicitly set via ClientTrafficPolicy (envoyproxy#6217) Keep ALPN configuration for listeners with overlapping certificates when ALPN is explicitly set in ClientTrafficPolicy Signed-off-by: Huabing (Robin) Zhao <[email protected]> (cherry picked from commit de816a6) Signed-off-by: Arko Dasgupta <[email protected]> * fix testdata Signed-off-by: Arko Dasgupta <[email protected]> * Allow for headless envoy services (envoyproxy#6250) * Allow for headless envoy services Signed-off-by: Ryan Hristovski <[email protected]> * Allow headless service, cleanup Signed-off-by: Ryan Hristovski <[email protected]> * clean Signed-off-by: Ryan Hristovski <[email protected]> * Add test and comment Signed-off-by: Ryan Hristovski <[email protected]> * Fix tests Signed-off-by: Ryan Hristovski <[email protected]> (cherry picked from commit 2e168a8) Signed-off-by: Arko Dasgupta <[email protected]> * remove infra ENVOY_GATEWAY_NAMESPACE and introduce ENVOY_POD_NAMESPACE envVar for accesslog (envoyproxy#6221) * remove infra ENVOY_GATEWAY_NAMESPACE and introduce ENVOY_POD_NAMESPACE envVar for accesslog Signed-off-by: Karol Szwaj <[email protected]> * fix e2e test Signed-off-by: Karol Szwaj <[email protected]> --------- Signed-off-by: Karol Szwaj <[email protected]> (cherry picked from commit b7ed197) Signed-off-by: Arko Dasgupta <[email protected]> * fix lint Signed-off-by: Arko Dasgupta <[email protected]> --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]> Signed-off-by: Arko Dasgupta <[email protected]> Signed-off-by: Karol Szwaj <[email protected]> Signed-off-by: Ryan Hristovski <[email protected]> Signed-off-by: Ankush Agarwal <[email protected]> Signed-off-by: kkk777-7 <[email protected]> Signed-off-by: Guy Daich <[email protected]> Signed-off-by: jukie <[email protected]> Signed-off-by: zirain <[email protected]> Signed-off-by: Emin Aktas <[email protected]> Co-authored-by: Huabing (Robin) Zhao <[email protected]> Co-authored-by: Karol Szwaj <[email protected]> Co-authored-by: zirain <[email protected]> Co-authored-by: Ryan Hristovski <[email protected]> Co-authored-by: Ankush Agarwal <[email protected]> Co-authored-by: Kota Kimura <[email protected]> Co-authored-by: Guy Daich <[email protected]> Co-authored-by: Isaac <[email protected]> Co-authored-by: Emin AKTAS <[email protected]> Signed-off-by: shawnh2 <[email protected]>

feat: add ownerreference to infra resources when gateway namespace mode

aa41c32

Signed-off-by: kkk777-7 <[email protected]>

kkk777-7 requested a review from a team as a code owner May 16, 2025 19:12

add: release note

895ba05

Signed-off-by: kkk777-7 <[email protected]>

fix: gen-check

c61e961

Signed-off-by: kkk777-7 <[email protected]>

kkk777-7 force-pushed the add-ownerref-gtw-ns-mode branch from e0c6a50 to c61e961 Compare May 16, 2025 19:47

zirain reviewed May 16, 2025

View reviewed changes

kkk777-7 added 3 commits May 17, 2025 12:34

fix: golint

c20992a

Signed-off-by: kkk777-7 <[email protected]>

refactor: set ownerreference

00f7f31

Signed-off-by: kkk777-7 <[email protected]>

Merge branch 'main' into add-ownerref-gtw-ns-mode

a59dc8b

Signed-off-by: kkk777-7 <[email protected]>

rudrakhp reviewed May 17, 2025

View reviewed changes

internal/infrastructure/kubernetes/proxy/resource_provider.go Outdated Show resolved Hide resolved

fix: return immediately

43fd39b

Signed-off-by: kkk777-7 <[email protected]>

This comment was marked as outdated.

Sign in to view

Merge branch 'main' into add-ownerref-gtw-ns-mode

135dac9

rudrakhp reviewed May 18, 2025

View reviewed changes

kkk777-7 added 4 commits May 19, 2025 00:57

refactor: simplify

315d25f

Signed-off-by: kkk777-7 <[email protected]>

refactor: move to method

5258323

Signed-off-by: kkk777-7 <[email protected]>

refactor: introduce KubernetesInfraProvider interface to prevent freq…

a1d538d

…uent changes in signature Signed-off-by: kkk777-7 <[email protected]>

fix: golint

af45197

Signed-off-by: kkk777-7 <[email protected]>

rudrakhp requested review from a team May 19, 2025 08:18

cnvergence reviewed May 19, 2025

View reviewed changes

internal/infrastructure/kubernetes/proxy_infra.go Outdated Show resolved Hide resolved

fix: argument name

808829d

Signed-off-by: kkk777-7 <[email protected]>

arkodg reviewed May 20, 2025

View reviewed changes

arkodg reviewed May 22, 2025

View reviewed changes

kkk777-7 added 3 commits May 23, 2025 01:10

add ownerreference field in infra ir for rendering infra resources

3250d82

Signed-off-by: kkk777-7 <[email protected]>

Merge branch 'main' into add-ownerref-gtw-ns-mode

87e8269

Signed-off-by: kkk777-7 <[email protected]>

fix gen-check

62b7c48

Signed-off-by: kkk777-7 <[email protected]>

arkodg reviewed May 22, 2025

View reviewed changes

internal/infrastructure/kubernetes/proxy/testdata/serviceaccount/gateway-namespace-mode.yaml Show resolved Hide resolved

use already defined constant

3190d09

Signed-off-by: kkk777-7 <[email protected]>

arkodg reviewed May 23, 2025

View reviewed changes

arkodg approved these changes May 23, 2025

View reviewed changes

arkodg requested review from a team May 23, 2025 03:00

zirain approved these changes May 23, 2025

View reviewed changes

Merge branch 'main' into add-ownerref-gtw-ns-mode

746be28

arkodg merged commit fc462a8 into envoyproxy:main May 23, 2025
44 of 45 checks passed

kkk777-7 deleted the add-ownerref-gtw-ns-mode branch May 23, 2025 11:46

kkk777-7 mentioned this pull request Jun 1, 2025

feat: add gatewayclass ownerreference to infra resources when all cases except gateway namespace mode #6238

Merged

shawnh2 added the cherrypick/release-v1.4.1 label Jun 3, 2025

arkodg mentioned this pull request Jun 11, 2025

Set ownerReference on gateway Deployment #3051

Closed

arkodg mentioned this pull request Jun 26, 2025

Nominating kkk777-7 as a Reviewer #6419

Closed

BrewTestBot mentioned this pull request Aug 8, 2025

egctl 1.5.0 Homebrew/homebrew-core#232799

Merged

arkodg mentioned this pull request Oct 1, 2025

Nominate kkk777-7 as Maintainer #7112

Closed

	func NewResourceRender(envoyNamespace, controllerNamespace, dnsDomain string, infra ir.ProxyInfra, gateway egv1a1.EnvoyGateway, ownerReferenceUID map[string]types.UID) *ResourceRender {
	func NewResourceRender(envoyNamespace, kubernetesInfra kubernetes.Infra, infra ir.ProxyInfra) *ResourceRender {

Conversation

kkk777-7 commented May 16, 2025

Uh oh!

codecov bot commented May 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kkk777-7 commented May 17, 2025

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cnvergence commented May 19, 2025

Uh oh!

Uh oh!

kkk777-7 commented May 20, 2025

Uh oh!

kkk777-7 commented May 20, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kkk777-7 commented May 21, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

arkodg left a comment

Choose a reason for hiding this comment

Uh oh!

kkk777-7 commented May 23, 2025

Uh oh!

arkodg left a comment

Choose a reason for hiding this comment

Uh oh!

zirain commented May 23, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

codecov bot commented May 16, 2025 •

edited

Loading