feat: impl credential injection#5496
Merged
zirain merged 13 commits intoenvoyproxy:mainfrom Apr 14, 2025
Merged
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (50.99%) is below the target coverage (60.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #5496 +/- ##
==========================================
- Coverage 65.34% 65.21% -0.13%
==========================================
Files 213 214 +1
Lines 34121 34321 +200
==========================================
+ Hits 22295 22382 +87
- Misses 10489 10589 +100
- Partials 1337 1350 +13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zhaohuabing
force-pushed
the
impl-4757
branch
5 times, most recently
from
65b7fbb to
7c959b8
Compare
zhaohuabing
commented
Mar 17, 2025
Member
Author
|
This PR is ready for review and can be merged once this Envoy credential injector issue is resolved. |
zhaohuabing
changed the title
This was referenced Mar 19, 2025
zirain
reviewed
Mar 26, 2025
Member
Author
|
@arkodg This one is ready. |
jewertow
pushed a commit
to jewertow/envoy
that referenced
this pull request
Apr 2, 2025
fix: envoyproxy/gateway#5496 (comment) We should use the initManager in the DualInfo because the Credential Injector can be used for both HCM filter and upstream filter. Using the initManger from the ServerFactoryContext for HCM filter causes the secret to be added to the server initManager when it's already in the initialized state. Change log should not be required as this fixes a bug introduced in [a RP](envoyproxy#38398) that just merged after v1.33.0 . @yanavlasov --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]>
agrawroh
pushed a commit
to agrawroh/envoy
that referenced
this pull request
Apr 9, 2025
fix: envoyproxy/gateway#5496 (comment) We should use the initManager in the DualInfo because the Credential Injector can be used for both HCM filter and upstream filter. Using the initManger from the ServerFactoryContext for HCM filter causes the secret to be added to the server initManager when it's already in the initialized state. Change log should not be required as this fixes a bug introduced in [a RP](envoyproxy#38398) that just merged after v1.33.0 . @yanavlasov --------- Signed-off-by: Huabing (Robin) Zhao <[email protected]>
arkodg
reviewed
Apr 9, 2025
internal/xds/translator/testdata/out/xds-ir/credential-injection.listeners.yaml
Outdated
Show resolved
Hide resolved
arkodg
reviewed
Apr 9, 2025
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Co-authored-by: Arko Dasgupta <[email protected]> Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
Signed-off-by: Huabing (Robin) Zhao <[email protected]>
arkodg
reviewed
Apr 10, 2025
arkodg
reviewed
Apr 10, 2025
Co-authored-by: Arko Dasgupta <[email protected]> Signed-off-by: Huabing (Robin) Zhao <[email protected]>
arkodg
approved these changes
Apr 11, 2025
zirain
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements the credential injection HTTPRoute filter, which allows adding credentials from a k8s secret into the Authorization header. It can be useful for egress scenarios, where authentication is required when talking to a backend service.
Implements #4757
Release Notes: Yes